[dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name overflow

[dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name overflow

[Pavan Nikhilesh]

Bugzilla-ID: 28
Fixes: f874c1eb1519 ("event/octeontx: create and free timer adapter")

Reported-by: Harry van Haaren <harry.van.haaren@intel.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 drivers/event/octeontx/timvf_evdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/event/octeontx/timvf_evdev.c b/drivers/event/octeontx/timvf_evdev.c
index 22f534be6..c4fbd2d86 100644
--- a/drivers/event/octeontx/timvf_evdev.c
+++ b/drivers/event/octeontx/timvf_evdev.c
@@ -294,7 +294,8 @@ timvf_ring_create(struct rte_event_timer_adapter *adptr)
 	if (timr->bkt == NULL)
 		goto mem_err;
 
-	snprintf(pool_name, 30, "timvf_chunk_pool%d", timr->tim_ring_id);
+	snprintf(pool_name, sizeof(pool_name), "timvf_chunk_pool%d",
+			timr->tim_ring_id);
 	timr->chunk_pool = (void *)rte_mempool_create_empty(pool_name,
 			timr->nb_chunks, TIM_CHUNK_SIZE, 0, 0, rte_socket_id(),
 			mp_flags);
-- 
2.17.0

Re: [dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name overflow

[Van Haaren, Harry]

> From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> Sent: Monday, April 23, 2018 2:40 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name overflow
> 
> Bugzilla-ID: 28
> Fixes: f874c1eb1519 ("event/octeontx: create and free timer adapter")
> 
> Reported-by: Harry van Haaren <harry.van.haaren@intel.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>


Nice one, confirmed as fixed!

I wasn't aware Bugzilla had a diff view; The patch as attachment is viewable here:
https://dpdk.org/tracker/attachment.cgi?id=5&action=diff


Tested-by: Harry van Haaren <harry.van.haaren@intel.com>

Re: [dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name overflow

[Van Haaren, Harry]

+CC Thomas, would you take this one asap it fixes a build warning with Meson/GCC 5.4 on Ubuntu with fortified headers.

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Van Haaren, Harry
> Sent: Monday, April 23, 2018 3:21 PM
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name
> overflow
> 
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Monday, April 23, 2018 2:40 PM
> > To: Van Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name
> overflow
> >
> > Bugzilla-ID: 28
> > Fixes: f874c1eb1519 ("event/octeontx: create and free timer adapter")
> >
> > Reported-by: Harry van Haaren <harry.van.haaren@intel.com>
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> 
> 
> Nice one, confirmed as fixed!
> 
> I wasn't aware Bugzilla had a diff view; The patch as attachment is viewable
> here:
> https://dpdk.org/tracker/attachment.cgi?id=5&action=diff
> 
> 
> Tested-by: Harry van Haaren <harry.van.haaren@intel.com>

Re: [dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name overflow

[Thomas Monjalon]

25/04/2018 14:54, Van Haaren, Harry:
> 
> +CC Thomas, would you take this one asap it fixes a build warning with Meson/GCC 5.4 on Ubuntu with fortified headers.
> 
> > > Bugzilla-ID: 28
> > > Fixes: f874c1eb1519 ("event/octeontx: create and free timer adapter")
> > >
> > > Reported-by: Harry van Haaren <harry.van.haaren@intel.com>
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > 
> > 
> > Nice one, confirmed as fixed!
> > 
> > I wasn't aware Bugzilla had a diff view; The patch as attachment is viewable
> > here:
> > https://dpdk.org/tracker/attachment.cgi?id=5&action=diff

It's nice :)

I have update the Bugzilla ticket, especially the field URL
with the link to see the commit in cgit.

> > Tested-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks

Re: [dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name overflow

[Van Haaren, Harry]

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, April 25, 2018 3:56 PM
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name
> overflow
> 
> 25/04/2018 14:54, Van Haaren, Harry:
> >
> > +CC Thomas, would you take this one asap it fixes a build warning with
> Meson/GCC 5.4 on Ubuntu with fortified headers.
> >
> > > > Bugzilla-ID: 28
> > > > Fixes: f874c1eb1519 ("event/octeontx: create and free timer adapter")
> > > >
> > > > Reported-by: Harry van Haaren <harry.van.haaren@intel.com>
> > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > >
> > >
> > > Nice one, confirmed as fixed!
> > >
> > > I wasn't aware Bugzilla had a diff view; The patch as attachment is
> viewable
> > > here:
> > > https://dpdk.org/tracker/attachment.cgi?id=5&action=diff
> 
> It's nice :)
> 
> I have update the Bugzilla ticket, especially the field URL
> with the link to see the commit in cgit.

I'm working on documenting a suggested workflow, will include
the steps above.

Thanks!