From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 8513B374 for ; Tue, 24 Apr 2018 12:26:42 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id w3-v6so49236260wrg.2 for ; Tue, 24 Apr 2018 03:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=XOzt3vaNVff2GTqrly6pnoDL/2/vgMDCZzncfvsyT40=; b=fBUO8DNx6q/QyuxsRb0iy/9RvHoniha5xwHMeMh3n85PK/d3QTe6dZelJDeuaNB2h7 THzTigM9eV/iZpAbt730lAgS/IDem/teQPcP5yQAZLg8iekj+K8/fDVcLwWvp6nUis3p 6tIi2kfiF87XxYkIRPCuUSKElSeutO0WPym1s1QTyvaUe7wN4IpN8qVYzjNMP3lQoOmM 96ZZjXDXtqgvIdUiyZwAgwkhGw2GQTZrYY6HgTHFHDXHTrmA72/2KxWoiElGUOjSh35o aqoqSJc2g296U78H/81vqB46sWFZEKI0UNpjhJOuhwIR0hLqEY4fJPlLczmnfLi2abmY nhjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=XOzt3vaNVff2GTqrly6pnoDL/2/vgMDCZzncfvsyT40=; b=OYjvfSHIR7qfNdCFpSuGHABtx09IJnx3QOllajwN8XoyCpAywJZqBtfYVJ96B8O85J 6kLf+kTmKwHKGVIMymYZeQ6JT4lof/30tRMawUU2t07ArLOhMdsYC67V+eXqIOpfrIoT KqB7kdLHEDtP43G16F9WDmOtfpEyvD2k1PNeISOail86uMDrY+UGLKAe4Bi1xYRQG9qK Oq1SyFQPPMNL0hcKbMxYU3ATTLe/3ZAuEiCmSFsWq1aqJ6FYQhgBGiMrVNNzQZZQF0Iq pDVCBhXIIry6l8Xm9rACn6yJ4QtCQBGn1fQEVYeph3OWUZlI2eNWRJG+4vZ4zsoQLiCm O7LA== X-Gm-Message-State: ALQs6tCEmJ3C/wwQ3NrNOd6ghNlADWF2ZukkLp7J8tTent6oQn/GiHEg MsYkLgSiIV53HH0dpfK/JIQTK/PF X-Google-Smtp-Source: AIpwx4+PFnWkTMB66opwkYm7NwVgKC2ljDoMPdZHVL7yWmOOvbd36DW2H8bO1/tKSHdysVUh1/7zgA== X-Received: by 2002:adf:c74b:: with SMTP id b11-v6mr20501251wrh.236.1524565602214; Tue, 24 Apr 2018 03:26:42 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b5-v6sm21367582wrh.67.2018.04.24.03.26.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 03:26:41 -0700 (PDT) Date: Tue, 24 Apr 2018 12:26:27 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20180424102627.ler3gqjou4peaquy@bidouze.vm.6wind.com> References: <224c73b2d7b27f32376334041c217533803a7354.1524522515.git.gaetan.rivet@6wind.com> <20180423165619.185f417a@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180423165619.185f417a@xeon-e3> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 02/10] devargs: introduce foreach macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 10:26:42 -0000 On Mon, Apr 23, 2018 at 04:56:19PM -0700, Stephen Hemminger wrote: > On Tue, 24 Apr 2018 00:41:02 +0200 > Gaetan Rivet wrote: > > > Introduce new rte_devargs accessor allowing to iterate over all > > rte_devargs pertaining to a bus. > > > > Signed-off-by: Gaetan Rivet > > --- > > Aren't devargs intended to be internal and not part of ABI. > If so maybe the experimental tag is not necessary, and you > want to say that in the comments. The ABI is exposed, so any third-party declaring rte_devargs would be impacted by changes to the structure. I don't think it's internal. In any case, the API itself is not internal, and the rte_experimental tag is meant for API I think? This function is new and prone to changes as well as part of the public EAL API, I think it is correct to tag it experimental. -- Gaëtan Rivet 6WIND