From: Stephen Hemminger <stephen@networkplumber.org>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: thomas@monjalon.net, anatoly.burakov@intel.com,
wenzhuo.lu@intel.com, declan.doherty@intel.com,
jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 02/11] bond: replace rte_panic instances in bonding driver
Date: Tue, 24 Apr 2018 15:51:46 -0700 [thread overview]
Message-ID: <20180424155146.35f5031f@xeon-e3> (raw)
In-Reply-To: <1524608213-2080-3-git-send-email-arnon@qwilt.com>
On Wed, 25 Apr 2018 01:16:44 +0300
Arnon Warshavsky <arnon@qwilt.com> wrote:
> replace panic calls with log and return value.
> Local functions to this file,
> changing from void to int are non-abi-breaking
>
> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
> ---
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
> drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++++++++++++++---------
> drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +-
> drivers/net/bonding/rte_eth_bond_api.c | 22 ++++++++++++-----
> drivers/net/bonding/rte_eth_bond_pmd.c | 9 ++++---
> drivers/net/bonding/rte_eth_bond_private.h | 2 +-
> 6 files changed, 43 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> index a78f3a2..a19fb40 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> @@ -2884,7 +2884,7 @@ struct rte_security_ops dpaa2_sec_security_ops = {
> rte_socket_id());
>
> if (cryptodev->data->dev_private == NULL) {
> - DPAA_SEC_ERR("%s() Cannot allocate memzone for private device data",
> + DPAA2_SEC_ERR("%s() Cannot allocate memzone for private device data",
> __func__);
> return -ENOMEM;
You mixed dpaa2 with bonding in this set.
next prev parent reply other threads:[~2018-04-24 22:51 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 22:16 [dpdk-dev] [PATCH v7 00/11] eal: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver Arnon Warshavsky
2018-04-26 16:05 ` Kevin Traynor
2018-04-26 16:16 ` Kevin Traynor
2018-04-26 21:28 ` Arnon Warshavsky
2018-04-27 10:08 ` Kevin Traynor
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 02/11] bond: replace rte_panic instances in bonding driver Arnon Warshavsky
2018-04-24 22:51 ` Stephen Hemminger [this message]
2018-04-25 9:38 ` Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 03/11] e1000: replace rte_panic instances in e1000 driver Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 04/11] ixgbe: replace rte_panic instances in ixgbe driver Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 05/11] eal: replace rte_panic instances in eventdev Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 06/11] kni: replace rte_panic instances in kni Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 07/11] eal: replace rte_panic instances in hugepage_info Arnon Warshavsky
2018-04-25 8:58 ` Burakov, Anatoly
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread Arnon Warshavsky
2018-04-25 9:14 ` Burakov, Anatoly
2018-04-25 9:37 ` Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 09/11] eal: replace rte_panic instances in ethdev Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 10/11] eal: replace rte_panic instances in init sequence Arnon Warshavsky
2018-04-25 9:07 ` Burakov, Anatoly
2018-04-25 9:33 ` Arnon Warshavsky
2018-04-24 22:16 ` [dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit Arnon Warshavsky
2018-04-24 22:52 ` Stephen Hemminger
2018-04-24 23:03 ` Thomas Monjalon
2018-04-24 23:15 ` Stephen Hemminger
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 00/10] eal: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 01/10] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver Arnon Warshavsky
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 02/10] bond: replace rte_panic instances in bonding driver Arnon Warshavsky
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 03/10] e1000: replace rte_panic instances in e1000 driver Arnon Warshavsky
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 04/10] ixgbe: replace rte_panic instances in ixgbe driver Arnon Warshavsky
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 05/10] eal: replace rte_panic instances in eventdev Arnon Warshavsky
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 06/10] kni: replace rte_panic instances in kni Arnon Warshavsky
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 07/10] eal: replace rte_panic instances in hugepage_info Arnon Warshavsky
2018-04-25 13:50 ` Burakov, Anatoly
2018-04-25 14:02 ` Arnon Warshavsky
2018-04-25 14:14 ` Burakov, Anatoly
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 08/10] eal: replace rte_panic instances in ethdev Arnon Warshavsky
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 09/10] eal: replace rte_panic instances in init sequence Arnon Warshavsky
2018-04-25 13:53 ` Burakov, Anatoly
2018-04-25 13:45 ` [dpdk-dev] [PATCH v8 10/10] devtools: prevent new instances of rte_panic and rte_exit Arnon Warshavsky
2018-04-26 6:20 ` [dpdk-dev] [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
2018-04-26 6:20 ` [dpdk-dev] [PATCH v9 01/10] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver Arnon Warshavsky
2018-04-26 6:20 ` [dpdk-dev] [PATCH v9 02/10] bond: replace rte_panic instances in bonding driver Arnon Warshavsky
2018-04-26 16:06 ` Kevin Traynor
2018-04-26 21:06 ` Arnon Warshavsky
2018-04-26 21:26 ` Thomas Monjalon
2018-04-26 6:20 ` [dpdk-dev] [PATCH v9 03/10] e1000: replace rte_panic instances in e1000 driver Arnon Warshavsky
2018-04-26 6:20 ` [dpdk-dev] [PATCH v9 04/10] ixgbe: replace rte_panic instances in ixgbe driver Arnon Warshavsky
2018-04-26 6:20 ` [dpdk-dev] [PATCH v9 05/10] eal: replace rte_panic instances in eventdev Arnon Warshavsky
2018-04-26 6:21 ` [dpdk-dev] [PATCH v9 06/10] kni: replace rte_panic instances in kni Arnon Warshavsky
2018-04-26 6:21 ` [dpdk-dev] [PATCH v9 07/10] eal: replace rte_panic instances in hugepage_info Arnon Warshavsky
2018-04-26 6:21 ` [dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev Arnon Warshavsky
2018-04-26 16:07 ` Kevin Traynor
2018-04-26 21:38 ` Arnon Warshavsky
2018-04-26 6:21 ` [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence Arnon Warshavsky
2018-04-26 16:07 ` Kevin Traynor
2018-04-26 22:08 ` Arnon Warshavsky
2018-04-26 22:27 ` Arnon Warshavsky
2018-04-27 9:56 ` Kevin Traynor
2018-04-26 6:21 ` [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit Arnon Warshavsky
2018-04-26 16:08 ` Kevin Traynor
2018-04-26 21:57 ` Arnon Warshavsky
2018-04-27 10:02 ` Kevin Traynor
2018-04-29 6:23 ` Arnon Warshavsky
2018-04-30 6:45 ` [dpdk-dev] [PATCH v10] devtools: alert on " Arnon Warshavsky
2018-05-04 16:42 ` Kevin Traynor
2018-05-27 19:47 ` Thomas Monjalon
2018-05-27 20:34 ` Arnon Warshavsky
2018-07-15 23:15 ` Thomas Monjalon
2018-07-16 11:37 ` [dpdk-dev] [PATCH v11] " Arnon Warshavsky
2018-07-16 12:44 ` [dpdk-dev] [PATCH v12] " Arnon Warshavsky
2018-07-26 20:29 ` Thomas Monjalon
2018-07-26 20:57 ` Arnon Warshavsky
2018-07-26 21:00 ` Thomas Monjalon
2018-07-26 21:42 ` Arnon Warshavsky
2018-07-26 21:56 ` Thomas Monjalon
2018-07-26 22:00 ` Arnon Warshavsky
2018-07-26 22:10 ` [dpdk-dev] [PATCH v13] " Arnon Warshavsky
2018-07-31 12:11 ` Thomas Monjalon
2018-07-31 12:32 ` Arnon Warshavsky
2018-07-31 12:38 ` Thomas Monjalon
2018-09-10 6:06 ` David Marchand
2018-09-10 6:17 ` Arnon Warshavsky
2018-09-10 6:24 ` David Marchand
2018-04-27 14:22 ` [dpdk-dev] [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances Thomas Monjalon
2018-04-27 16:31 ` Arnon Warshavsky
2018-04-27 16:40 ` Thomas Monjalon
2018-04-27 17:16 ` Arnon Warshavsky
2018-04-27 14:30 ` Thomas Monjalon
2018-04-25 15:59 ` [dpdk-dev] [PATCH v8 " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424155146.35f5031f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=arnon@qwilt.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).