From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 89D5A4C6F for ; Wed, 25 Apr 2018 01:15:50 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id f15so13530324pfn.0 for ; Tue, 24 Apr 2018 16:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=veImckOcPVx7QNxpbOp9WIfxdMzWqE8wwLwVWv3yYGY=; b=wPYq4bmlIfOVmAyMgMw0crjTc2/Bruefs06xeHB0dYZ+ogiW0+S/3M2a3fEcFpQLps /3iEfBe6lGBz3nMSYdiHZ6dLqhRDYh2e0Fufrol7n+0v1/kTIkUaDyhNlE1Rty9UVkqc 9FucALp1+HNljO8uaRSpinqYsyVAfF2maitPkJ2iw0OcjGJ5u4B/7exzhIi41FXwzqcq mwP5Kw/5v/UNjet8d7rx84SGjaSnErL2I0lV1W5pAhsLnEPsgBFD8TtpUfQyVus+9hrr W93Bq3PqYszK21nk03CSYtU42JcOj7WgaxFruPeFTU9Er6lQm9zdGcf74Av4ZnR1KAzM b67g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=veImckOcPVx7QNxpbOp9WIfxdMzWqE8wwLwVWv3yYGY=; b=DEAaAimzy3NJoWp2I3qm8MKi7BjR+5hX24ZiJw7jjOADU+Vx+IahVI52RIrW+IMXjg B+QBm5CZt/6A1wijKmAJ0aMrJYtSULw0zwIZrPQHORrO2dtaPmvZSU/EP8GFKoWGfLkM RhPOphDWDcsxJiRdZ3uOIklEQLIo8IGj5xahtZBAKe8fzgV1NDLTMtSrMOjhsvptblVL yhG75Yc8SWc2PnMWogMfJi3QB2qMRE+GQ9tTqBGI0b+lm/rQOhsesrJw1MqlsP45KVp4 vMVYdPP8rlnOADMdhNcUoNFguwWJtFnpun5uE4mSQDM7v0L6lvhgjUd+V563F48q6j4S NjTQ== X-Gm-Message-State: ALQs6tDIVagMw5teXlWJY7aj1aPpTMPom/DarFkXEQafKymyP0Hx272v qy/s8QIXw6PhphgSIlm3USjgJU819WY= X-Google-Smtp-Source: AIpwx486TQ3pSPdhIpWh7jVm0egs1W4UjvwbU+xfhXYzThnSKx/S/y+uK/zuXDahnjuXXHYlJIyh9A== X-Received: by 2002:a17:902:a8:: with SMTP id a37-v6mr24614120pla.238.1524611748812; Tue, 24 Apr 2018 16:15:48 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id v85sm25409493pgb.71.2018.04.24.16.15.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 16:15:48 -0700 (PDT) Date: Tue, 24 Apr 2018 16:15:46 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Arnon Warshavsky , anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180424161546.43bc1ebe@xeon-e3> In-Reply-To: <3515084.lgnKaFBshB@xps> References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-12-git-send-email-arnon@qwilt.com> <20180424155253.7a11479f@xeon-e3> <3515084.lgnKaFBshB@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 23:15:50 -0000 On Wed, 25 Apr 2018 01:03:20 +0200 Thomas Monjalon wrote: > 25/04/2018 00:52, Stephen Hemminger: > > On Wed, 25 Apr 2018 01:16:53 +0300 > > Arnon Warshavsky wrote: > > > > > This patch adds a new function that is called > > > per every checked patch, > > > and alerts for new instances of rte_panic/rte_exit. > > > The check excludes comments, and alerts in the case > > > of a positive balance between additions and removals. > > > > > > Signed-off-by: Arnon Warshavsky > > > > Why not just mark the functions as deprecated with compiler attribute. > > No, the applications can use these functions. Yeah, fighting against that would be hard. They always seemed like internal functions.