From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 090FB2583 for ; Wed, 25 Apr 2018 10:21:39 +0200 (CEST) Received: from lfbn-lil-1-700-92.w81-254.abo.wanadoo.fr ([81.254.37.92] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fBFgK-0007Wr-LR; Wed, 25 Apr 2018 10:21:42 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Wed, 25 Apr 2018 10:21:32 +0200 Date: Wed, 25 Apr 2018 10:21:32 +0200 From: Olivier Matz To: Yongseok Koh Cc: Thomas Monjalon , Andrew Rybchenko , wenzhuo.lu@intel.com, jingjing.wu@intel.com, dev@dpdk.org, konstantin.ananyev@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Message-ID: <20180425082132.qxctg3umpfggicg3@neon> References: <20180310012532.15809-1-yskoh@mellanox.com> <20180424191538.exjgzoif4odhndew@neon> <1963503.R6hUdDjUTB@xps> <20180424215340.GA88208@yongseok-MBP.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180424215340.GA88208@yongseok-MBP.local> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 08:21:39 -0000 On Tue, Apr 24, 2018 at 02:53:41PM -0700, Yongseok Koh wrote: > On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote: > > 24/04/2018 21:15, Olivier Matz: > > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > > > > > On 04/24/2018 04:38 AM, Yongseok Koh wrote: > > > > > > > + * Returns TRUE if given mbuf is cloned by mbuf indirection, or FALSE > > > > > > > + * otherwise. > > > > > > > + * > > > > > > > + * If a mbuf has its data in another mbuf and references it by mbuf > > > > > > > + * indirection, this mbuf can be defined as a cloned mbuf. > > > > > > > + */ > > > > > > > +#define RTE_MBUF_CLONED(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > > > > > + > > > > > > > +/** > > > > > > > * Returns TRUE if given mbuf is indirect, or FALSE otherwise. > > > > > > > */ > > > > > > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > > > > > +#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > > > > > > It is still confusing that INDIRECT != !DIRECT. > > > > > > May be we have no good options right now, but I'd suggest to at least > > > > > > deprecate > > > > > > RTE_MBUF_INDIRECT() and completely remove it in the next release. > > > > > Agree. I may have missed something, but is my previous suggestion > > > > > not doable? > > > > > > > > > > - direct = embeds its own data (and indirect = !direct) > > > > > - clone (or another name) = data is another mbuf > > > > > - extbuf = data is in an external buffer > > > > > > > > I guess the problem that it changes INDIRECT semantics since EXTBUF > > > > is added as well. I think strictly speaking it is an API change. > > > > Is it OK to make it without announcement? > > > > > > In any case, there will be an ABI change, because an application > > > compiled for 18.02 will not be able to handle these new kind of > > > mbuf. > > > > > > So unfortunatly yes, I think this kind of changes should first be > > > announced. > > > > > > Thomas, what do you think? > > > > What is the impact for the application developer? > > Is there something to change in the application after this patch? > > Let me address two concerns discussed here. > > 1) API breakage of RTE_MBUF_DIRECT() > Previously, direct == !indirect but now direct == !indirect && !extbuf. But to > set the new flag (EXT_ATTACHED_MBUF), the new API, rte_pktmbuf_attach_extbuf() > should be used and it is experimental. If application isn't compiled without > allowing experimental API or application doesn't use the new API, it is always > true that direct == !indirect. It looks logically okay to me. And FYI, it passed > the mbuf_autotest. > > 2) ABI breakage of mlx5's new Multi-Packet RQ (a.k.a MPRQ) feature > It's right that it could breadk ABI if the PMD delivers packets with external > buffer attached. But, the MPRQ feature is disabled by default and it can be > enabled only by the newly introduced PMD parameter (mprq_en). So, there's no > possibility that 18.02-based application receives a mbuf having an external > buffer. And, like Olivier mentioned, there's another ABI breakage by removing > control mbuf anyway. Stricly speaking, it is possible that a user pass this parameter through the application (which just forwards it) to the new dpdk. So there is an ABI change. In short, if a user wants to enable an optimization of 18.05 on an application compiled for 18.02, it will fail. But I agree the impact is very limited. We are a bit lucky, because: - the mbuf size is aligned to 128, so it stays the same, and the priv area is after the 2nd cache line (note: we are at 112 bytes over 128 on x86_64). - previously, the area where shinfo is added was filled with garbage. It has no impact because it is only accessed when the EXT flag is set. - the unused flags are 0 by default. Knowing there is an ABI breakage this release, it could also make sense to try to limitate them and avoid breaking it again in 18.08. So in my opinion, reagarding API/ABI, this patchset could go in for 18.05. Olivier > > So, I don't think there's need for developers to change their application after > this patch unless they want to use the new feature. > > > Thanks, > Yongseok