From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id D0EF21B19 for ; Wed, 25 Apr 2018 10:43:08 +0200 (CEST) Received: from lfbn-lil-1-700-92.w81-254.abo.wanadoo.fr ([81.254.37.92] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fBG1C-0007aF-5b; Wed, 25 Apr 2018 10:43:15 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Wed, 25 Apr 2018 10:43:06 +0200 Date: Wed, 25 Apr 2018 10:43:06 +0200 From: Olivier Matz To: Thomas Monjalon Cc: dev@dpdk.org, Andrew Rybchenko Message-ID: <20180425084306.ci4cikbn4uv56kxd@neon> References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> <1523885610-20014-1-git-send-email-arybchenko@solarflare.com> <3270124.pgnYCBJxfz@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3270124.pgnYCBJxfz@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 0/6] mempool: add bucket driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 08:43:09 -0000 Hi, On Wed, Apr 25, 2018 at 01:00:23AM +0200, Thomas Monjalon wrote: > Can we have this patchset in 18.05-rc1? > Or is it candidate to rc2? I realized I made my comments on v1 instead of v2, sorry. https://dpdk.org/dev/patchwork/patch/36538/ https://dpdk.org/dev/patchwork/patch/36535/ https://dpdk.org/dev/patchwork/patch/36533/ All of them are minor issues, they could be adressed for rc2. Will send acks for generic mempool part. Olivier > > 16/04/2018 15:33, Andrew Rybchenko: > > The patch series adds bucket mempool driver which allows to allocate > > (both physically and virtually) contiguous blocks of objects and adds > > mempool API to do it. It is still capable to provide separate objects, > > but it is definitely more heavy-weight than ring/stack drivers. > > The driver will be used by the future Solarflare driver enhancements > > which allow to utilize physical contiguous blocks in the NIC firmware. > > > > The target usecase is dequeue in blocks and enqueue separate objects > > back (which are collected in buckets to be dequeued). So, the memory > > pool with bucket driver is created by an application and provided to > > networking PMD receive queue. The choice of bucket driver is done using > > rte_eth_dev_pool_ops_supported(). A PMD that relies upon contiguous > > block allocation should report the bucket driver as the only supported > > and preferred one. > [...] > > Andrew Rybchenko (1): > > doc: advertise bucket mempool driver > > > > Artem V. Andreev (5): > > mempool/bucket: implement bucket mempool manager > > mempool: implement abstract mempool info API > > mempool: support block dequeue operation > > mempool/bucket: implement block dequeue operation > > mempool/bucket: do not allow one lcore to grab all buckets