From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E7A706CC7 for ; Wed, 25 Apr 2018 15:03:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 766A520C59; Wed, 25 Apr 2018 09:03:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 25 Apr 2018 09:03:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=mesmtp; bh=TjFcxMzSOY/H7m4rrAFFuTOtmfMO7qX15vxYRJ 1FP/Q=; b=o8RijNk83AsmqcILvc05AIvlmfCV/o4dTn9RpRkJW/mclOb7rMMFX2 aNrTpW9oZ386LJcLVo6/W8KxTjyz1KGVov4LiIIWaKVBoEQ6mVEGGaPwk2t0fqaJ 83Xs7dpOm9s8CTRTu6x1M/fizN0Pof+dfbFOeTOJbuM95XismV4L4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TjFcxMzSOY/H7m4rr AFFuTOtmfMO7qX15vxYRJ1FP/Q=; b=G8uXHn5OmT/romovTssykwaszoCHZ4Vr+ XZu57W+7NmECUmjhl2FrA3hcNGTCdO/oA3RgsYx7G35efoh1ZS5tTV7CvvfVSb5b b5B3c8RkzsrRN0lkdvEiDQWwH9CYFl6xBjQg5tU1oqZQti8Fw/PP0lUccZexm9Mp oSDUodCqmneDK7TQmdmvXH+p4fKYNpULBRc9sOiWe+aFT2mXCKiUaQfjKkl3hIi9 PNICOmQpBgnQL0b9hNuHjrYzLNRmJ76SJXWVbxkTXk2qcUKYxqLO6Ko0rDWkvGel gFuOc8zkRTOymnrbd7Bbt9Aeer/ymNXJAWqw29NFIhx3dhzUyeHxg== X-ME-Sender: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 815C4E4ED0; Wed, 25 Apr 2018 09:03:53 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: anatoly.burakov@intel.com, reshma.pattan@intel.com, jianfeng.tan@intel.com Date: Wed, 25 Apr 2018 15:03:39 +0200 Message-Id: <20180425130339.4021-1-thomas@monjalon.net> X-Mailer: git-send-email 2.16.2 Subject: [dpdk-dev] [PATCH] app/pdump: remove unused socket path options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 13:03:55 -0000 The options --server-socket-path and --client-socket-path were said to be deprecated and will be removed soon. No need to wait for removing application options which have no effect, and can confuse the user. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Cc: jianfeng.tan@intel.com Signed-off-by: Thomas Monjalon --- app/pdump/main.c | 29 +---------------------------- 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index aa0f3a34d..6bcf8c498 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -37,8 +37,6 @@ #define PDUMP_RING_SIZE_ARG "ring-size" #define PDUMP_MSIZE_ARG "mbuf-size" #define PDUMP_NUM_MBUFS_ARG "total-num-mbufs" -#define CMD_LINE_OPT_SER_SOCK_PATH "server-socket-path" -#define CMD_LINE_OPT_CLI_SOCK_PATH "client-socket-path" #define VDEV_PCAP "net_pcap_%s_%d,tx_pcap=%s" #define VDEV_IFACE "net_pcap_%s_%d,tx_iface=%s" @@ -140,8 +138,6 @@ struct parse_val { int num_tuples; static struct rte_eth_conf port_conf_default; volatile uint8_t quit_signal; -static char server_socket_path[PATH_MAX]; -static char client_socket_path[PATH_MAX]; /**< display usage */ static void @@ -154,13 +150,7 @@ pdump_usage(const char *prgname) " tx-dev=," "[ring-size=default:16384]," "[mbuf-size=default:2176]," - "[total-num-mbufs=default:65535]'\n" - "[--server-socket-path=" - " which is deprecated and will be removed soon," - " default:/var/run/.dpdk/ (or) ~/.dpdk/]\n" - "[--client-socket-path=" - " which is deprecated and will be removed soon," - " default:/var/run/.dpdk/ (or) ~/.dpdk/]\n", + "[total-num-mbufs=default:65535]'\n", prgname); } @@ -385,8 +375,6 @@ launch_args_parse(int argc, char **argv, char *prgname) int option_index; static struct option long_option[] = { {"pdump", 1, 0, 0}, - {"server-socket-path", 1, 0, 0}, - {"client-socket-path", 1, 0, 0}, {NULL, 0, 0, 0} }; @@ -407,21 +395,6 @@ launch_args_parse(int argc, char **argv, char *prgname) return -1; } } - - if (!strncmp(long_option[option_index].name, - CMD_LINE_OPT_SER_SOCK_PATH, - sizeof(CMD_LINE_OPT_SER_SOCK_PATH))) { - strlcpy(server_socket_path, optarg, - sizeof(server_socket_path)); - } - - if (!strncmp(long_option[option_index].name, - CMD_LINE_OPT_CLI_SOCK_PATH, - sizeof(CMD_LINE_OPT_CLI_SOCK_PATH))) { - strlcpy(client_socket_path, optarg, - sizeof(client_socket_path)); - } - break; default: pdump_usage(prgname); -- 2.16.2