DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] dpaa2: do not log messages if bus not present
@ 2018-04-25 23:16 Stephen Hemminger
  2018-04-26 15:48 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2018-04-25 23:16 UTC (permalink / raw)
  To: hemant.agrawal, shreyansh.jain; +Cc: dev, Stephen Hemminger

A typical distribution will compile with default config and all
buses enabled. Therefore every driver should be silent and not
log anything for this normal case.

This patch gets rid of these messages when running on basic x86
environment such as bare metal or VM.

fslmc: DPAA2: DPRC not available
fslmc: FSLMC Bus Not Available. Skipping

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v2 - typo in previous patch

 drivers/bus/fslmc/fslmc_bus.c  | 2 +-
 drivers/bus/fslmc/fslmc_vfio.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index d0b32611fe08..943c01b2874d 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -255,7 +255,7 @@ rte_fslmc_scan(void)
 	/* Remove all devices in the list */
 	cleanup_fslmc_device_list();
 scan_fail:
-	DPAA2_BUS_INFO("FSLMC Bus Not Available. Skipping");
+	DPAA2_BUS_DEBUG("FSLMC Bus Not Available. Skipping");
 	/* Irrespective of failure, scan only return success */
 	return 0;
 }
diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index 675d160ba3a8..749d92dc3fc9 100644
--- a/drivers/bus/fslmc/fslmc_vfio.c
+++ b/drivers/bus/fslmc/fslmc_vfio.c
@@ -74,7 +74,7 @@ fslmc_get_container_group(int *groupid)
 	if (!g_container) {
 		container = getenv("DPRC");
 		if (container == NULL) {
-			DPAA2_BUS_INFO("DPAA2: DPRC not available");
+			DPAA2_BUS_DEBUG("DPAA2: DPRC not available");
 			return -EINVAL;
 		}
 
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v2] dpaa2: do not log messages if bus not present
  2018-04-25 23:16 [dpdk-dev] [PATCH v2] dpaa2: do not log messages if bus not present Stephen Hemminger
@ 2018-04-26 15:48 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-04-26 15:48 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, hemant.agrawal, shreyansh.jain

26/04/2018 01:16, Stephen Hemminger:
> A typical distribution will compile with default config and all
> buses enabled. Therefore every driver should be silent and not
> log anything for this normal case.
> 
> This patch gets rid of these messages when running on basic x86
> environment such as bare metal or VM.
> 
> fslmc: DPAA2: DPRC not available
> fslmc: FSLMC Bus Not Available. Skipping
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-26 15:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-25 23:16 [dpdk-dev] [PATCH v2] dpaa2: do not log messages if bus not present Stephen Hemminger
2018-04-26 15:48 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).