From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id B36168BA7 for ; Thu, 26 Apr 2018 17:38:45 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id f15so18703013pfn.0 for ; Thu, 26 Apr 2018 08:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wZvATC90IWWGwDbYlwsUiERlEZKDDVOXUgheunslQZw=; b=gOPzZvH7OFh48stIGR4d9nrklYiE+jUUmXtpHdPr6K4X7tJokRBMHYLcBxsrZ4lnh0 2zRUi1Ssj844sg8wRhq6xKuFFHNSPqZU7rzhOaluG2wjSDnO0DXUwZGQghKHCwIDxxY1 dzZVtX1SMB1Fgc+gjRxMgRWAOwinI3AuRc/G4voYI4Y/pEA9Q0GeqQnf+GLgZCxUsJeX z39NZBqzGGGt4eq6PWzPZ6NhN2gH8cJrUyp8gQ5ZLcCl5C0X5flnfWaZ67pKJx2z/v7R hBooKEif1aJe+/RTmwToWdJewKF70C4Klh3gKJh72PWOy5YMH4r2uqWIXh0a5yUA5Qq3 QtsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wZvATC90IWWGwDbYlwsUiERlEZKDDVOXUgheunslQZw=; b=JGdZ3pSghAiFkMb7sRKGk4EWwNkyN7gOh7cQcL2KJEx/eP96wjIcLu6VBMTitabDm3 QiIWaECe5Wef3Yvq9ycDv+ecu5L74PXcWHJGFMsjEJOR6ybZn4fQQXRynz2FpmOP7XY+ X3zjHAfchSAEQ0Y/n7HDQTroGSVmtBbCJFeUa/GlEa77efxz/AeyXmUR16zfB6VjBa0l 4Z+9x9Y+rRYYsk9yTOWSdcHhvGHP/d3MQz6AspnOe5vPWS0kWT2yjnxyyWddVtcBtFeW KGHfGwkipRMyte6EFVcW+hCSgcYO1yufXvQZ7OWbHbUMt1txnqmelojCB7eg6LM3dPhi uGWw== X-Gm-Message-State: ALQs6tDZVtdmmzPN3KFEi/JyfdRn3LRexLJCMGFxqYQg997UXZAnBOtv FkYc9MWexTjXu05KTS+AfCvuww== X-Google-Smtp-Source: AIpwx4/ueVOWBYRmZHuCPF50JuZiVTTQQ+QblKrc2cPoYT4Kwt3pB6rzRsuVoaljYazAOcdRHvB6zw== X-Received: by 10.98.153.15 with SMTP id d15mr17837801pfe.115.1524757124873; Thu, 26 Apr 2018 08:38:44 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id e190sm36867599pfe.171.2018.04.26.08.38.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 08:38:44 -0700 (PDT) Date: Thu, 26 Apr 2018 08:38:42 -0700 From: Stephen Hemminger To: Anatoly Burakov Cc: dev@dpdk.org, Neil Horman , John McNamara , Marko Kovacevic , Robert Sanford , thomas@monjalon.net, erik.g.carrillo@intel.com, olivier.matz@6wind.com Message-ID: <20180426083842.5fc6c83c@xeon-e3> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 15:38:46 -0000 On Thu, 26 Apr 2018 14:42:31 +0100 Anatoly Burakov wrote: > rte_lcore_has_role() returns 0 if role of lcore matches requested > role. The return value of the API is confusing, and this is a known > problem with a deprecation notice announcing the change to more > intuitive semantics: > > Commit 064518f68d48 ("doc: announce EAL API change to lcore role function") > Cc: erik.g.carrillo@intel.com > > Implement changes announced in the deprecation notice, and remove it. > Also, fix usages of this API to reflect the change. Control thread patches > expected new behavior and were broken before, now they are fixed as well. > > Fixes: d651ee4919cd ("eal: set affinity for control threads") > Cc: olivier.matz@6wind.com > > Signed-off-by: Anatoly Burakov It would make more sense if rte_lcore_has_role returned a bool