From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id C11C47EE3 for ; Fri, 27 Apr 2018 00:17:13 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id f189so10333161pfa.7 for ; Thu, 26 Apr 2018 15:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VmEBm2IIZpvyN8aKp1Zp01SJHRNROnSNPvv49YH/EgA=; b=o2oApT1ZH0JgCYS/jM3aUQQzg1ZbSqDcSmZOJGiAAOBmIOzl3ZBoeeK/+ZrG/XlSHJ jnaPbqD7NjnnrUFq6jM6qkspLJiAMiMPsRtljw3q6qOtRQGKOhH7v37x/LjeRDCq1GJG f9CV9KzTIjLaxlx7Eqf3HFu3OyxvWQUGkr6Rp17ytQq/r0WZ6MLzkBg0y2+zHblYl+yO wdM//vH6eeEK8YPbPTnZVxR1BF8t/gTtbanuWmKHAhntMaX+VlPky2x1dehD/TtlVbuS C+ZwQMAN3S+y8sahK5OyRH2iJC9FHtI/ExxHvO1jBGAmS4L8blaClLRw5ciVhKnq4WdT 2uWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VmEBm2IIZpvyN8aKp1Zp01SJHRNROnSNPvv49YH/EgA=; b=MfIGloR9olTOywUwBsY5K7sHxOX0RGFVSJy6qsdC+FJv4Hr78i7Ljq7I6sRgZzbrSr 5mWamDOO8osnrjk1o0VvKEqKQaCB8eMFiOSKZH6XgUi5C8dfQhvy+uobiEiLg8wgpPgt OYBvkgPrqTKmVJYs9k2Ht7ZncIOqir5U7P0g6KNJ+PYeOepenvTQbd/8qdNP57yn28vg 1ImKoqKoXBsx4Ug5NJOkTbUIN3fNe5ResgK9j9CxyXMa5/qpHu5W8V9Ox4VZ4J0uj1UJ adLWE9T23nEtaVxqxqQygeIKj9YyaBMw3Pqy6X36Dm86oBoHYkQYMVc2YI+5XCGuOLrn InmA== X-Gm-Message-State: ALQs6tBUCFw2GaFHV8CBl0tG9TazWlsynX5mcsxEpfGT7j5QZ3Xl/jfy 0GnXnzKwVsKdAwH1B+35nfOfcQ== X-Google-Smtp-Source: AIpwx48PeR+gsDNfeshZk09DHER1fD1Ar+iAzQhvni2K9EZMmOcY03g0PEAcAbl13uoSNo+QENHBAw== X-Received: by 10.99.173.73 with SMTP id y9mr29317286pgo.179.1524781032913; Thu, 26 Apr 2018 15:17:12 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id m11sm23727767pgv.48.2018.04.26.15.17.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 15:17:12 -0700 (PDT) Date: Thu, 26 Apr 2018 15:17:10 -0700 From: Stephen Hemminger To: Medvedkin Vladimir Cc: dev@dpdk.org, bruce.richardson@intel.com, thomas@monjalon.net, cristian.dumitrescu@intel.com Message-ID: <20180426151710.58b3028a@xeon-e3> In-Reply-To: <1524780214-23196-2-git-send-email-medvedkinv@gmail.com> References: <1524780214-23196-1-git-send-email-medvedkinv@gmail.com> <1524780214-23196-2-git-send-email-medvedkinv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/4] Add RIB library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 22:17:14 -0000 On Fri, 27 Apr 2018 01:03:31 +0300 Medvedkin Vladimir wrote: > +static inline int __attribute__((pure)) > +rte_rib_is_right_node(struct rte_rib_node *node) > +{ > + return (node->parent->right == node); > +} > + Minor nit (repeated in several places). DPDK uses Linux (not BSD) style where extra paranthesis are not needed on return statement.