From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 06D6E7D19 for ; Fri, 27 Apr 2018 17:18:35 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 08:18:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,335,1520924400"; d="scan'208";a="35130828" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga007.fm.intel.com with SMTP; 27 Apr 2018 08:18:32 -0700 Received: by (sSMTP sendmail emulation); Fri, 27 Apr 2018 16:18:31 +0100 Date: Fri, 27 Apr 2018 16:18:31 +0100 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180427151831.GD80648@bricha3-MOBL.ger.corp.intel.com> References: <4d15c97e68ce89c0915935c6c04099a9eb950232.1524650130.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d15c97e68ce89c0915935c6c04099a9eb950232.1524650130.git.anatoly.burakov@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 15:18:36 -0000 On Wed, Apr 25, 2018 at 10:56:42AM +0100, Anatoly Burakov wrote: > We close fd if we managed to find it in the list of allocated > segment lists (which should always be the case under normal > conditions), but if we didn't, the fd was leaking. Close it if > we couldn't find it in the segment list. This is not an issue > as if the segment is zero length, we're getting rid of it > anyway, so there's no harm in not storing the fd anywhere. > > Coverity issue: 272568 > This coverity issue indicates two resource leaks, while I think this patch only closes one of them. /Bruce > Fixes: 2a04139f66b4 ("eal: add single file segments option") > Cc: anatoly.burakov@intel.com > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/linuxapp/eal/eal_memalloc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > index 9156f8b..fab5a98 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c > +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > @@ -569,6 +569,8 @@ free_seg(struct rte_memseg *ms, struct hugepage_info *hi, > if (te != NULL && te->fd >= 0) { > close(te->fd); > te->fd = -1; > + } else { > + close(fd); > } > unlink(path); > } > -- > 2.7.4