From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 55EFE5F3B for ; Fri, 27 Apr 2018 17:37:28 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 08:37:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,335,1520924400"; d="scan'208";a="46546124" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga003.jf.intel.com with SMTP; 27 Apr 2018 08:37:25 -0700 Received: by (sSMTP sendmail emulation); Fri, 27 Apr 2018 16:37:24 +0100 Date: Fri, 27 Apr 2018 16:37:23 +0100 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180427153723.GG80648@bricha3-MOBL.ger.corp.intel.com> References: <09affd5fda528c74b7f09391de90fe6a7b7cfe5a.1524650130.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09affd5fda528c74b7f09391de90fe6a7b7cfe5a.1524650130.git.anatoly.burakov@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 7/9] mem: fix potential bad unmap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 15:37:28 -0000 On Wed, Apr 25, 2018 at 10:56:45AM +0100, Anatoly Burakov wrote: > Previously, if mmap failed to map page address at requested > address, we were attempting to unmap the wrong address. Fix it > by unmapping our actual mapped address, and jump further to > avoid unmapping memory that is not allocated. > > Coverity issue: 272602 > > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") > Cc: anatoly.burakov@intel.com > > Signed-off-by: Anatoly Burakov > --- Acked-by: Bruce Richardson