From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 0C15C7D19 for ; Fri, 27 Apr 2018 17:48:53 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 08:48:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,335,1520924400"; d="scan'208";a="41133938" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga002.fm.intel.com with SMTP; 27 Apr 2018 08:48:50 -0700 Received: by (sSMTP sendmail emulation); Fri, 27 Apr 2018 16:48:50 +0100 Date: Fri, 27 Apr 2018 16:48:49 +0100 From: Bruce Richardson To: "Burakov, Anatoly" Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180427154849.GA94056@bricha3-MOBL.ger.corp.intel.com> References: <4d15c97e68ce89c0915935c6c04099a9eb950232.1524650130.git.anatoly.burakov@intel.com> <20180427151831.GD80648@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 15:48:54 -0000 On Fri, Apr 27, 2018 at 04:39:34PM +0100, Burakov, Anatoly wrote: > On 27-Apr-18 4:18 PM, Bruce Richardson wrote: > > On Wed, Apr 25, 2018 at 10:56:42AM +0100, Anatoly Burakov wrote: > > > We close fd if we managed to find it in the list of allocated > > > segment lists (which should always be the case under normal > > > conditions), but if we didn't, the fd was leaking. Close it if > > > we couldn't find it in the segment list. This is not an issue > > > as if the segment is zero length, we're getting rid of it > > > anyway, so there's no harm in not storing the fd anywhere. > > > > > > Coverity issue: 272568 > > > > > > > This coverity issue indicates two resource leaks, while I think this patch > > only closes one of them. > > The other issue is actually a false positive. We couldn't have gotten the fd > if there wasn't a tailq entry for that fd, but if we don't resize and remove > the file, we want to keep the fd. So the "int fd" goes out of scope, but > actually it's stored in the tailq, and thus doesn't leak. > I'm not sure coverity is going to recognise that fact. However, given that this is a fix for one of the flagged problems: Acked-by: Bruce Richardson