From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 6E8D68D8F for ; Fri, 27 Apr 2018 21:31:45 +0200 (CEST) Received: from cpe-2606-a000-111b-40b7-640c-26a-4e16-9225.dyn6.twc.com ([2606:a000:111b:40b7:640c:26a:4e16:9225] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1fC95Y-0002c4-Kc; Fri, 27 Apr 2018 15:31:32 -0400 Date: Fri, 27 Apr 2018 15:30:52 -0400 From: Neil Horman To: Ferruh Yigit Cc: Hemant Agrawal , Shreyansh Jain , Pablo de Lara , Declan Doherty , Thomas Monjalon , Jerin Jacob , Olivier Matz , Cristian Dumitrescu , Maxime Coquelin , Jianfeng Tan , dev@dpdk.org Message-ID: <20180427193052.GD22078@hmswarspite.think-freely.org> References: <20180427151756.22028-1-ferruh.yigit@intel.com> <20180427154227.GB22078@hmswarspite.think-freely.org> <5f87cc42-4254-8898-e1ac-da5412fc93f7@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f87cc42-4254-8898-e1ac-da5412fc93f7@intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH] lib: clear experimental version tag in linker scripts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 19:31:45 -0000 On Fri, Apr 27, 2018 at 04:55:20PM +0100, Ferruh Yigit wrote: > On 4/27/2018 4:42 PM, Neil Horman wrote: > > On Fri, Apr 27, 2018 at 04:17:55PM +0100, Ferruh Yigit wrote: > >> Remove version tag from experimental block in linker version scripts > >> (.map files). > >> > >> That label is not used by linker and information only. It is useful > >> for version blocks but not useful for experimental block but confusing. > >> Removing those labels. > >> > >> Signed-off-by: Ferruh Yigit > >> --- > >> Cc: Neil Horman > >> Cc: Thomas Monjalon > >> --- > >> drivers/net/dpaa/rte_pmd_dpaa_version.map | 4 +--- > >> lib/librte_cryptodev/rte_cryptodev_version.map | 2 +- > >> lib/librte_eal/rte_eal_version.map | 2 +- > >> lib/librte_ethdev/rte_ethdev_version.map | 2 +- > >> lib/librte_eventdev/rte_eventdev_version.map | 2 +- > >> lib/librte_mbuf/rte_mbuf_version.map | 3 +-- > >> lib/librte_mempool/rte_mempool_version.map | 3 +-- > >> lib/librte_meter/rte_meter_version.map | 2 +- > >> lib/librte_net/rte_net_version.map | 2 +- > >> lib/librte_pipeline/rte_pipeline_version.map | 2 +- > >> lib/librte_vhost/rte_vhost_version.map | 2 +- > >> 11 files changed, 11 insertions(+), 15 deletions(-) > >> > >> diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map > >> index 3b937b10f..c7ad4030a 100644 > >> --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map > >> +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map > >> @@ -9,6 +9,4 @@ EXPERIMENTAL { > >> dpaa_eth_eventq_attach; > >> dpaa_eth_eventq_detach; > >> rte_pmd_dpaa_set_tx_loopback; > >> - > >> - local: *; > > Are you sure you meant to remove this local tag? > > Yes, it was a duplicate, above DPDK_17.11 one has it already. > copy that, thanks Acked-by: Neil Horman > > > > Everything else looks good > > > > Neil > > > >