From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3DEB123B for ; Mon, 30 Apr 2018 10:58:56 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Apr 2018 01:58:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,346,1520924400"; d="scan'208";a="37209355" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga007.jf.intel.com with SMTP; 30 Apr 2018 01:58:52 -0700 Received: by (sSMTP sendmail emulation); Mon, 30 Apr 2018 09:58:48 +0100 Date: Mon, 30 Apr 2018 09:58:47 +0100 From: Bruce Richardson To: =?utf-8?B?UmFmYcWC?= Kozik Cc: dev@dpdk.org, Marcin Wojtas , =?utf-8?Q?Micha=C5=82?= Krawczyk , "Tzalik, Guy" , evgenys@amazon.com, "Matushevsky, Alexander" , "Chauskin, Igor" , Ferruh Yigit Message-ID: <20180430085847.GA87372@bricha3-MOBL.ger.corp.intel.com> References: <1523455637-31719-1-git-send-email-rk@semihalf.com> <20180411144251.GA33124@bricha3-MOBL.ger.corp.intel.com> <20180427113030.GA101968@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 0/4] support for write combining X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 08:58:57 -0000 On Mon, Apr 30, 2018 at 10:07:07AM +0200, Rafał Kozik wrote: > Hello Bruce, > > It should work because decision about kind of mapping is made in patch > 3 based on PMD request. > > ENA use only one BAR in wc mode and two other without caching, > therefore not making remap in igb_uio rather not spoil anything. > > I added patch 1 because this variable is provided also outside the > DPDK to Linux generic functions. I cannot test it with all drivers, > therefore I make it configurable. > > But general combination of wc and not wc PMD should work, because of patch 3. > Also if WC is enabled by PMD (like in patch 4) not all BARs will by > mapped, but only those which has prefetchable flag enabled. > Sounds good, so in that case I've no objection to the patch. Acked-by: Bruce Richardson