From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CC9A223A for ; Mon, 30 Apr 2018 14:50:40 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Apr 2018 05:50:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,346,1520924400"; d="scan'208";a="51129432" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga001.fm.intel.com with SMTP; 30 Apr 2018 05:50:37 -0700 Received: by (sSMTP sendmail emulation); Mon, 30 Apr 2018 13:50:36 +0100 Date: Mon, 30 Apr 2018 13:50:36 +0100 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org Message-ID: <20180430125035.GB100464@bricha3-MOBL.ger.corp.intel.com> References: <73e35ca9ce462ab097c6ca8e7cbfdd5b8bc06c1d.1525086045.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73e35ca9ce462ab097c6ca8e7cbfdd5b8bc06c1d.1525086045.git.anatoly.burakov@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 2/2] mem: unmap unneeded space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 12:50:41 -0000 On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote: > When we ask to reserve virtual areas, we usually include > alignment in the mapping size, and that memory ends up > being wasted. Wasting a gigabyte of VA space while trying to > reserve one gigabyte is pretty expensive on 32-bit, so after > we're done mapping, unmap unneeded space. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v2: > - Split fix for size_t overflow into separate patch > - Improve readability of unmapping code > - Added comment explaining why unmapping is done > Acked-by: Bruce Richardson