DPDK patches and discussions
 help / color / mirror / Atom feed
From: Declan Doherty <declan.doherty@intel.com>
To: dev@dpdk.org
Cc: Declan Doherty <declan.doherty@intel.com>
Subject: [dpdk-dev] [PATCH 2/3] net/ixgbe: initialise nb_representor_ports value
Date: Mon, 30 Apr 2018 16:32:57 +0100	[thread overview]
Message-ID: <20180430153258.1101-2-declan.doherty@intel.com> (raw)
In-Reply-To: <20180430153258.1101-1-declan.doherty@intel.com>

Initialise rte_ethdev_args nb_representor_ports to zero to handle
the case where no devargs are passed to the IXGBE PF on
device probe, so that there is no invalid attempts to create
representor ports.

Coverity Issue: 277231
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")

Signed-off-by: Declan Doherty <declan.doherty@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 0ccf55dc8..283dd7e49 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1725,8 +1725,7 @@ eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 		struct rte_pci_device *pci_dev)
 {
 	char name[RTE_ETH_NAME_MAX_LEN];
-
-	struct rte_eth_devargs eth_da;
+	struct rte_eth_devargs eth_da = { .nb_representor_ports = 0 };
 	int i, retval;
 
 	if (pci_dev->device.devargs) {
-- 
2.14.3

  reply	other threads:[~2018-04-30 15:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 15:32 [dpdk-dev] [PATCH 1/3] net/ixgbe: revert default PF PMD device name Declan Doherty
2018-04-30 15:32 ` Declan Doherty [this message]
2018-05-01  9:46   ` [dpdk-dev] [PATCH 2/3] net/ixgbe: initialise nb_representor_ports value Ananyev, Konstantin
2018-05-01 12:53     ` Doherty, Declan
2018-04-30 15:32 ` [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev Declan Doherty
2018-05-01  9:47   ` Ananyev, Konstantin
2018-05-01 12:53     ` Doherty, Declan
2018-05-02 15:59 ` [dpdk-dev] [dpdk-dev 1/3][PATCH v2] net/ixgbe: revert default PF PMD device name Declan Doherty
2018-05-02 15:59   ` [dpdk-dev] [dpdk-dev 2/3][PATCH v2] net/ixgbe: default eth_da parameter Declan Doherty
2018-05-02 15:59   ` [dpdk-dev] [dpdk-dev 3/3][PATCH v2] net/ixgbe: add null pointer check for pf_ethdev Declan Doherty
2018-05-02 16:48   ` [dpdk-dev] [dpdk-dev 1/3][PATCH v2] net/ixgbe: revert default PF PMD device name Ferruh Yigit
2018-05-02 17:05     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180430153258.1101-2-declan.doherty@intel.com \
    --to=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).