From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id DDCC8DED for ; Tue, 1 May 2018 16:16:26 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2018 07:16:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,351,1520924400"; d="scan'208";a="50569073" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga004.fm.intel.com with SMTP; 01 May 2018 07:16:23 -0700 Received: by (sSMTP sendmail emulation); Tue, 01 May 2018 15:16:21 +0100 Date: Tue, 1 May 2018 15:16:20 +0100 From: Bruce Richardson To: Beilei Xing , Qi Zhang Cc: dev@dpdk.org, ferruh.yigit@intel.com, konstantin.ananyev@intel.com Message-ID: <20180501141620.GA47736@bricha3-MOBL.ger.corp.intel.com> References: <20180501130309.39444-1-bruce.richardson@intel.com> <20180501141354.13935-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180501141354.13935-1-bruce.richardson@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix Tx fn selection when using new ethdev offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 14:16:27 -0000 On Tue, May 01, 2018 at 03:13:54PM +0100, Bruce Richardson wrote: > The Tx function selection code in the driver only used the older txq > flags values to check whether the scalar or vector functions should be > used. This caused performance regressions with testpmd io-fwd as the > scalar path rather than the vector one was being used in the default > case. Fix this by changing the code to take account of new offloads and > deleting the defines used for the old ones. > > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > > Signed-off-by: Bruce Richardson > --- Apologies: forgot to add: v2: eliminate mask for offload flags, and use vector path only if offloads == 0