Re: [dpdk-dev] [v3, 3/5] eventdev: add crypto adapter implementation

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Sun, 6 May 2018 00:17:08 +0530
> From: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> To: jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
>  akhil.goyal@nxp.com, dev@dpdk.org
> CC: narender.vangati@intel.com, abhinandan.gujjar@intel.com,
>  nikhil.rao@intel.com, gage.eads@intel.com
> Subject: [v3,3/5] eventdev: add crypto adapter implementation
> X-Mailer: git-send-email 1.9.1
> 
> Event crypto adapter is added to the meson build system
> 
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---
>  config/common_base                             |    1 +
>  lib/Makefile                                   |    3 +-
>  lib/librte_eventdev/Makefile                   |    3 +
>  lib/librte_eventdev/meson.build                |    8 +-
>  lib/librte_eventdev/rte_event_crypto_adapter.c | 1127 ++++++++++++++++++++++++
>  lib/librte_eventdev/rte_eventdev_version.map   |   12 +
>  6 files changed, 1150 insertions(+), 4 deletions(-)
>  create mode 100644 lib/librte_eventdev/rte_event_crypto_adapter.c
> 
> diff --git a/config/common_base b/config/common_base
> index 03a8688..8420d29 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -577,6 +577,7 @@ CONFIG_RTE_LIBRTE_EVENTDEV_DEBUG=n
>  CONFIG_RTE_EVENT_MAX_DEVS=16
>  CONFIG_RTE_EVENT_MAX_QUEUES_PER_DEV=64
>  CONFIG_RTE_EVENT_TIMER_ADAPTER_NUM_MAX=32
> +CONFIG_RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE=32

add EVENT_CRYPTO_ADAPTER_MAX_INSTANCE=32 in config/rte_config.h,
otherwise meson build will fail. Check the meson build in next revision.

FAILED:
lib/rte_eventdev@sta/librte_eventdev_rte_event_crypto_adapter.c.o
ccache gcc  -Ilib/rte_eventdev@sta -Ilib -I../lib -Ilib/librte_eventdev
-I../lib/librte_eventdev -Iconfig -I../config -I. -I../
-Ilib/librte_eal/common/include/arch/x86
-I../lib/librte_eal/common/include/arch/x86
-Ilib/librte_eal/common/include -I../lib/librte_eal/common/include
-Ilib/librte_eal/common -I../lib/librte_eal/common
-Ilib/librte_eal/linuxapp/eal/../../../librte_compat
-I../lib/librte_eal/linuxapp/eal/../../../librte_compat
-I../lib/librte_eal/linuxapp/eal/include -Ilib/librte_eal
-I../lib/librte_eal -Ilib/librte_compat -I../lib/librte_compat
-Ilib/librte_ring -I../lib/librte_ring -Ilib/librte_ethdev
-I../lib/librte_ethdev -Ilib/librte_net -I../lib/librte_net
-Ilib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_mempool
-I../lib/librte_mempool -Ilib/librte_kvargs -I../lib/librte_kvargs
-Ilib/librte_hash -I../lib/librte_hash -Ilib/librte_timer
-I../lib/librte_timer -Ilib/librte_cryptodev -I../lib/librte_cryptodev
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall
-Winvalid-pch -O3 -include rte_config.h -Wsign-compare -Wcast-qual
-Wno-address-of-packed-member -Wno-format-truncation -fPIC -march=native
-DALLOW_EXPERIMENTAL_API -MD -MQ
'lib/rte_eventdev@sta/librte_eventdev_rte_event_crypto_adapter.c.o' -MF
'lib/rte_eventdev@sta/librte_eventdev_rte_event_crypto_adapter.c.o.d' -o
'lib/rte_eventdev@sta/librte_eventdev_rte_event_crypto_adapter.c.o' -c
../lib/librte_eventdev/rte_event_crypto_adapter.c
../lib/librte_eventdev/rte_event_crypto_adapter.c: In function
‘eca_valid_id’:
../lib/librte_eventdev/rte_event_crypto_adapter.c:113:14: error:
‘RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE’ undeclared (first use in this
function); did you mean ‘RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD’?
  return id < RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE;
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD
../lib/librte_eventdev/rte_event_crypto_adapter.c:113:14: note: each
undeclared identifier is reported only once for each function it appears
in
../lib/librte_eventdev/rte_event_crypto_adapter.c: In function
‘eca_init’:
../lib/librte_eventdev/rte_event_crypto_adapter.c:124:6: error:
‘RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE’ undeclared (first use in this
function); did you mean ‘RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD’?
      RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE;
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD
../lib/librte_eventdev/rte_event_crypto_adapter.c: In function
‘eca_valid_id’:
../lib/librte_eventdev/rte_event_crypto_adapter.c:114:1: warning:
control reaches end of non-void function [-Wreturn-type]
 }
 ^