From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0085.outbound.protection.outlook.com [104.47.36.85]) by dpdk.org (Postfix) with ESMTP id 63E722BE1 for ; Mon, 7 May 2018 11:35:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Z10J8AtouwuYpMbKRzE8TulUmSOasDkiYZkFWMv1VXk=; b=Kn2W6cZqIhmONK6C4DO4VURic5QAVbcTtnIS5qDGXP4R2BQkcsFf1PGxddzFcJP9CZ7oa6K9UxoIJDAeSbdVPl6/O4XXfxFCkrVU5zHwSnegH7+bvbcIXD0xmkrA8wBiYmUrJNZI9FFsoG1TaPvS8S8ymuPs2qw9bTMBu/rKHEI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Mon, 7 May 2018 09:35:33 +0000 Date: Mon, 7 May 2018 15:05:18 +0530 From: Jerin Jacob To: Abhinandan Gujjar Cc: hemant.agrawal@nxp.com, akhil.goyal@nxp.com, dev@dpdk.org, narender.vangati@intel.com, nikhil.rao@intel.com, gage.eads@intel.com Message-ID: <20180507093516.GA8052@jerin> References: <1525546030-11204-1-git-send-email-abhinandan.gujjar@intel.com> <1525546030-11204-2-git-send-email-abhinandan.gujjar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1525546030-11204-2-git-send-email-abhinandan.gujjar@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: PN1PR0101CA0021.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::31) To SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN2PR07MB2527; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 3:dgK0qWYCqwY3Xwb6jOrYut9wlyj/VJ4wQjhILuaX/kBNqBUAkixgtYrr5UCiCEU0I8/ExRk91t+HNZOCYqkVskT4OGfWRxQhAs/606HkFc4GpgpMYuQSrb9qrVd2Yqn50wuOnpCPlHwtQ5dy1bE+UTnhg3QakC9n0V0kWvUahrFV8P7TnTYDch9wAzsg5Nfmt2oBnDbvzVkfTo55sQSKfBK/7FvGHRt0dFHgNar6tuuQcXMl1oyj9NwlvEGM2nwF; 25:/R4tCSYXk3oRnmMtpkYmSjNm60brhpyKr0aWK7voFjMns1y3X716jJ21bTyfp5TwMPz6PCJYAhH4zJp6S1akK1asV6dpDGvEwFKPel8QDzrkw7lle6wDTGLKBpyxNjfd9XrbjVag6sZFNRWnWVvGeLPrFg1Gz998+ihT0huuF6KZ1TnkJGETh4lUoL1VZoPv9/BkxBbXq68nbbXomfze9ipCG5DY6Xq1+lz8GZw11Agf9YpzzEEjO5SNCKOMYlK1etNSxASivTjbehrmw+b0ZowGfpnV4pcqP3/4oQcnhAxc2JN4H/trdkgZsPU4CHesdhtmQPKOZG2CxA3gPvU/fQ==; 31:yOo2q0WIxLIP5yM7/22s13Jl953yVRVEIxZuXCnvHX+trsiYUhK+yp34qauj7jyqW0JCrDwgVJ1PY9kKkdbM/VSSTfht5I1VEzVOkYliuPCkFfdQ2Xw58hYzgicyJVhuG/BkuZmZe6rO6l3f6agL/DrhTk60FtJLs4Ugy1cPstJg5ysqs5eVv6vsI9UbHkPr3ygMnwKZzoQkKY8iV/hmTr2M/YujbUYpLPVBzCfcvnc= X-MS-TrafficTypeDiagnostic: SN2PR07MB2527: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 20:+0zBgMrtk+K3ddyrato9dN77MuyKhcyZKVuC5E2hEF1BKGhbgg+vx7zdbfnGQJEcv9PXWmLb3j4hs7/55cxJqqeJIoe3S98JJ3o3sPPy29lwlbPSY8qQ3Zw44Zgkrk6DaOOGGvGhujsht2UD4tN9iLd7CpgP+Hz3V4rhBdsENGsBupFLN5G/HDTkvBtJHIXqx0HyQT1iOillR0dBg44m+9PsTJg96E9nN/ODZYzrf70tqGU2tl+0tOc/sWiVQ9xWqfbw/6rUeP0Z1nxSWatbBQLF/pHpYD7pOxcopX6wXEbDmYCvTDaJDAE8wKKdaGnEClIuwxyDZxrXJ0mk/ptklS/tF+KBa656+XWQ9zbtb2u6YXC7sXWRcKQgZI/+6iSXirXBgugrG+IAa4n41FTUXN59oO8UM3Ia4kp+JWswys+f9yN4Ixc1DduMqojFfG/lh+hQjnagogiKioDsHarbCO8hhJ+kO3wMwvYSIOK6gHop5uvbRrWc3Grz5NfogqvaMdsbrSRFjhA7RbVLKxrlHl8As5m9cAAY9VLRbGV0IJbS2nNISN+UhetUQcAhCH4mHeRXSkU21Wb0ScMnDKx2gBerI+XjmLNFa4Rd8rYAgmE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3231254)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:SN2PR07MB2527; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2527; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 4:dPcFQ2wP6A+j9Ek+tsLQGkpBBLWT6Z+D4iO9ENvgjECNd5quE9IfQMnQ8FCe8e+4bjBCpR92yYar4NkEvvc7IDfukTGxEma/E9bTjuzBYiyOU0gEaDaXwzrTg42hyBxLvr3Y3Ntnbl5JnZ58+KfXV4MBqBGBkeVJGE+lswrywE55E/G5Zya3pv7PCM/tJieXu8vEynkSTDCctbO7CHN/wN52zYaFao0Ey3AgL9y0c31SPAeT+BHvcD14216z7I1UxznNMBF9MiEl3FePcMkfBnaH4cT8QBRNutZpH/u1SpQWgXSzgb7jrC2rb0sWu0KpaXzH7sOMiuWWE1L07xQYztu8+8VbKCsCwEEVNyCjj74= X-Forefront-PRVS: 066517B35B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(39850400004)(366004)(346002)(396003)(13464003)(199004)(189003)(97736004)(66066001)(5660300001)(486006)(42882007)(446003)(33716001)(11346002)(316002)(58126008)(68736007)(33656002)(44832011)(476003)(956004)(16526019)(186003)(6306002)(55016002)(53936002)(4326008)(9686003)(305945005)(7736002)(2870700001)(81166006)(81156014)(2906002)(8676002)(8936002)(6496006)(23676004)(52146003)(33896004)(2486003)(76176011)(386003)(59450400001)(55236004)(26005)(106356001)(105586002)(52116002)(229853002)(478600001)(6116002)(1076002)(3846002)(72206003)(966005)(6246003)(50466002)(8656006)(47776003)(6916009)(6666003)(25786009)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2527; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjA3TUIyNTI3OzIzOmhZWVkvajVmNi9veXZ1SHJqTWxCeDh3L0VQ?= =?utf-8?B?U0JRTHlSaGorQWFORVFGdXRrTmVncVU3cWl6K3dPVFBGMUQ0Nnk1TzJyN3Nl?= =?utf-8?B?UjFSa3pHNGY0NUxYZGN4UFpRanI3OXdVVStRdmxRUjc3UWdxTHBrdmtiQnBX?= =?utf-8?B?SWxUYnBuZmUwaTFPYmZHc0wxYmJyNmJZRjFHdXJod1k4UXlDS1JJVzRnMUxT?= =?utf-8?B?aVhJQ3doaWZOMFM1cUN3UGFjMjk1K3RTcStsNFZxU2tPQmIvUDJrbWpXUUl6?= =?utf-8?B?c092alRwaFdHekhMMW5Cayt0Nnl5TGxWdlYyMy9hM1hkbzhWR25XYWwwZnBQ?= =?utf-8?B?WTV2bUR2RFZWeWl1SDRSMVB5N3RzSVlkLzdtSnJNYXRjWmhTaWhUdk9Weldo?= =?utf-8?B?NFhVVWtWK1IxZnJhQ01NK2d5bkNZMmU1YjBWcEF0UFdiWnp6YUc3MEFyU2Ey?= =?utf-8?B?bGg3MHhNTkw1UEJFR3FZMHVZZ3liSjlydkFzZDQ3WU9KNXFJNUNyRExtZUM0?= =?utf-8?B?bzA0UGdFbjRNV1hnM2pjbVA4VHZkRmxTNHlUamFLZWhEYTdpMzhpNFNIbDVD?= =?utf-8?B?WkVnSlU5RlNZaW5JeWptc3ZncFh2bVFqdmtBSC9iUnhPbWdyeGU2RUhIUVE4?= =?utf-8?B?Rk9UK2dPOHAvMCtnbHd0QzhCZjgyOXd6b0U2VUxQNXpPb1ZTeW9ycDNRL3RU?= =?utf-8?B?ZGhUeTVNU05SdUlzd1FLNE5JeG54N3grdXZBWUpGMDA5TXVqS0RjWWgxMkFN?= =?utf-8?B?WTBGbmVXMWRkOTdCbUdJLzhScDVMU3JVU213Uks4ZUY0Y2gxMTZybGdaN3NS?= =?utf-8?B?UGRPR1BUcTZiekgyd241aGtlWTh5VVpyaDJHeHJrQzJxM0NIU1ZPcVN4YjRm?= =?utf-8?B?Skx0cUhyMVF2djFqTWNDYUtnMldmd0VTSUVFa2lWWnJKSm4yOXdHSHJGQnMv?= =?utf-8?B?VGhYdG9oOVZzV1JFb1ZRcHVNcHAyUVQ3S1FMYWpWbFcvNEorZUJvcEtNS0l1?= =?utf-8?B?ZUhHVEl1NXNwTkVMNW81dkN3bkQrWnZ3ODRMWVpHMnpUczNIQURaQUVSdXJl?= =?utf-8?B?R0NXbGxHY29zeSt6Rm9TSjlReEVPc2xIcGNpT1doa2YrUmxmN3Y4V3hJdllh?= =?utf-8?B?dDhCaUkwRWhuamUvNkY0VWJzelo1cFM2VlRPbG15QlgzaFpSdkNJWkdsRDFL?= =?utf-8?B?V0xqelBidzB2VlUxcDdKNEtCVlp5cUxacmh5MUlmZCtkMzRuV3NCRTBOZmN0?= =?utf-8?B?SzN3NDA2M0FRakVDQ1V4cnVDb2R2eWs0bXlPaEVzU3l6WGJZblZHZ09JOUV3?= =?utf-8?B?YjJ3QVhydDhVR2Y5SWp1QkhrT0tFVmpsUVlob0RNTFlpVzJkRE1saEd2bHBw?= =?utf-8?B?Rkc1ODIvRUtxeGsyTm8wN1A0ZWE0OXVCZ1hvMEN3TVh5T1lhTkpGRTkrMjFq?= =?utf-8?B?a210YjR2VDhoVmdIa0lERzZCb0cza0NsMTgvNXU4L1hFZGs1L1N1VUJBMVd3?= =?utf-8?B?L3poK0N4UGI3Mk1wbjY1c0Ira1ZuWWx2NVNqZGtVZWt3cnlrbzZSbjdvSHFB?= =?utf-8?B?UVBPV05sRk44eVpvcktJZWhPQTVRT1M5WnBsbGRMSFBLK3liR3IrNVJqb2ZE?= =?utf-8?B?bUUxY2Z2bmJJR3ZSTThVSnFHdlR4RDUvSEhoTXV5dGlkTFZ1eVV1MU1LUEhq?= =?utf-8?B?bG1meG5vbWxEb0JIQW5JNU11VnpyOGFjbDlISjhReUhxY1V4OHZLSnBaV1ZC?= =?utf-8?B?eEtOL1dEM1Y5djZzYnF0bTB0RFpYQlVwZUY1RVhVV3JRaU80cGcyY0swLzhG?= =?utf-8?B?ZHJlcnMvenZSaHk3ak9wVnFsR2U0dktDM0Z1SUdmR0dOU3oySE1lN25vTlBM?= =?utf-8?B?YTZNN0pPWUEyY2JpOU5BTnNoRG5PcTBmK0JPbXVGZTM4Y0IzbVdHQzNaT1RN?= =?utf-8?B?VFhXMExNSzFXa244UXE1UjJ4ZXVKQ3ltZitGNlVrUk5ZTmZVN1grdVV4YS9q?= =?utf-8?B?c3dzUlIrWW1RV0N3OCt6QWRURmZOVDQyWVZtUT09?= X-Microsoft-Antispam-Message-Info: 4c1fWWfyBpib5Z73g+K5ajtaeBP5+kKg8o8Ohq6jEW41IPX1Tdc1tIYie/R5bZNstmrPVW0inaJ7N4y2D3p7cnhBhHnojjPLub8wMN2SYqbsXkzKZhfxl3vJ4OpbHRH786w3eE359efg36aO7Iumg5eO6pIityx47SnzqDG/thdPG6kjVy1gSoK2RY8eVgVo X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 6:2EZZ2kcBvfIMssb64vtAPNJqOjNILYXcE1QQU5K4Inz4XA3cqKVsOtATTuoDN4dux8eRGqQ+YFKRc9LClcA2c9ZFwYFT84TrDakgYpn3TAWH1RS4+juNC+rkXfvdrsUWrL3Z3fK2I7sBAGb/cE95NFE4V3JVjnq0/0vO9rlsV9xjAnjSh0Xu02OIa5tRnWzGx/j0dx8nDtwO7QF2tJxNW5fWUzkUVvVEJ0ROnUJH4fXB1+29zXfbe+Uczp08cmJeCFEsCYQpHUOSrDqTQaPArrR5cy9fQNiOKfJRdxFIOxOx+fS3gcGCGcj8rR+xIInKhtNghv7s7Rc0PJ1/YIeZWuX2kAfN31Lc5p5u1DcCgSaNd51x41kw2w92k3oMWGUuo9t2dXauu0B7rTE47Pz5XV+jKEcCQYfbTvxmm7He7f44o2HU6S0HDXRTwf0TYd/keW7PTNKxcta+1uds+sz4tA==; 5:43hf2RNFE+oofwji3JRZOmeYmysUlQcheFaGHhv1IDkHAYnLeYaI7pBN7cmd3iEMyFznG6ZU502gS5G0DGPlGBG4q08pqDCwEJ/Jv7rr/sLaL+nMoHyP1Z3u8yobdPBVVsV36VKg0ZZ9BlrSQ/FCaxVDE28f5F78v/+MR2biV9o=; 24:ppZkZWahqDlM+wijL6jEr8mdHRa3EN80+4n/suOT7RJAU9/s2+2qE0D5/ozr6orIrfITNrrQHXt7KmWXk0QOsbHOROPMXHTh9yuFWh/A+3Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 7:oAourdWCt7HnN/kJgiv6qVdapxG7ejRbmvpgpzlEgtfcN5HpOsiXbwcw7DHMlCDEWczaQxWJbCgMFRce5Y7Rn6Gn+YqV1TB1N03d2YQ8z0G6oPKJshUlT+VMlXb8xWkWyHukSBOtavFxpLT6H4vKd6b4MGTPq5dRUmaU5rLfzDSnO1CIuLQdI2/8y9T049T1M3lflHdUzCmz030+1DqmTWO2jL5yEUKUsXhUX+P63T7Ng3Wd5v05qhQWWcKN+3D6 X-MS-Office365-Filtering-Correlation-Id: f0ea2a6f-6b33-4c57-62db-08d5b3fde3ed X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2018 09:35:33.7219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0ea2a6f-6b33-4c57-62db-08d5b3fde3ed X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2527 Subject: Re: [dpdk-dev] [v3,1/5] eventdev: introduce event crypto adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 09:35:41 -0000 -----Original Message----- > Date: Sun, 6 May 2018 00:17:06 +0530 > From: Abhinandan Gujjar > To: jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, > akhil.goyal@nxp.com, dev@dpdk.org > CC: narender.vangati@intel.com, abhinandan.gujjar@intel.com, > nikhil.rao@intel.com, gage.eads@intel.com > Subject: [v3,1/5] eventdev: introduce event crypto adapter > X-Mailer: git-send-email 1.9.1 > > Signed-off-by: Abhinandan Gujjar > Signed-off-by: Nikhil Rao > Signed-off-by: Gage Eads > --- > MAINTAINERS | 5 + > lib/librte_eventdev/rte_event_crypto_adapter.h | 554 +++++++++++++++++++++++++ > 2 files changed, 559 insertions(+) > create mode 100644 lib/librte_eventdev/rte_event_crypto_adapter.h > Overall it looks good. #1) Please fix the following ./devtools/checkpatches.sh warning. ➜ [master]laptop [dpdk.org] $ ./devtools/checkpatches.sh ### eventdev: add crypto adapter implementation WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #106: FILE: lib/librte_eventdev/rte_event_crypto_adapter.c:1: +/* SPDX-License-Identifier: BSD-3-Clause ### test: add event crypto adapter auto-test WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #38: FILE: test/test/test_event_crypto_adapter.c:1: +/* SPDX-License-Identifier: BSD-3-Clause total: 0 errors, 1 warnings, 927 lines checked ### doc: add event crypto adapter documentation WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #41: FILE: doc/guides/prog_guide/event_crypto_adapter.rst:1: +.. SPDX-License-Identifier: BSD-3-Clause * In the RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode, if HW supports * RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD capability the * application * can directly submit the crypto operations to the cryptodev. * If not, #2) I have added minor changes in description, Wherever it makes sense to you then please pull it for next revision. Else we can discuss more. a) I have uploaded the diff at https://ufile.io/247t9 for you convince. b) Please update the similar change in programmers guide too. diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.h b/lib/librte_eventdev/rte_event_crypto_adapter.h index 2c1f54f76..55fbdc55e 100644 --- a/lib/librte_eventdev/rte_event_crypto_adapter.h +++ b/lib/librte_eventdev/rte_event_crypto_adapter.h @@ -23,14 +23,17 @@ * between the crypto device and the event device. * * The application can choose to submit a crypto operation directly to - * crypto device or send it to the crypto adapter via eventdev, the crypto - * adapter then submits the crypto operation to the crypto device. - * The first mode is known as the event new (OP_NEW) mode and the - * second as the event forward (OP_FORWARD) mode. The choice of mode can - * be specified while creating the adapter. + * crypto device or send it to the crypto adapter via eventdev based on + * RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD capability. + * The first mode is known as the event new(RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) + * mode and the second as the event forward(RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) + * mode. The choice of mode can be specified while creating the adapter. + * In the former mode, it is an application responsibility to enable ingress packet + * ordering. In the latter mode, it is the adapter responsibility to enable + * the ingress packet ordering. * * - * Working model of OP_NEW mode: + * Working model of RTE_EVENT_CRYPTO_ADAPTER_OP_NEW mode: * * +--------------+ +--------------+ * --[1]-->| | | Crypto stage | @@ -47,25 +50,27 @@ * | | | | * +--------------+ +--------------+ * - * [1] Events from the previous stage. + * [1] Events from the previous stage and enqueue to crypto/atomic stage * [2] Application in atomic stage dequeues events from eventdev. - * [3] Crypto operations are submitted to cryptodev. + * [3] Crypto operations are submitted to cryptodev by application. * [4] Crypto adapter dequeues crypto completions from cryptodev. * [5] Crypto adapter enqueues events to the eventdev. * [6] Events to the next stage. * - * In the OP_NEW mode, application submits crypto operations directly to - * crypto device. The adapter then dequeues crypto completions from crypto + * In the RTE_EVENT_CRYPTO_ADAPTER_OP_NEW mode, application submits crypto + * operations directly to crypto device. + * The adapter then dequeues crypto completions from crypto * device and enqueue events to the event device. - * This mode does not ensure ingress ordering. The application is expected - * to be in atomic stage. Events dequeued from the adapter will be treated - * as new events. + * This mode does not ensure ingress ordering if the application directly + * enqueues to cryptodev without going through crypto/atomic stage. i.e removing + * item [1] and [2]. + * Events dequeued from the adapter will be treated as new events. * In this mode, application needs to specify event information (response * information) which is needed to enqueue an event after the crypto operation * is completed. * * - * Working model of OP_FORWARD mode: + * Working model of RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode: * * +--------------+ +--------------+ * --[1]-->| |---[2]-->| | @@ -93,8 +98,9 @@ * [7] Crypto adapter enqueues events to the eventdev * [8] Events to the next stage * - * In the OP_FORWARD mode, if HW supports *_OP_FORWARD capability the - * application can directly submit the crypto operations to the cryptodev. + * In the RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode, if HW supports + * RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD capability the application + * can directly submit the crypto operations to the cryptodev. * If not, application retrieves crypto adapter's event port using * rte_event_crypto_adapter_event_port_get() API. Then, links its event * queue to this port and starts enqueuing crypto operations as events @@ -121,7 +127,7 @@ * - rte_event_crypto_adapter_stop() * - rte_event_crypto_adapter_stats_get() * - rte_event_crypto_adapter_stats_reset() - + * * The application creates an instance using rte_event_crypto_adapter_create() * or rte_event_crypto_adapter_create_ext(). * @@ -173,8 +179,10 @@ enum rte_event_crypto_adapter_mode { /**< Start the crypto adapter in event forward mode. * @see RTE_EVENT_OP_FORWARD. * Application submits crypto requests as events to the crypto - * adapter. Adapter submits crypto requests to the cryptodev - * and crypto completions are enqueued back to the eventdev. + * adapter or crypto device based on + * RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD capability. + * crypto completions are enqueued back to the eventdev by + * crypto adapter. */ }; @@ -215,11 +223,12 @@ struct rte_event_crypto_request { union rte_event_crypto_metadata { struct rte_event_crypto_request request_info; /**< Request information to be filled in by application - * for OP_FORWARD mode. + * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW mode. */ struct rte_event response_info; /**< Response information to be filled in by application - * for OP_NEW and OP_FORWARD mode. + * for RTE_EVENT_CRYPTO_ADAPTER_OP_NEW and + * RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode. */ }; @@ -234,7 +243,8 @@ union rte_event_crypto_metadata { struct rte_event_crypto_adapter_conf { uint8_t event_port_id; /**< Event port identifier, the adapter enqueues events to this - * port and dequeues crypto request events in OP_FORWARD mode. + * port and dequeues crypto request events in + * RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode. */ uint32_t max_nb; /**< The adapter can return early if it has processed at least