From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0051.outbound.protection.outlook.com [104.47.38.51]) by dpdk.org (Postfix) with ESMTP id BAFB9239 for ; Mon, 7 May 2018 15:07:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=J9yTVZyOeluSrLHeNazCRg0A1WIj87cg6srnHFF33Rk=; b=mFUtTHTuDRdwwsJ10J6dOOUJHZBWJZUT70/AfhyxQnCP6yW940QQLHgYb2fwQ7TNucO17gYtL+HAZ1+rRVIGHCYWnnlHcDom7x0sdGX3Ff/PBmMDKRmddh7rpya/dzQGQJlDLeqnE99uVmA+PE2rp55EeaLRFs0eFNlBprOlpeY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Mon, 7 May 2018 13:07:42 +0000 Date: Mon, 7 May 2018 18:37:25 +0530 From: Jerin Jacob To: Akhil Goyal Cc: Abhinandan Gujjar , hemant.agrawal@nxp.com, dev@dpdk.org, narender.vangati@intel.com, nikhil.rao@intel.com, gage.eads@intel.com Message-ID: <20180507130724.GA18930@jerin> References: <1525546030-11204-1-git-send-email-abhinandan.gujjar@intel.com> <1525546030-11204-2-git-send-email-abhinandan.gujjar@intel.com> <20180507093516.GA8052@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR01CA0118.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::34) To SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 3:dcDr49DSs/Ej0iCjKTOpgvo1GO2SgWCZsTqNajP8sZf0IvyXme2yrw8mwH3vAExCDYCsjhdsJQlEHTarkM/IUyYKapzX2PSJsVBPKx8epknXVnk66S7iGWuKohzzCfkEk1F/a4pr+EVS5U9L63hAOVnT5xoNXo0w0cNY2UKpwL0AlkU2YzHnJxIkQi2l/xPYeTGZSsNUGnD+7VeqECwmRLxLtnSMLtsmtgFraH1TampJnB3tZLJWHDtmjaeLlvwK; 25:4GsC4mSPSu2INFIqjDOfvIX7mmm7CCAm55woKSxBgOUt0zuq7fS4ukLLwtT9exr2IKWotyeRTiJcHJKsDvJbHcMhgXX9XVXHz5yVeOZJWzIE8+j926jAWLFNjJj92ykCDhYjYviF8G8YXw451pmB6z9q1SOLzLTslTjwi2me2EtqqvTISntiCCOs6R4iK4Wfz7VTacJxdNbx+dvgzULq9UOUMEcvtrJMKlE8gWIqaKJ/DGG6SITOxgZxZUHotDq4shiM3YFlyUxmM4uCcpRItaWsP+onvSc+KUKJwXpTb/3N3YiY9RH3iGcc9zXFi56dj0rS+5AlLvkVAMIJUUZd7w==; 31:22qMNrBJqG0EOc6voiWxfpdyN8L3MtkEggAoIgjPWpsgqsLo9RrHrRpu9IAlQK7XYlTD6OfFE9RXrtCAfoa8g20FgZjb0aKNIDEq4IJznc+8mbUfwzQpO+uQQrsWI9BeA1z7xRNVlsAvYkB2JEW+plIOZlk+S9zEsxjIQHxkLvMfb8euCwM/BVVqfF9N5qt4EUqo2MSHk0k4r0GpXBXBzWG6ChJ7iYD5z448D2bo1cs= X-MS-TrafficTypeDiagnostic: SN2PR07MB2528: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 20:Syrhv4/jIFfenRo4eJ6ZOV6DZ1vHMSYHf08vfEaMtNZkq1tiP5OT79GQJxwOFfiUB9Zy7oYuJ/HJ2Nc62fHZSCuUXrzpLhBZusAwzc1XhsUzZNltCSL3WNQ+a50dg7GwMRtuRhW/UP5miKrCFxQS+vKGpadBYckfUfYsrqnKkn6FMqgU+UhcNsaIFcAA3zucKZmaAu0fUJ6AzN96R/WWT+/hwQJXUzo4C+8IlI+R4D52zGDoG+PTzpOLlYpLGen1/vFbQG9LkVitSd4w6XJb0xkh6cxe0Xed6XTwFcmMJgENV/C8P2LpCKXOjFQ02zwLakjpl1OsPLDTUBh0/Cy5ac7F9XdDC/2E+gzD3aeyEuabk1524Wq2ZrE67tSBUETltn8gEB/gsjrxNVipD5NkOvCEEw0rI/sHhd75ozzq4kF4r1bmVpNg+i0CxgfeQj71buHPw6sOsJn49S+rQEYT22fKrzMLW/qPZ8ynPrsDCMIBdV0Mep8UcRPTP27wVYxhX3NS4Aqcz/Y2mfYid8rwQIuazuRojmONIHjvrOu/rZMAb+13TdMic5Ozg0wtqg7aVSHYzpet6vz8Ya1Nf4sXzK+uvT5LT+O86UNz5b4zn6U= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:SN2PR07MB2528; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 4:D/7+bxL6+EFK93ZgsKmckS7cE0JT6ij5Y9PinzX3GGnpWw0hHcf2VTT1yE0Z3TvKES8YnDvT1UF/MjCj/B3YOsnw5SCPGIUCUYHg6+C+fUTHBwCF2nxrJIK0MN1i/jD06HoL74TlNOgb4i3yagewKAgdUcXM/WxdXAkU79Rr9Zzq440zXe/uR6jZ4l2UYlE/0/d2mEtxxtzSrwapGqUaPgPv8tXrqp2KTA/KX2B+TEMks9Ao5eNi89+P7zLxssWaYnyXAKh7RBkv3RgD9RoRM3kNItx3avx+ts2N8UB3W+X9fLk2krBVI2TGzEcNqR6+ONJbzP1JnXpODpTUpK5Tws7e6yAwS89K+MdsqTf1UYA= X-Forefront-PRVS: 066517B35B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39850400004)(376002)(346002)(39380400002)(366004)(396003)(13464003)(189003)(199004)(6666003)(106356001)(6916009)(58126008)(81166006)(81156014)(8676002)(229853002)(5660300001)(105586002)(8936002)(68736007)(93886005)(305945005)(7736002)(316002)(55016002)(53936002)(6246003)(6306002)(9686003)(6116002)(3846002)(4326008)(97736004)(47776003)(72206003)(966005)(50466002)(2906002)(1076002)(2870700001)(25786009)(478600001)(66066001)(59450400001)(52116002)(11346002)(8656006)(26005)(6496006)(52146003)(33896004)(2486003)(23676004)(16526019)(33656002)(42882007)(76176011)(186003)(956004)(53546011)(486006)(44832011)(446003)(33716001)(476003)(55236004)(386003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2528; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjA3TUIyNTI4OzIzOi9oaU9vb29YNWdnbXRhNHdFZTdBU3lpT0F4?= =?utf-8?B?YzgvQitxUWlCTUpXMWllbS8vZ1lITkZGYUliZzlkbnYrVzlTZUtZbUExSTY1?= =?utf-8?B?N1Q5alBBYXRBcm43RnRHQ3YwVEFYNEk5ODVNUHBjSFBEWTlDdVJneHVoSGll?= =?utf-8?B?R3B0b0RGTE45YXkrTHhPZ0NHblByTms1YmNGWDBYNlZ1anBxTWxXbE5JTFRK?= =?utf-8?B?ZElaNldEODVhcTQ5MTVMWjVVa0RIbmVtV2FoTUVIMkhacjRPajd1MmZ3U2VG?= =?utf-8?B?ZlF4ZEZQU25JUDVIaUtTNU01TG1FbGduYTNicktXK0kycXkzVklVNitqOUp4?= =?utf-8?B?SGllek5HbmMzcnFzcERqNU9CRERhbVdHM3VSNkxwQmVIWXlFblF0V3Nmb3p2?= =?utf-8?B?UDAyNFhBdGQxTjdTTHhWNjJSVDRIMkdjNTFrK0Y0WGlicDdpMGdXK3JkaDgv?= =?utf-8?B?STBxL3l1ME5IZVpjek5LU3VwcFdON1NQallRZ2NNOHIyZmcwSmNEdlRQYWh0?= =?utf-8?B?QUlxcVJCY1hKbDU5MWNOTnBPK2J0NldLaVBLZjhjT1JCUm9tSmNadG9OdCta?= =?utf-8?B?azdjRE5SbWtUVFJleDBONTU4cVNlNXhOL2N6TFZaVUlvZXhPcFNBVVZDanRE?= =?utf-8?B?UU9NcUx0OEJiODIvMmQ3SDY3UFAwUEtYd0syM3NKeU9za1kwTDNCQUszYkdP?= =?utf-8?B?RjFyU3BJTFE1RFNHSVA1am1MZ0tLYlRKQTAxU1hYdXY3clVpVVVsNnAySFNl?= =?utf-8?B?c3ZReEJTY3N6TjArV2lNR2owQlJSUk5uSXlGcjlBUENSUDkxTzlER24zRXRt?= =?utf-8?B?cFhZb1FBcnhyWFM5Q2lDcEdFZ2dlczRDeE0wdm5FanlYaFN3Qm53ZUlKWllu?= =?utf-8?B?UGppTkd0OUo3bW1wQkQyTWdJSVRQaUY3LzdUcFRzdWRtNmZ4cEtKOUJhTlV3?= =?utf-8?B?S0NOK2tpcVAvNnFOTGdmVGNhYkVJTVJ3TmRqL1Aza0xoaUJLWjhlZjJZa2hT?= =?utf-8?B?cnJCcStUWHVYd21ralN4Skh6c0cxaEIyTGgyekg2cUJVOHkvSE9FYTM4MGtk?= =?utf-8?B?OHA0YmdqNUpsOVhidTQrS0lMZXhUKzEyS2pFdE00MHBtYS9XRUU1L1B6YXRk?= =?utf-8?B?b1JsUG1hdmlnb2RUbDMxVVhGWS9JaEhmY3lrR0ZzaEtiOXVRUFNRMEQwbXUr?= =?utf-8?B?K294L292bXVFOFdWQWViajBiWjZoWFBpQjRsM1BjQ0RZbHQ4L3dQOVlpSkQx?= =?utf-8?B?dlExWGlYdkdBaWZGenUzZG51cnBYaUxlVEduMVQ0dVVXb1JKeXBDbzZxZER0?= =?utf-8?B?YXhMcEpIdXNHWlhLUnRTaUVmTSs0MGdxOFMrVFJsakFwcjhMR0Z5MDREU0o4?= =?utf-8?B?OHV2SWFadG5Xb1JqVUdvMG5NdlZNTFVwOG5Sa3RHblRQNkJLUnU2NGxRdzk1?= =?utf-8?B?bkZZTHBZNWsrRmswenM3V1VFdGdObnlsekdBZG9rVjdKcXJDOXFjKzJHUWdC?= =?utf-8?B?cTI4WXFRS3VWQTVXY0ZnSGNkVUprd3h2Q0VvVXMyclJaOWdSUEs5SllMM0xU?= =?utf-8?B?LzRwZ2R4SldJdTBsbEZuZTdyQitQaUJpR1g0TERnVktWMWU5elBhdDdnVUN3?= =?utf-8?B?eWFKTDJLdGMxNS9BblRoQUViZGZxSVRiTldjMVFhQnZvcHNuaEpmUStPNDVw?= =?utf-8?B?Uk0wWnBIL0VXQkY1cWNyUkxFMXZOTExHRGMzNXNtQjZkL1JHcnkvcWJDdnph?= =?utf-8?B?MGZvRURTSGtJdWNyQWxBWkVpT0xHOWZNbm9TbGRMRnVHaVBVVmQ5bTF5NWhE?= =?utf-8?B?ZXlFWHdSWXJiMHZSRTJPQkkwdkxRTHJLMG5FYVFxN1hoeDZ1MDdDNm9YWWF5?= =?utf-8?B?L0FmQSs3Vys5UkIxN3AxeWQ2VzJtcjEwaDVnRExiSnN1WnJmRUFLVURtOFdT?= =?utf-8?B?T3VZWDRJN2dIM0FrYnEycUhlRFdVMnNaOHA3dnJUSTAxWm9yQmNPelNObk5M?= =?utf-8?B?UVo4RUs5RXpycDVWNVlhemZqUm5GcDJVbFE2cWs5M2ZHTTZwcXBrK1Q4dGVw?= =?utf-8?Q?xpdaMho9wJAKeM5qd6UHlPdjB?= X-Microsoft-Antispam-Message-Info: S3vhddVbaJvIzVy9hqToJl1fN1cPuK7+4XMHTrAa43KnPI4hHT+pY017JMjals3OWZfKvKIAro3wbEqOcrxSYj8qBzEbF8aCNmGlA4vpZnkdil5ZCwtkuiYBNH4rJZ7aOpJUFd7G2g4Oc3W2tdix5MmbKpLwsoqkvNkEfbLGwPKKo1zwrhCt1mm65yFfsfdT X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 6:HgYTSa1q18UVCJ7d89XwrArgubiG9+LBW2SetX0axsMN9zmct8F4WgjSMbJVhAswUu/Pakub3nwxvZTCQuYRHPUw7ifvZLnUOnKfDLxydUAoBCzG60Mj5GPoHO4ND01wwkA/D25LE5VHsHp50nGxVePyrMxolZAhF4fESt/g8Di7JcXbUZodosFrrj0dhdRyQpXpp5IvUDHH5yqQtyIGh1JpsGojE1tD5/o42xRyiYrsX3kXsVYxpaWp+xPYTCtj+2LZPbBRJmfbx3FoH535ndaZ8P6U4JFux+X+yCuM9kQmeHKYUQU0aPKbMroteJxPHFJaLIgYFxq1Q/JPuxOGo+m+yr5f4wrWnMIJ5z93w9eaRafD0QRaCnOKDYfXkH+RbQzh0YY8PzsNGIQzONUvixyQLaHdmubEn7SRbCoBDBx3W2OJrcTGMt+P0OQXjyAW3I9nqPd+Tamg1Kn8aZTGTg==; 5:EkCx0SEI194XL6NKJv+UIodrCByG3Ma0dFyMj4NpOaXSa6v5IkxQkq1OOotoPPB2ogCvTDEtUiEHFmZ/drVqtOsq0wRdMWUL1DLDjHdonDJCtgZE8LdYbPp4V+oZ3MkZpmuodrnh1W8KBkDDMT0UbERJvEmp5T4S5ANM/62/I/U=; 24:dRskTDvgmt9sOaa2Ea0M2q8Yqfbh9zHwBXCEqqRplcMJcjtXHah6zV26yJTvkAr9mDIkENZuA1hOBaTUzA4ocTgJGRbuv+rAUI9oD4igYaE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 7:z92XsV2FHHwulLWqwGRxhmGJji6gGyiKLEYpiZW88M4GLk5EYJ+sZGBkbzlrc1ybiwCMorWi9B9lZbWbJ7MjRDvOLsZ71++35x3itmX9JqWk+QO9SHfuGLB3XtwAOTuKj/33tlppRnPoLCTja2GmduigGYS9XCc7y5ooc0T/Xz/IrygvU14EWzElSX2BrHolPPzhB/XHom/ZcFr3k37PUIwpXTVKsF9xUHPr7+Oj4LOhm2c+kjhbX8IARNi2YOPK X-MS-Office365-Filtering-Correlation-Id: 32d88fb6-97fd-4aae-8dd4-08d5b41b862d X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2018 13:07:42.3349 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32d88fb6-97fd-4aae-8dd4-08d5b41b862d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2528 Subject: Re: [dpdk-dev] [v3,1/5] eventdev: introduce event crypto adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 13:07:48 -0000 -----Original Message----- > Date: Mon, 7 May 2018 18:02:04 +0530 > From: Akhil Goyal > To: Jerin Jacob , Abhinandan Gujjar > > CC: hemant.agrawal@nxp.com, akhil.goyal@nxp.com, dev@dpdk.org, > narender.vangati@intel.com, nikhil.rao@intel.com, gage.eads@intel.com > Subject: Re: [dpdk-dev] [v3,1/5] eventdev: introduce event crypto adapter > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 > Thunderbird/45.8.0 > > Hi Jerin, Abhinandan, > Overall the patch looks good. > But one comment on block diagram for OP_NEW mode functioning. > The comment was also made on previous version but it looks the intent was > misunderstood. > > > On 5/7/2018 3:05 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Sun, 6 May 2018 00:17:06 +0530 > > > From: Abhinandan Gujjar > > > To: jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, > > > akhil.goyal@nxp.com, dev@dpdk.org > > > CC: narender.vangati@intel.com, abhinandan.gujjar@intel.com, > > > nikhil.rao@intel.com, gage.eads@intel.com > > > Subject: [v3,1/5] eventdev: introduce event crypto adapter > > > X-Mailer: git-send-email 1.9.1 > > > > > > Signed-off-by: Abhinandan Gujjar > > > Signed-off-by: Nikhil Rao > > > Signed-off-by: Gage Eads > > > --- > > > MAINTAINERS | 5 + > > > lib/librte_eventdev/rte_event_crypto_adapter.h | 554 +++++++++++++++++++++++++ > > > 2 files changed, 559 insertions(+) > > > create mode 100644 lib/librte_eventdev/rte_event_crypto_adapter.h > > > > > > > Overall it looks good. > > > > #1) > > > > Please fix the following ./devtools/checkpatches.sh warning. > > ➜ [master]laptop [dpdk.org] $ ./devtools/checkpatches.sh > > > > ### eventdev: add crypto adapter implementation > > > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier > > tag in line 1 > > #106: FILE: lib/librte_eventdev/rte_event_crypto_adapter.c:1: > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > ### test: add event crypto adapter auto-test > > > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier > > tag in line 1 > > #38: FILE: test/test/test_event_crypto_adapter.c:1: > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > total: 0 errors, 1 warnings, 927 lines checked > > > > ### doc: add event crypto adapter documentation > > > > WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier > > tag in line 1 > > #41: FILE: doc/guides/prog_guide/event_crypto_adapter.rst:1: > > +.. SPDX-License-Identifier: BSD-3-Clause > > > > * In the RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode, if HW supports > > * RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD capability the > > * application > > * can directly submit the crypto operations to the cryptodev. > > * If not, > > > > > > #2) I have added minor changes in description, Wherever it makes sense > > to you then please pull it for next revision. Else we can discuss more. > > > > a) I have uploaded the diff at https://ufile.io/247t9 for > > you convince. > > b) Please update the similar change in programmers guide too. > > > > > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.h b/lib/librte_eventdev/rte_event_crypto_adapter.h > > index 2c1f54f76..55fbdc55e 100644 > > --- a/lib/librte_eventdev/rte_event_crypto_adapter.h > > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.h > > @@ -23,14 +23,17 @@ > > * between the crypto device and the event device. > > * > > * The application can choose to submit a crypto operation directly to > > - * crypto device or send it to the crypto adapter via eventdev, the crypto > > - * adapter then submits the crypto operation to the crypto device. > > - * The first mode is known as the event new (OP_NEW) mode and the > > - * second as the event forward (OP_FORWARD) mode. The choice of mode can > > - * be specified while creating the adapter. > > + * crypto device or send it to the crypto adapter via eventdev based on > > + * RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD capability. > > + * The first mode is known as the event new(RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) > > + * mode and the second as the event forward(RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) > > + * mode. The choice of mode can be specified while creating the adapter. > > + * In the former mode, it is an application responsibility to enable ingress packet > > + * ordering. In the latter mode, it is the adapter responsibility to enable > > + * the ingress packet ordering. > > * > > * > > - * Working model of OP_NEW mode: > > + * Working model of RTE_EVENT_CRYPTO_ADAPTER_OP_NEW mode: > > * > > * +--------------+ +--------------+ > > * --[1]-->| | | Crypto stage | > > @@ -47,25 +50,27 @@ > > * | | | | > > * +--------------+ +--------------+ > > * > > - * [1] Events from the previous stage. > > + * [1] Events from the previous stage and enqueue to crypto/atomic stage > > * [2] Application in atomic stage dequeues events from eventdev. > > - * [3] Crypto operations are submitted to cryptodev. > > + * [3] Crypto operations are submitted to cryptodev by application. > > * [4] Crypto adapter dequeues crypto completions from cryptodev. > > * [5] Crypto adapter enqueues events to the eventdev. > > * [6] Events to the next stage. > > I think the sequence should be as follows: > [1] Application dequeues from the previous stage. > [2] Application prepare for enqueue to cryptodev > [3] Application enqueues to cryptodev > [4] Crypto adapter dequeues crypto completions from cryptodev. > [5] Crypto adapter enqueues events to the eventdev. > [6] Application dequeues from eventdev and prepare for further processing. > > So the Block diagram should be something like > > + * +--------------+ +--------------+ > + * | | | Crypto stage | > + * | Application |---[2]-->| + enqueue to | > + * | | | cryptodev | > + * +--------------+ +--------------+ > + * ^ ^ | > + * | | [3] > + * [6] [1] | > + * | | | > + * +--------------+ | > + * | | | > + * | Event device | | > + * | | | > + * +--------------+ | > + * ^ | > + * | | > + * [5] | > + * | v > + * +--------------+ +--------------+ > + * | | | | > + * |Crypto adapter|<--[4]---| Cryptodev | > + * | | | | > + * +--------------+ +--------------+ > Please let me know if my understanding is not correct. Looks good to me. /Jerin