Re: [dpdk-dev] [PATCH v2] crypto/mrvl: rename PMD to mvsam

[Tomasz Duszynski <tdu@semihalf.com>]

On Mon, May 07, 2018 at 02:19:42PM +0000, De Lara Guarch, Pablo wrote:
>
>
> > -----Original Message-----
> > From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> > Sent: Friday, April 27, 2018 8:15 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> > dima@marvell.com; Tomasz Duszynski <tdu@semihalf.com>; Natalie Samsonov
> > <nsamsono@marvell.com>
> > Subject: [PATCH v2] crypto/mrvl: rename PMD to mvsam
> >
> > Picking a company stock ticker for a PMD name might not be a best approach in
> > a long run since name is too generic.
> >
> > This patch addresses that and renames mrvl to mvsam.
> >
> > Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
>
> ...
>
> > --- a/test/test/test_cryptodev.h
> > +++ b/test/test/test_cryptodev.h
> > @@ -61,7 +61,7 @@
> >  #define CRYPTODEV_NAME_DPAA_SEC_PMD	crypto_dpaa_sec
> >  #define CRYPTODEV_NAME_DPAA2_SEC_PMD	crypto_dpaa2_sec
> >  #define CRYPTODEV_NAME_SCHEDULER_PMD	crypto_scheduler
> > -#define CRYPTODEV_NAME_MRVL_PMD		crypto_mrvl
> > +#define CRYPTODEV_NAME_MRVL_PMD		crypto_mvsam
>
> I think it would be better if you modify the macro names in the test app, to be MVSAM.

I did not change these intentionally since the same naming is used throughout
the PMD itself, so to me it looked more consistent to have it this way.

Additionally I wanted to avoid as much noise generated by renames as
possible.

Besides that, no strong opinions and I am okay with v3.

>
> >  #define CRYPTODEV_NAME_CCP_PMD		crypto_ccp
> >  #define CRYPTODEV_NAME_VIRTIO_PMD	crypto_virtio
> >
> > --
> > 2.7.4
>

--
- Tomasz Duszyński