From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f50.google.com (mail-lf0-f50.google.com [209.85.215.50]) by dpdk.org (Postfix) with ESMTP id 1842F58FA for ; Tue, 8 May 2018 08:13:26 +0200 (CEST) Received: by mail-lf0-f50.google.com with SMTP id g12-v6so44063777lfb.10 for ; Mon, 07 May 2018 23:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qS2QaUM/l0ZFh9WlUvag6XlZQUgzp/KIDmn7tQ9SvVI=; b=VuUtu+aNl8sLJVNUJz/0XXmjr0sC5aQ1a37S1mDQn2YZWql9uXqCvzk61j3WtQUh3d 6vRfCDuQ7/nvmK1n4j8WO8q8FoaKn88FJh4QJ7ZEegvkEZGOKC0E8xn32ZeuLD5dmwqE DoIBrtT/s4b0GQW9uxDXroX5/XS6/DxeYZM8tDh1T5TTnEZWCKSwJ+5SXcNVusBjYHSc YAogDFEJGC/AQ3H3gYTyWsTQAI4fdW7BL0SR/DAuPyIOmrDmpI7iKBTj5X1e4BcLi18n S3nDHGoYG28GvC85SaG7HGn+XwBJemsSVkPwntfnpIQWdC3nF1XdExjt2DoH0EZVJIzb oDsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qS2QaUM/l0ZFh9WlUvag6XlZQUgzp/KIDmn7tQ9SvVI=; b=S03H8iDkrElX6JLGIH2IPcFAhijcoOVLqKc50JDc0Lcaql3QEuEubsCtBhvu4NF7/D o6IW8LvsVhBt14sDyIDgEW0Rh7zWgZE243LyddL8jrg5fuWZ1tmQ6V2uctnduLAZH0Zu mwRgYZ2LPV4enaxTiF4zzyurFqxzL+wOgPZtQSbBq8QgaFmIff0NSrnQmvmaSAZtuUHI X+BKrwgAOZKgOFqZ2AyLxoJA7hyaDKs7yrFVw1k6+Rf5PKjiMHthznKE6Hi6wf2Z0ADj dUqGT9WzLOJKNK7l7bDPrtVlZleDD69LiofF2CSc9FG1OxouOarhMpxq1oTwwh70Gibe I2Vw== X-Gm-Message-State: ALQs6tAiIfPPAL4D2xo+XnPlnHIpkeCKf4jX9DpoC9vi/vjXvchHlu1U CITOBqPdImJTWM4k0t/tpZ+Rlg== X-Google-Smtp-Source: AB8JxZqAVIo6PEJVdkZkKE6+niRwf/qhOXEFvZnMvdyCBiTl5p2K0M7wy5gqT2xewZnQ9K4Nc6y69Q== X-Received: by 2002:a2e:808a:: with SMTP id i10-v6mr25922530ljg.67.1525760005686; Mon, 07 May 2018 23:13:25 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id n76-v6sm4556469lja.31.2018.05.07.23.13.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 May 2018 23:13:24 -0700 (PDT) Date: Tue, 8 May 2018 08:13:23 +0200 From: Tomasz Duszynski To: "De Lara Guarch, Pablo" Cc: Tomasz Duszynski , "dev@dpdk.org" , "dima@marvell.com" , Natalie Samsonov Message-ID: <20180508061323.GA8117@sh> References: <1524763320-29946-1-git-send-email-tdu@semihalf.com> <1524813326-31233-1-git-send-email-tdu@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] crypto/mrvl: rename PMD to mvsam X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 06:13:26 -0000 On Mon, May 07, 2018 at 02:19:42PM +0000, De Lara Guarch, Pablo wrote: > > > > -----Original Message----- > > From: Tomasz Duszynski [mailto:tdu@semihalf.com] > > Sent: Friday, April 27, 2018 8:15 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; > > dima@marvell.com; Tomasz Duszynski ; Natalie Samsonov > > > > Subject: [PATCH v2] crypto/mrvl: rename PMD to mvsam > > > > Picking a company stock ticker for a PMD name might not be a best appro= ach in > > a long run since name is too generic. > > > > This patch addresses that and renames mrvl to mvsam. > > > > Signed-off-by: Natalie Samsonov > > Signed-off-by: Tomasz Duszynski > > --- > > ... > > > --- a/test/test/test_cryptodev.h > > +++ b/test/test/test_cryptodev.h > > @@ -61,7 +61,7 @@ > > #define CRYPTODEV_NAME_DPAA_SEC_PMD crypto_dpaa_sec > > #define CRYPTODEV_NAME_DPAA2_SEC_PMD crypto_dpaa2_sec > > #define CRYPTODEV_NAME_SCHEDULER_PMD crypto_scheduler > > -#define CRYPTODEV_NAME_MRVL_PMD crypto_mrvl > > +#define CRYPTODEV_NAME_MRVL_PMD crypto_mvsam > > I think it would be better if you modify the macro names in the test app,= to be MVSAM. I did not change these intentionally since the same naming is used througho= ut the PMD itself, so to me it looked more consistent to have it this way. Additionally I wanted to avoid as much noise generated by renames as possible. Besides that, no strong opinions and I am okay with v3. > > > #define CRYPTODEV_NAME_CCP_PMD crypto_ccp > > #define CRYPTODEV_NAME_VIRTIO_PMD crypto_virtio > > > > -- > > 2.7.4 > -- - Tomasz Duszy=C5=84ski