From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 469117CD1 for ; Tue, 8 May 2018 21:51:23 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 12:51:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,379,1520924400"; d="scan'208";a="44262329" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.7.111]) by fmsmga002.fm.intel.com with SMTP; 08 May 2018 12:51:20 -0700 Received: by (sSMTP sendmail emulation); Tue, 08 May 2018 20:51:19 +0100 Date: Tue, 8 May 2018 20:51:18 +0100 From: Bruce Richardson To: "Dumitrescu, Cristian" Cc: "Zhang, Roy Fan" , "dev@dpdk.org" , "Singh, Jasvinder" Message-ID: <20180508195118.GA18108@bricha3-MOBL.ger.corp.intel.com> References: <20180416110233.66450-1-roy.fan.zhang@intel.com> <3EB4FA525960D640B5BDFFD6A3D891267BB667A3@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891267BB667A3@IRSMSX108.ger.corp.intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 19:51:24 -0000 On Tue, May 08, 2018 at 02:28:25PM +0000, Dumitrescu, Cristian wrote: > > > > -----Original Message----- > > From: Zhang, Roy Fan > > Sent: Monday, April 16, 2018 12:03 PM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > > > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > > > Coverity issue: 272572 > > Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") > > > > Signed-off-by: Fan Zhang > > --- > > examples/ip_pipeline/action.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c > > index 77a04fe19..91011ebe8 100644 > > --- a/examples/ip_pipeline/action.c > > +++ b/examples/ip_pipeline/action.c > > @@ -133,7 +133,7 @@ port_in_action_profile_create(const char *name, > > } > > > > /* Node fill in */ > > - strncpy(profile->name, name, sizeof(profile->name)); > > + strncpy(profile->name, name, sizeof(profile->name) - 1); > > memcpy(&profile->params, params, sizeof(*params)); > > profile->ap = ap; > > > > -- > > 2.13.6 > > Acked-by: Cristian.Dumitrescu > > Applied to next-pipeline tree, thanks! This is not a correct fix, and the code is still broken. However, I see that you have actually applied the correct v2 patch to the tree, so no big deal. It's probably best to reply to the correct patch confirming it's applied, though. /Bruce