* [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers
@ 2018-05-07 12:30 Pavan Nikhilesh
2018-05-08 7:49 ` Ali Alnubani
0 siblings, 1 reply; 4+ messages in thread
From: Pavan Nikhilesh @ 2018-05-07 12:30 UTC (permalink / raw)
To: jerin.jacob, santosh.shukla, ferruh.yigit, shahafs, alialnu
Cc: dev, Pavan Nikhilesh
Disable octeontx for gcc 4.8.5 as compiler is emitting "internal
compiler error" for aarch64.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
mk/toolchain/gcc/rte.toolchain-compat.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 9f17131f9..0f2b0ff0a 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -12,6 +12,7 @@
GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E -x c - | tail -n 1)
GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(CC) -E -x c - | tail -n 1)
+GCC_PATCHLEVEL = $(shell echo __GNUC_PATCHLEVEL__ | $(CC) -E -x c - | tail -n 1)
GCC_VERSION = $(GCC_MAJOR)$(GCC_MINOR)
# if GCC is older than 4.x
@@ -73,4 +74,11 @@ else
CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV=d
endif
+ # Disable octeontx event PMD for gcc < 4.8.6
+ ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1)
+ CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
+ CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
+ CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
+ endif
+
endif
--
2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers
2018-05-07 12:30 [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers Pavan Nikhilesh
@ 2018-05-08 7:49 ` Ali Alnubani
2018-05-09 2:51 ` Jerin Jacob
2018-05-09 9:06 ` Jerin Jacob
0 siblings, 2 replies; 4+ messages in thread
From: Ali Alnubani @ 2018-05-08 7:49 UTC (permalink / raw)
To: 'Pavan Nikhilesh',
jerin.jacob, santosh.shukla, ferruh.yigit, Shahaf Shuler
Cc: dev
Tested-by: Ali Alnubani <alialnu@mellanox.com>
> -----Original Message-----
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Sent: Monday, May 7, 2018 3:31 PM
> To: jerin.jacob@caviumnetworks.com;
> santosh.shukla@caviumnetworks.com; ferruh.yigit@intel.com; Shahaf
> Shuler <shahafs@mellanox.com>; Ali Alnubani <alialnu@mellanox.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy
> compilers
>
> Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error"
> for aarch64.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> mk/toolchain/gcc/rte.toolchain-compat.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk
> b/mk/toolchain/gcc/rte.toolchain-compat.mk
> index 9f17131f9..0f2b0ff0a 100644
> --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> @@ -12,6 +12,7 @@
>
> GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E -x c - | tail -n 1)
> GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(CC) -E -x c - | tail -n 1)
> +GCC_PATCHLEVEL = $(shell echo __GNUC_PATCHLEVEL__ | $(CC) -E -x c - |
> +tail -n 1)
> GCC_VERSION = $(GCC_MAJOR)$(GCC_MINOR)
>
> # if GCC is older than 4.x
> @@ -73,4 +74,11 @@ else
> CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV=d
> endif
>
> + # Disable octeontx event PMD for gcc < 4.8.6
> + ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 &&
> echo 1), 1)
> + CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
> + CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
> + CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
> + endif
> +
> endif
> --
> 2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers
2018-05-08 7:49 ` Ali Alnubani
@ 2018-05-09 2:51 ` Jerin Jacob
2018-05-09 9:06 ` Jerin Jacob
1 sibling, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2018-05-09 2:51 UTC (permalink / raw)
To: Ali Alnubani
Cc: 'Pavan Nikhilesh',
santosh.shukla, ferruh.yigit, Shahaf Shuler, dev
-----Original Message-----
> Date: Tue, 8 May 2018 07:49:01 +0000
> From: Ali Alnubani <alialnu@mellanox.com>
> To: 'Pavan Nikhilesh' <pbhagavatula@caviumnetworks.com>,
> "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
> "santosh.shukla@caviumnetworks.com" <santosh.shukla@caviumnetworks.com>,
> "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, Shahaf Shuler
> <shahafs@mellanox.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy
> compilers
>
> Tested-by: Ali Alnubani <alialnu@mellanox.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> > -----Original Message-----
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Sent: Monday, May 7, 2018 3:31 PM
> > To: jerin.jacob@caviumnetworks.com;
> > santosh.shukla@caviumnetworks.com; ferruh.yigit@intel.com; Shahaf
> > Shuler <shahafs@mellanox.com>; Ali Alnubani <alialnu@mellanox.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy
> > compilers
> >
> > Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error"
> > for aarch64.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> > mk/toolchain/gcc/rte.toolchain-compat.mk | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk
> > b/mk/toolchain/gcc/rte.toolchain-compat.mk
> > index 9f17131f9..0f2b0ff0a 100644
> > --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> > +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> > @@ -12,6 +12,7 @@
> >
> > GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E -x c - | tail -n 1)
> > GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(CC) -E -x c - | tail -n 1)
> > +GCC_PATCHLEVEL = $(shell echo __GNUC_PATCHLEVEL__ | $(CC) -E -x c - |
> > +tail -n 1)
> > GCC_VERSION = $(GCC_MAJOR)$(GCC_MINOR)
> >
> > # if GCC is older than 4.x
> > @@ -73,4 +74,11 @@ else
> > CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV=d
> > endif
> >
> > + # Disable octeontx event PMD for gcc < 4.8.6
> > + ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 &&
> > echo 1), 1)
> > + CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
> > + CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
> > + CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
> > + endif
> > +
> > endif
> > --
> > 2.17.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers
2018-05-08 7:49 ` Ali Alnubani
2018-05-09 2:51 ` Jerin Jacob
@ 2018-05-09 9:06 ` Jerin Jacob
1 sibling, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2018-05-09 9:06 UTC (permalink / raw)
To: Ali Alnubani
Cc: 'Pavan Nikhilesh',
santosh.shukla, ferruh.yigit, Shahaf Shuler, dev
-----Original Message-----
> Date: Tue, 8 May 2018 07:49:01 +0000
> From: Ali Alnubani <alialnu@mellanox.com>
> To: 'Pavan Nikhilesh' <pbhagavatula@caviumnetworks.com>,
> "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
> "santosh.shukla@caviumnetworks.com" <santosh.shukla@caviumnetworks.com>,
> "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, Shahaf Shuler
> <shahafs@mellanox.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy
> compilers
>
> Tested-by: Ali Alnubani <alialnu@mellanox.com>
Applied to dpdk-next-eventdev/master. Thanks.
>
> > -----Original Message-----
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Sent: Monday, May 7, 2018 3:31 PM
> > To: jerin.jacob@caviumnetworks.com;
> > santosh.shukla@caviumnetworks.com; ferruh.yigit@intel.com; Shahaf
> > Shuler <shahafs@mellanox.com>; Ali Alnubani <alialnu@mellanox.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy
> > compilers
> >
> > Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error"
> > for aarch64.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> > mk/toolchain/gcc/rte.toolchain-compat.mk | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk
> > b/mk/toolchain/gcc/rte.toolchain-compat.mk
> > index 9f17131f9..0f2b0ff0a 100644
> > --- a/mk/toolchain/gcc/rte.toolchain-compat.mk
> > +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
> > @@ -12,6 +12,7 @@
> >
> > GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E -x c - | tail -n 1)
> > GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(CC) -E -x c - | tail -n 1)
> > +GCC_PATCHLEVEL = $(shell echo __GNUC_PATCHLEVEL__ | $(CC) -E -x c - |
> > +tail -n 1)
> > GCC_VERSION = $(GCC_MAJOR)$(GCC_MINOR)
> >
> > # if GCC is older than 4.x
> > @@ -73,4 +74,11 @@ else
> > CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV=d
> > endif
> >
> > + # Disable octeontx event PMD for gcc < 4.8.6
> > + ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 &&
> > echo 1), 1)
> > + CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
> > + CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
> > + CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
> > + endif
> > +
> > endif
> > --
> > 2.17.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-09 9:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 12:30 [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers Pavan Nikhilesh
2018-05-08 7:49 ` Ali Alnubani
2018-05-09 2:51 ` Jerin Jacob
2018-05-09 9:06 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).