From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0087.outbound.protection.outlook.com [104.47.1.87]) by dpdk.org (Postfix) with ESMTP id 5539AAAB9 for ; Wed, 9 May 2018 11:04:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0gCz6b4rr61WTQHx29pNq/TI7vlofTtDHob5AvCU1cg=; b=XGR4CA3rUCyol1YqRlun26rAtmGLI23U5CQ92ZZLYm3h9gl69fSpPWZFKbVvSRrn7PtYjno/OsIEpA+wlZS/d6vplVkxRxpMnQkGtZ9GU83Y0VGIXhxKCyfo82q8nsHL4NknqV0IOdec7VnhBYzgSHQkSyDzWtfhjUnb/H36sZ8= Received: from Tophie.ap.freescale.net (14.142.187.166) by VI1PR0402MB2782.eurprd04.prod.outlook.com (2603:10a6:800:ad::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 9 May 2018 09:04:35 +0000 From: Shreyansh Jain To: jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org, hemant.agrawal@nxp.com, Nipun Gupta Date: Wed, 9 May 2018 14:50:52 +0530 Message-Id: <20180509092053.5956-1-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: HK2PR0302CA0005.apcprd03.prod.outlook.com (2603:1096:202::15) To VI1PR0402MB2782.eurprd04.prod.outlook.com (2603:10a6:800:ad::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB2782; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2782; 3:zp8zAwJrGX1zl1LRFwHfq3O1n/1BqitEyg3IdhG+AjVW9KS9O8LNSHO9IH+nmUkYu+jVFYgLyc9eEDNVSchdaUXJWpT8OR8O7t3Dg7yhOtuv/k/y2UufF90ZFvU5u9bJXuaPx6XddrUnVEs/2/RkcTLO3vDEcU7YMokdul1SLN2B2TeBixr2FDx9k/RlLzQufFE/jw81xO3Etet1LxEHTZ8kdWyT9tRofn+tkFBdXyslFCXK5UmY0Xs9XqzFFOLz; 25:sCeRzcX3Rj4f9FIbyRtkdHvmZHXY2h1+5ajYC0Z7LFeofEt7CCrEgunMVO4yYGMYaP8+qh5yv1WA7k1BpgZP+Re1hcJL2/v+iTXeYbS9IBxpS6kJu8pIuBl/veR8bU57r8b13t8QTmS9h92auQhfnzbBPGlgCIQgkO/AxzN7eX96wgRfTRQPFv++wXwX4cgy9RxcKLej/kBqq94V99FttVBjOIk7lIkoSAprK7bm24EyKP3p9DSxq9Y9AlW9EXk02Ojy1VNBCcFclDzGLXosw92rG5JnO2ctMRW3ZyjHI+BSTlGSdjRw4s4OZlozD2cpkrCBuWJ44MqKnsNIBJz9LA==; 31:D4zZKtyXqk7mubNdQK6mQgkuO3zoQTAHTOMadD5URHgD223MVHYWuIztY9idkGtcqhnV7XwLGHJi7S57WSBZVq4t9Is6Wd1gdyVT9f1h0FxZJ23Bi1JttOCs0sIwAVsNGTIwo7sZoi4FVCqpSDjD+rIinWCtroLHSx9SkZJ+U1S5d+OUd0W4MjKEeoydjZWdUbmm87Q2fNQXCvqOP0uyumpFKhHvkIH/wOtlRFwZ5Mo= X-MS-TrafficTypeDiagnostic: VI1PR0402MB2782: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2782; 20:TyYjW+Ety6L4HOCyXUYe9bXY08mLKtREYWLl7ZGQDfHZxO7NMQWylmsNOYKZJQgHFCNNy4KYmIwCSsZQOvcVWYYB4kNCYKkexq0+iMfQWpBqxRjitXae41s1ayJFAQJoZ/QEXMwcqMlFnxtL1AG1kp2ZFr42PdCPvx9utBYcj/O4FHc8oW4ZoslutS+gW8RW2skkKZdohwYxbffRazldqF/eNWbRzqv77xrtevuqdaWrg7HXyqDtiQEqPY1A2I/04gNrOKEPSehPNq8PTwjSEk0suIIlYkLseVGVxAuurM+2nf2MOyzthz9vXMBfBy/ErhxgRU/WqaZ8i9cwDrg3AXGfgZBEqkuYEkHsQVEUew6nkHsXJ+f1MOvH8RMfYlAMCKkXTx0Z7jVIMRIMj/xS8upaFvanlWMm56BxiE28dop/u+wJb2BlXaM4s2ZJL2mRSi8HYtQZDgr0oLYclh3csfNsdrsoOTQrS4uvtMZqEcKZMmxKX+LqBcs0yKnNfnYW; 4:bHPstMtfXDh/SbUjwYgJBEZMhkx+to6UaIYG3RZgoBcLT1b4EWi3cHJVsfH8ZWavSXviRbuaDWpwCfiL/DZlpWghaeXn+bGEPI7Z4R761rnGLZAlTbiWZYOprKoCSRHYB1SudnwNiaAF8JNV9yjICA+Q5/+1SoIRKPvU0wn39+il4qu1d57mnkIKZun2qUvDOYiBPkdrHYFqC90m950lGiMex5cUjeQmS6f7FvJmGFsQQnBfWAoGxmX52aiVtsEdRdNWyAsjzUGJnmJRQVSRNLgkLcniNTNub4B/QoYzOggOXaft8uFfcpHj0THaNzIF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR0402MB2782; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB2782; X-Forefront-PRVS: 0667289FF8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39380400002)(376002)(366004)(39860400002)(189003)(199004)(5009440100003)(66066001)(47776003)(50466002)(3846002)(6116002)(97736004)(25786009)(48376002)(1076002)(305945005)(8936002)(50226002)(7736002)(105586002)(4326008)(68736007)(106356001)(2361001)(53936002)(6512007)(478600001)(81166006)(2616005)(51416003)(476003)(52116002)(44832011)(6666003)(486006)(55236004)(6916009)(86362001)(956004)(16586007)(26005)(316002)(36756003)(186003)(386003)(6506007)(2906002)(6486002)(8676002)(81156014)(16526019)(5660300001)(2351001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB2782; H:Tophie.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0402MB2782; 23:6vWgOur8XTPsKdSvPf9wwukTyvHBRJeCpdSP/mg?= =?us-ascii?Q?LYa0EZ+/39HMG2oPsZgZFX3Di2ZpO1fciulSdaVfXLtQt6EOvOlxdAk7KKZX?= =?us-ascii?Q?cCvoLX+edELhxiQ4gQMrPstFjXF4shnXtR5MX8kuhudlLTl3jzuvNOVyJctb?= =?us-ascii?Q?zf+UQPKSo7TxAJkoTGZKLtPrD9PeQBFvAPQby98amahaiPhpKgFDMpkzd8M7?= =?us-ascii?Q?mg2TRa/AbAHjQ8bmE7yjL3J+aI+ciGI5R6yZ2SkGjEndst9+KD2dCJ5CDBQQ?= =?us-ascii?Q?ABWspG21RbXnn3e1EYrkr9pJy/44grWFgYHI53e8UiAx0H+lWlVzE2OOCAAY?= =?us-ascii?Q?qC8JO3rMKNgwTcXrV1o7PzvyAnLheUFzo8r9hmPpUif27HBIr+99UlGuNFlH?= =?us-ascii?Q?1nDefGNxyqnYm3pdKkH5DP5NgJBYdXVbLE6wZeNwAFp2ABKC4zd+ujEfa83W?= =?us-ascii?Q?ntHMACnZ7T7j3WXFppC50Ht+WA54YxO0cKVVpqauCv7hk/gQ4MRfiEU6lVNd?= =?us-ascii?Q?8agxP0MwfIOJU1vrqrFSqs89QMW4xkKJjNYBau61ESkio7ixHkquefdDLoNb?= =?us-ascii?Q?9Y+/Ml2IfPmpLJAhhLX6lYG6E/rEeuk6/298J67U75NHN6UEcphu6zTZS01n?= =?us-ascii?Q?WBiKYClznrylbQykwzntCfT94pXqWwDLEHrxjc3F0a9aRci8WUnPkeOD0aCN?= =?us-ascii?Q?1+XY9uPuIGIiTiQ13y2y2fBmJObVZEc3sRRPvdysiEKXwphY1knqlBj7JGLp?= =?us-ascii?Q?pnEekvCrp9zJOK7nxDjZ4NvafrPtt7cqnjnTSOTYNDoPyO1NPKDY5WB9v3K8?= =?us-ascii?Q?lV9iwSOkSBaQecfqNY3PACvBV2mfvn4QGR5B6U0hAFNayL96jSXZ1dYVM8rW?= =?us-ascii?Q?Uw+nd4ryso4QtFYCwtG9DtQh7jb9olaBvsVxa6/4DLoEdzrp5+U6R+/A/zAE?= =?us-ascii?Q?bhR7pK1E4KWDDvTmO9gQ9/3W1EpX4dakXWkLLF4mFYi0I7V+8QkkDRjztFiU?= =?us-ascii?Q?XeFNwb+395Tixsfz+NdP3JhFREZnDZ+/lGawv33w9PO/1UYbDyYD0RlwQrqs?= =?us-ascii?Q?mozn0ocLl3YWN0UqRAWE+vXLl3FC9C7xqHAg+oTisxfC3ROJ7TwyUf+5QKoX?= =?us-ascii?Q?UpoWedb02YYNK8Ahjwemg+JmJ1S8uwgO/TTvodVBHb+RkbiUHUHYo4tEijps?= =?us-ascii?Q?sWFBvm+41ew/5UnCGhG4qfuab5vUTn1RZs/icKzhtzVSukvN/jvY4hSqZQ9K?= =?us-ascii?Q?BOJPwBewn+64B9/FId3SwTLWPjdeWCFMp+y8bUeop?= X-Microsoft-Antispam-Message-Info: po7f5pKoO5ws3JbLs8ogZBGLpiWFQBkQwZau6IrORsd8zSnI9vf2vx5DqkNcTAx9Vvyl7H5Au8nded+B5xhyMnRAms3No6NJklW8jQqZ/T8olB/mwv3PU9YaaUaWyr/IGkZD30wcH6cGvbFrSGa+xIAh170jajjKaFfz4q6XZ+hwJM5cLh8NOG1E7/lktuoS X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2782; 6:J8L/0HX4xNjfjwmgBvvHsSaXZz1lZSJDdBQ59Eop7jSmZ0SF12UJKI5xTbkqhIStRgwFERl6IK4Rhl/F9xcfNyKNtzmtAwv5wBPGOINKT+hjqBP/KzQ0Gp8341mji4+KKX3AW20kCGsRVjgH1XvECffAr8OnjTtQmauv6SSCj2hTwKw/wjdXMvNBcIPVQ1XBSFtEMA0G/7hx4gNFOBATBmnJ/aU5HUu6d5pERAriEu8CUTRiUP8L1GatbTSTHVFSmE02odZc3ebFTw3ck0MrAvGqgG6TmLozk5T2xx5rzoGdP6buAhs1HnRvQHey4Y/GLk+JIfNyYESgzc/VsFUPiXPMfrg//nn7UduX9xmAvCVjfYWJaJxl5Q/LIeSW4/oHyO51HLbE3qgaY34P05eGkHWLc+J8w4Et6ZnJrTkZph8vMg4uoo1MdjG7bQ49BTDZGYQ+iyrWk+8CuU9HztHS/g==; 5:1eX4LpEaRPA+fWvxpWxcA5p0JtwlOA/GIt7rEyB+nD1EyzHW0s7nrYA2BnTVTmHs8timA9OXAc3iGNuj4gBvDQC893TOUS0pVT2fC7ZXygt7GcZfClpWSzkpkD7IhTNfD/IV8FgyUO4x2ry+SkdHjvyu8VpBdTeuYD0qBFhl3Ro=; 24:n11r7p7eNTbEDqtqkEUolnUvY53M9MV2qnt+kIYcyGlZjq6g+14PiVOJfJDvdaR/OQCvdggwU7IlFP7+ffvWdMun55QgG+Pvv5fe2t9qFvs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2782; 7:MuE8bmnalcBKG1cX5YrWrHZaP5c/VHJp3QHmiF7vjmsi/6T2Tg30WaNasjnq5L3MjuWPLX5/jL91BuVChEPK4ZUJzrvLDdAsMyhjrVBjdZb56M/6xh7ZyXPsumg/+8Ay+r/Z+eja3KbPKUYY1WFzF99SeFRJvnIyFA5YOaPPfJzIc22lL7gg9AlSF7XCiunKJR0Sud1O68JOztnAQRO4k0ZMFCw9TXPc6DucPr8g/QeA73BOYhwwl/psAz9+OMkD X-MS-Office365-Filtering-Correlation-Id: 5501ea8e-f98e-4950-3eb8-08d5b58be423 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2018 09:04:35.5389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5501ea8e-f98e-4950-3eb8-08d5b58be423 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2782 Subject: [dpdk-dev] [PATCH 1/2] event/dpaa2: remove check on return value from epoll wait X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 09:04:39 -0000 From: Nipun Gupta Driver shouldn't take decision on signals received. The return from epoll was blocking on EINTR which is not the right use-case. Fixes: 36d87bb92230 ("event/dpaa2: handle timeout using interrupts in dequeue") Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 0199d66cb..08388c7bc 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -154,26 +154,12 @@ dpaa2_eventdev_enqueue(void *port, const struct rte_event *ev) static void dpaa2_eventdev_dequeue_wait(uint64_t timeout_ticks) { struct epoll_event epoll_ev; - int ret, i = 0; qbman_swp_interrupt_clear_status(DPAA2_PER_LCORE_PORTAL, QBMAN_SWP_INTERRUPT_DQRI); -RETRY: - ret = epoll_wait(DPAA2_PER_LCORE_DPIO->epoll_fd, + epoll_wait(DPAA2_PER_LCORE_DPIO->epoll_fd, &epoll_ev, 1, timeout_ticks); - if (ret < 1) { - /* sometimes due to some spurious interrupts epoll_wait fails - * with errno EINTR. so here we are retrying epoll_wait in such - * case to avoid the problem. - */ - if (errno == EINTR) { - DPAA2_EVENTDEV_DEBUG("epoll_wait fails"); - if (i++ > 10) - DPAA2_EVENTDEV_DEBUG("Dequeue burst Failed"); - goto RETRY; - } - } } static void dpaa2_eventdev_process_parallel(struct qbman_swp *swp, -- 2.17.0