From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C89D8AABE for ; Wed, 9 May 2018 11:43:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 68F5E21846; Wed, 9 May 2018 05:43:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 05:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=PdsMsbgA4YT37W L4cEK+KdGHm7PIJAe0rU8TpqW6Rxk=; b=BNLXqKzLpUeVJ6wLko+0nEEdUfVDoY MeM3Rve6O8ewnSq1pmkDHrVS7S7ohlt3CxTTbWVwUeFWt/2Jn7ylND70arAmHpJo /NS4RLVICBn3h7+QnTKuuDL7/2O0rIMqB+Hs2Wa8KCIyhJmSx1swr95zWq9oHFiz doQQX4szL3g3U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=PdsMsbgA4YT37WL4cEK+KdGHm7PIJAe0rU8TpqW6Rxk=; b=Jl8VTXab ENz8r+GBZnPvH/Wwvr377HqEAAZ+TDKpi43b2fGCpcBTTZ2zLPJ1eHm/8YCWjOL8 jTFbV1UIaLHHcQjNIPcMujfEZATIWSe5FuaVECXQOePJDHvW2P4cLy3sUT5XpcqX mCwLdDbynAmlj2H33uqjckWYL/YVgDHN21C9srETf5BcSyLGM3YhRevpccMufm1r 6Im3x0h9A1SpjHvQzi8HR5rC3RLQZD/dFmC+0q6Sm/pOb5QKfZ0Dgu/RhkmWw9ZC sSifJUL6DZxFsJ80Hjie8R/NFIfs0dqcD1wW3nPWiiIp1CNqgyg42K9ak/kWkhDK B82Y4xcqY8/3hw== X-ME-Sender: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D6E54E4EEF for ; Wed, 9 May 2018 05:43:46 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Date: Wed, 9 May 2018 11:43:29 +0200 Message-Id: <20180509094337.26112-4-thomas@monjalon.net> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180509094337.26112-1-thomas@monjalon.net> References: <20180509094337.26112-1-thomas@monjalon.net> Subject: [dpdk-dev] [PATCH 03/11] ethdev: add doxygen comments for each state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 09:43:48 -0000 The enum rte_eth_dev_state was not properly documented. Its values did not appear in the doxygen output, and may be misunderstood. The state RTE_ETH_DEV_DEFERRED has no interest anymore since the ownership mechanism brings a more flexible categorization. This state could be removed later. Fixes: d52268a8b24b ("ethdev: expose device states") Fixes: cb894d99eceb ("ethdev: add deferred intermediate device state") Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Fixes: 7106edc12380 ("ethdev: add devop to check removal status") Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad --- lib/librte_ethdev/rte_ethdev.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 7ccf4bae6..2271337dc 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -1269,12 +1269,16 @@ typedef uint16_t (*rte_tx_callback_fn)(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[], uint16_t nb_pkts, void *user_param); /** - * A set of values to describe the possible states of an eth device. + * Possible states of an ethdev port. */ enum rte_eth_dev_state { + /** Device is unused before being probed. */ RTE_ETH_DEV_UNUSED = 0, + /** Device is attached when allocated in probing. */ RTE_ETH_DEV_ATTACHED, + /** The deferred state is useless and replaced by ownership. */ RTE_ETH_DEV_DEFERRED, + /** Device is in removed state when plug-out is detected. */ RTE_ETH_DEV_REMOVED, }; -- 2.16.2