From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 96984AAEA for ; Wed, 9 May 2018 14:00:27 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id v60-v6so35384796wrc.7 for ; Wed, 09 May 2018 05:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=yJfU7pcsNPnJ/2bJUxmtRqVIppzXac362JMBJAyMY5Y=; b=BAwThvOsyrQQHnLGYhHcKegZrHI4D88GEjU14tk9E+d+4mO7+pVc5AfefbCasT026/ AeaEWfL/rtox0SSDE+Xd8UrLYxVbAVyJTHDlv7RYT/n6Ifau+Mgn/pKt8bG3cc/YMUq7 RUcL3eMojXlHwFLyrAlYfckq7Lz5M1qBeC/aPm4WDjJYKzF4ZFV4xVupQQEBebbfxOKm zUEiFoiBEEIUCHOUldcWTR/1RDd0qpZ2+9pDltbBSnbNMBhQeY5HqGTkih6E2+xcHxq2 YCpKTDEnMQgn1GPMcts6hZasMnfcejxvyMBsFadYdaQYC/ZJOiL9ASSnE0blEfWiH9Io 0jqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=yJfU7pcsNPnJ/2bJUxmtRqVIppzXac362JMBJAyMY5Y=; b=k3vMjbbo6fLVscDeLwCvJlJUVVD9wfr0vblhDm2RcCoLqiDov4O6V5KmNmZLLp0Qrp h4MqmLPrXlLbfYrSYEf050iln4RhNPVLmWisNEC88Hdjxjf79OSxolHY3cMzKW8QFIQo rwi8dMnHD4ReUDtzq6zmKdfXaP54w1R9bI1OFlBEK4FlZr38rcoyqnP7MKeukBFA36+l FvlX6ATyo8BsUAromBvuG4ADxu7ot3biSYS0FnTYbTD2NbSr/3f+qy+iEvSguNNL90YA 4PnsyFnCUZvA6kr5GV68hA5mIEG+E3Yx2SCj4iHRjY75cZcH8dYrcX4S+XibEE2Hp41X 9yPQ== X-Gm-Message-State: ALQs6tDTrNnJVWQ92GYP+tkt+8H9gRdyUZPaWFgNIm56xcqAvPz23Emj mw9ooDfjuQU6gHFrfcGYbuwCPw== X-Google-Smtp-Source: AB8JxZphty3cqYxnukZ5DWujPmululuJVlWQ2jNO2AKFh2JVZvZnsGq77Jp0EYMlsCmx468s+s8IaQ== X-Received: by 2002:adf:a0fd:: with SMTP id n58-v6mr34167208wrn.217.1525867227059; Wed, 09 May 2018 05:00:27 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g78sm15591447wmc.27.2018.05.09.05.00.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 05:00:26 -0700 (PDT) Date: Wed, 9 May 2018 14:00:11 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ophir Munk Cc: dev@dpdk.org, Thomas Monjalon , Olga Shern , Shahaf Shuler Message-ID: <20180509120011.oyftrzgm74tmbwhk@bidouze.vm.6wind.com> References: <1525802561-9011-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1525802561-9011-1-git-send-email-ophirmu@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v1] net/failsafe: report on supported RSS functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 12:00:27 -0000 Hi Ophir, The commit title could read: net/failsafe: advertize supported RSS functions Some nitpicks in the commit log: On Tue, May 08, 2018 at 06:02:41PM +0000, Ophir Munk wrote: > Report on failsafe supported RSS functions as part of dev_infos_get ^^^^^^^^^ Advertize > callback. Set failsafe default RSS hash functions to be: ETH_RSS_IP, > ETH_RSS_UDP and ETH_RSS_TCP. ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ Better on its own line: ETH_RSS_IP, ETH_RSS_UDP, and ETH_RSS_TCP. > The net result of failsafe RSS hash functions is the logical AND of ^^^ should be removed > the RSS hash functions among all failsafe sub_devices and failsafe own > defaults. > > Previous to this commit RSS support was reported as none. Since the > introduction of [1] it is required that all RSS configurations will be ^^^^ should be removed > verified. > > [1] commit 8863a1fbfc66 ("ethdev: add supported hash function check") > > Signed-off-by: Ophir Munk > --- > drivers/net/failsafe/failsafe_ops.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c > index 6d44884..d18b793 100644 > --- a/drivers/net/failsafe/failsafe_ops.c > +++ b/drivers/net/failsafe/failsafe_ops.c > @@ -83,7 +83,10 @@ static struct rte_eth_dev_info default_infos = { > DEV_TX_OFFLOAD_UDP_CKSUM | > DEV_TX_OFFLOAD_TCP_CKSUM | > DEV_TX_OFFLOAD_TCP_TSO, > - .flow_type_rss_offloads = 0x0, > + .flow_type_rss_offloads = > + ETH_RSS_IP | > + ETH_RSS_UDP | > + ETH_RSS_TCP, > }; > > static int > @@ -805,26 +808,29 @@ fs_dev_infos_get(struct rte_eth_dev *dev, > } else { > uint64_t rx_offload_capa; > uint64_t rxq_offload_capa; > + uint64_t rss_offloads_hf; The name would read better as rss_hf_offload_capa. rss_hash_function_offload_capa is easier to understand than rss_offloads_hash_function. > > rx_offload_capa = default_infos.rx_offload_capa; > rxq_offload_capa = default_infos.rx_queue_offload_capa; > + rss_offloads_hf = default_infos.flow_type_rss_offloads; > FOREACH_SUBDEV_STATE(sdev, i, dev, DEV_PROBED) { > rte_eth_dev_info_get(PORT_ID(sdev), > &PRIV(dev)->infos); > rx_offload_capa &= PRIV(dev)->infos.rx_offload_capa; > rxq_offload_capa &= > PRIV(dev)->infos.rx_queue_offload_capa; > + rss_offloads_hf &= > + PRIV(dev)->infos.flow_type_rss_offloads; > } > sdev = TX_SUBDEV(dev); > rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos); > PRIV(dev)->infos.rx_offload_capa = rx_offload_capa; > PRIV(dev)->infos.rx_queue_offload_capa = rxq_offload_capa; > + PRIV(dev)->infos.flow_type_rss_offloads = rss_offloads_hf; > PRIV(dev)->infos.tx_offload_capa &= > default_infos.tx_offload_capa; > PRIV(dev)->infos.tx_queue_offload_capa &= > default_infos.tx_queue_offload_capa; > - PRIV(dev)->infos.flow_type_rss_offloads &= > - default_infos.flow_type_rss_offloads; > } > rte_memcpy(infos, &PRIV(dev)->infos, sizeof(*infos)); > } > -- > 2.7.4 > With those nitpicks fixed, Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND