From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 200497CB8 for ; Wed, 9 May 2018 14:13:36 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id y189-v6so9174119wmc.3 for ; Wed, 09 May 2018 05:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=s3IWblVVor0ALLQpWbju5i9oErmeT7TM7fgZ/sTIa+0=; b=w7VgWFd0pcc4qou0nn54HaJ0uHLarsaeZizK9M8JcuwRSW9LW7pljinQdfGzVgRgPl sDmFZZlhH/mMtsj6GgDH74s2jTxXcqxpGzR24IvXrdGefVXz8P+cfV7iek92u0FrYqGp Hc8KiqMwFAZyMUT6HEyL21krc/Tv017NjheiE4tqAtK2h6VYpqzPTzAumLZYnAkfhu6I Un4uMBD5dJUOkzjv5G/ysTY2X/4iyH8KBtNKBDSDS58beM34ezOS5dH12S8qi8wf8o6X 4Mtfa1DJFTfkDEjJbbFJeadEv8Uf3VhCtEDmu1EcGUACTGLYZdKy3Hfgklj8vwd4HIEo dOXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=s3IWblVVor0ALLQpWbju5i9oErmeT7TM7fgZ/sTIa+0=; b=k88m+VsHE5HcguFE9IBsKnfSqQyvarTRFDkYZy0v0aY+kxdZv3Hd7vUloRht0q+jV0 YSTNdrsd3UI6ety2YbpZbY6Cskn7wD3RFhHDFJONEoN6Rn9Q+jHmmvoFZSV7lfZ1zoLp zbd8v+lpplfuqmqb/Mw1fMmTWKF2Dc5+88rlhBcwwiwN07rDo2h6/QdmeJkqEqmDvxkH JzTxMUbCTMvZGNm0/PzMYBGevvnpaeJPltH1jm1ozLAGLMOVRy6wtJdjA/0ylXImjbwv oFX8XVHbsZ89P0WCqZmo3hP3sOGUu542a8jrVzaUM8/nBkNtLwZcumTW9luXq4kYhvKP oh9w== X-Gm-Message-State: ALQs6tDl81GFCwhbMP621KFx1fu0tOm+NQ5TOTtmcZK2QD4tu2nJpllX q5x032AAqku5hQWGp/sRsHHrtzra X-Google-Smtp-Source: AB8JxZqIoG5/cRSnt17IEnyRUuCIq7A7SNEzFnMZYHD20zG2IWDu/oRRWswNUZRDtL3daNOeS1hJ8A== X-Received: by 2002:a50:d514:: with SMTP id u20-v6mr45891828edi.73.1525868015865; Wed, 09 May 2018 05:13:35 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k17-v6sm12273889ede.96.2018.05.09.05.13.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 05:13:35 -0700 (PDT) Date: Wed, 9 May 2018 14:13:20 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20180509121320.qpoixqsoxtlcjyak@bidouze.vm.6wind.com> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509094337.26112-3-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180509094337.26112-3-thomas@monjalon.net> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 02/11] net/failsafe: fix sub-device visibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 12:13:36 -0000 I think this patch should be swapped with the next commit "ethdev: add doxygen comments for each state", While the comment about "DEFERRED" would be edited in this one to become: /** The deferred state is deprecated and replaced by ownership. */ ^^^^^^^^^^ Otherwise I agree that the device state is not to be used anymore. On Wed, May 09, 2018 at 11:43:28AM +0200, Thomas Monjalon wrote: > The iterator function rte_eth_find_next_owned_by(), used by the > iterator macro RTE_ETH_FOREACH_DEV_OWNED_BY, are ignoring the devices > which are neither ATTACHED nor REMOVED. Thus sub-devices, having > the state DEFERRED, cannot be seen with the ethdev iterator. > The state RTE_ETH_DEV_DEFERRED can be replaced by > RTE_ETH_DEV_ATTACHED + owner. > > Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon > Acked-by: Matan Azrad Acked-by: Gaetan Rivet > --- > drivers/net/failsafe/failsafe_eal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c > index ee89236f1..ce767703f 100644 > --- a/drivers/net/failsafe/failsafe_eal.c > +++ b/drivers/net/failsafe/failsafe_eal.c > @@ -98,7 +98,6 @@ fs_bus_init(struct rte_eth_dev *dev) > SUB_ID(sdev) = i; > sdev->fs_dev = dev; > sdev->dev = ETH(sdev)->device; > - ETH(sdev)->state = RTE_ETH_DEV_DEFERRED; > sdev->state = DEV_PROBED; > } > return 0; > -- > 2.16.2 > -- Gaëtan Rivet 6WIND