From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1A9931B77C for ; Thu, 10 May 2018 00:43:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A66882281B; Wed, 9 May 2018 18:43:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 18:43:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=y87gRPcB482+jL WTsGvI1dMCClpvEKmMabcLcaHAvUQ=; b=bdcbdGLQUiwkqZwxxOajx4cOIGPWqk Ckx+VfigBgnWc0aM4bC0OtK2XEDRvsgh71/92ipQQ8IjahLUd4QPI437Grkq0fPh XNgc0vy9+W3o5l94uIWzZhFUiuKNoGpNo/2uCF0V9X9TTFqUaeuPQOpUNAb9m2+1 sGNUyJk1P6cls= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=y87gRPcB482+jLWTsGvI1dMCClpvEKmMabcLcaHAvUQ=; b=LF5LNwO7 PwTkbu0adp8fwcui/ZSk3x17N+j8ngEgAUdspL5XQxzXSa/bUlUcj8OHTRkwHUeZ T/uMTADrZSxoBlqkJjrAeCoQBQQhIeBdcNAv6U6+Br5fqiZ62j3IWzlHrX1UAZTp 5Ehz2MNGgqqgI9HWmJ52e0tAoxzdRNAtXVvWO5jUrBp+U3LGOuWbHloSq/Q9xKXV h5eZTfOpg0uuhXljXCrvUfzim5+oU0VGY/n2k2s/ysWrupeCxkPQCbz3MECyt8zp OdZTE9cq5pdPXtv1YEnfXHH1VJ2z+fVymYNhAyrNQ9995F9oGz7UmeQ/tlu+Vhi5 y2dLOUpwgmMq/g== X-ME-Sender: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0F3B7E4EEF for ; Wed, 9 May 2018 18:43:22 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Date: Thu, 10 May 2018 00:43:04 +0200 Message-Id: <20180509224313.27289-3-thomas@monjalon.net> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180509224313.27289-1-thomas@monjalon.net> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509224313.27289-1-thomas@monjalon.net> Subject: [dpdk-dev] [PATCH v2 02/11] net/failsafe: fix sub-device visibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 22:43:24 -0000 The iterator function rte_eth_find_next_owned_by(), used by the iterator macro RTE_ETH_FOREACH_DEV_OWNED_BY, are ignoring the devices which are neither ATTACHED nor REMOVED. Thus sub-devices, having the state DEFERRED, cannot be seen with the ethdev iterator. The state RTE_ETH_DEV_DEFERRED can be replaced by RTE_ETH_DEV_ATTACHED + owner. Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_eal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_eal.c b/drivers/net/failsafe/failsafe_eal.c index ee89236f1..ce767703f 100644 --- a/drivers/net/failsafe/failsafe_eal.c +++ b/drivers/net/failsafe/failsafe_eal.c @@ -98,7 +98,6 @@ fs_bus_init(struct rte_eth_dev *dev) SUB_ID(sdev) = i; sdev->fs_dev = dev; sdev->dev = ETH(sdev)->device; - ETH(sdev)->state = RTE_ETH_DEV_DEFERRED; sdev->state = DEV_PROBED; } return 0; -- 2.16.2