From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id DF3F91B795 for ; Thu, 10 May 2018 00:43:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 397DD20D0E; Wed, 9 May 2018 18:43:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 18:43:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=QpePYP8oamr6iE jOj2NtR6cbzjmakCwsceWefmfdmRY=; b=lk/A2xKW9ORMmY7Ezk6KV3z95CNaOC pPun0SwwbY2vLJmkYkIU8znu97IfscruHIdTrRIU6oAJChlIotP3vh4BVIfKcAxF aIxUm53EVkLyph2BsbnREV9plOQbOXaT5GzUTPHm4XgGEL2Gs/DW3gpimDM9Yc7w zz3nK3pD/4+nQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=QpePYP8oamr6iEjOj2NtR6cbzjmakCwsceWefmfdmRY=; b=iXwi2eGk M+eBkMivN8/iPEKbA2L+4qOj/dnLnsRnkuTaQ4wBAAvArMtL8HkAAiugrI2TTlWL vDVzunRbSLbUzoR7RpCgaWbXcF9e43UOywYnjFL7ITw0rTmi8mh3wf7IL8b3oaSE patz/ajfYYpIfs1H6XlYTbGi5EzYvW0SfBiC5kErrGMhlEviSPgKhF7b8F3ykrCT adFH3JazxbC+Uy7zQz8tL4iN0RNKoRsTEEn5TgxFR0IJfqqagubO/FV+5jSOHgrq dpAj032n/AmivT/YPCVXv0RWLDzhOb1s/TcCKO9GuAzX1R5xv/QJ/GBzPJ1P4YXj FJ21/JN4SrwTrQ== X-ME-Sender: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AA83EE46C1 for ; Wed, 9 May 2018 18:43:23 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Date: Thu, 10 May 2018 00:43:05 +0200 Message-Id: <20180509224313.27289-4-thomas@monjalon.net> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180509224313.27289-1-thomas@monjalon.net> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509224313.27289-1-thomas@monjalon.net> Subject: [dpdk-dev] [PATCH v2 03/11] ethdev: add doxygen comments for each state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 22:43:25 -0000 The enum rte_eth_dev_state was not properly documented. Its values did not appear in the doxygen output, and may be misunderstood. The state RTE_ETH_DEV_DEFERRED has no interest anymore since the ownership mechanism brings a more flexible categorization. This state could be removed later. Fixes: d52268a8b24b ("ethdev: expose device states") Fixes: cb894d99eceb ("ethdev: add deferred intermediate device state") Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Fixes: 7106edc12380 ("ethdev: add devop to check removal status") Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 7ccf4bae6..2271337dc 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -1269,12 +1269,16 @@ typedef uint16_t (*rte_tx_callback_fn)(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[], uint16_t nb_pkts, void *user_param); /** - * A set of values to describe the possible states of an eth device. + * Possible states of an ethdev port. */ enum rte_eth_dev_state { + /** Device is unused before being probed. */ RTE_ETH_DEV_UNUSED = 0, + /** Device is attached when allocated in probing. */ RTE_ETH_DEV_ATTACHED, + /** The deferred state is useless and replaced by ownership. */ RTE_ETH_DEV_DEFERRED, + /** Device is in removed state when plug-out is detected. */ RTE_ETH_DEV_REMOVED, }; -- 2.16.2