From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0087.outbound.protection.outlook.com [104.47.33.87]) by dpdk.org (Postfix) with ESMTP id 652DF1B85E for <dev@dpdk.org>; Thu, 10 May 2018 13:58:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rRv2MRLDzHiI3qI/h+/S8JwzphagST/ueWwRpxmgBcM=; b=D1SQNIguaqpPhTlu+6l+2imGIBhdEygyIDLwpd6KJ0VkeBR+vqZIQEsq80rjbKUuFOQI0wxKdc0szFSymmOfgNaQkEDj5smAqx10guMrZUeH4d7mYj7lDLtQgzItzCiDA8PEbyUrLvKfPp3xOPt2GJLAgnA17AWTqgKLbSxNqH4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by CY1PR07MB2522.namprd07.prod.outlook.com (2a01:111:e400:c636::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Thu, 10 May 2018 11:58:18 +0000 Date: Thu, 10 May 2018 17:28:00 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: Andy Green <andy@warmcat.com> Cc: dev@dpdk.org Message-ID: <20180510115759.GA8776@jerin> References: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> <20180510061731.GB12718@jerin> <add7a665-6a7e-89be-fa87-f20a64a46983@warmcat.com> <20180510091147.GA26838@jerin> <cfca21bb-9a2c-e57e-7eed-0049b56e9a2d@warmcat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cfca21bb-9a2c-e57e-7eed-0049b56e9a2d@warmcat.com> User-Agent: Mutt/1.9.5 (2018-04-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::29) To CY1PR07MB2522.namprd07.prod.outlook.com (2a01:111:e400:c636::13) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 3:fhfIADt4pzIjCJ7N3Uhi9zmgd+ZcEg1IzVHEIeWdGhp7RF96oOdXTbh98ziute6ILlYPGtJHXcdZfN++3+owW6GCoxHPNPBtwX1dLsbixR28P5OU55RXeyAI7c9i0JqraCsEt+F6POn1ROsT3PTokI1dyDkl5h81TGAimydvvpjvmXEbHrUL9XisNEgR1gpP5RLUmjHV8D8PcJuQowJDqHAj5kcKVUQo9ITA5ijDLyxjEMqCpe3st1zUKQIu40/Q; 25:Gsco3UVV07y9rW/tIXEliIgcDfVEbgXHO//p7gIpLQl3FqX8Un+d8PthtxhEUMzTI0QFH06FRbiQQ9+t/472QmFgzJZUt5rtwq3q441lkL/7hxpHr6r0N+6BWjREFPtp6u4KCPPykmnfLTFrSHWqxyVYUyFmGNznrtbWVBNcMLWdA+pI4CQAznZuXbaghVyiMBirWz5Nq4DhisnCHMNK0MsAmuCYbDdChWw0wn8zmsd7bwdppkVLo9I2Kxn91NHJ/Zum2fdjQRbxMI7lDtdQ742VNHCqhCJi7ENF/D+Cae/If9Uc1lHGDLVHYPjiqplwS1vrfwsDxt6ZkPndPW9HBQ==; 31:QVBVfrbBPRTJ1QTep+88KHjrPEvSUvkINDgawO5V1x9zb2A0KwPiLM/DtCb7G2XnYCb6KnvquZNnenh25ATu+qz351PTaBFr5SWoskb/gxB6lkV+NMwyrcsMV2s2N2gbPnKJR/Yil2JdakXwKn73oPe4eI5OsvZZ2VRDTi8OS/JEXWGAhHlaKxnskQ//cToH85IO2T3SWKhhP5Nd2PVsicB7cv51EUCV9P7iF62u7oI= X-MS-TrafficTypeDiagnostic: CY1PR07MB2522: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 20:WnqtHf8zI9XIKTlQHz0iXqKPT0E1mwIolMMwspILO60YCZxrXF7xK7HNmuiei8QD4q1MudzZ++cbYylysVSHxIfvu9tH1i0SrJL6krgh0fQSWbmUlQwQV3xvlqHPEd9Z+ROH/o8WeDb1dG4HK8BC2AsFGvyCBh+z5oQa19UHbq7/lX/3qLvQzUoyl9HmoR5oehCr6PnFeaYUxFy8Xsj4glNaxbSS5BvP7RSbRsokvsRFqZ6sKzHRHeBR2VD9msKkk4allSLyuqL2+xPGZvlurZyT2czHhi3F4MYaYrCsWADzeOcFJIwBKSDO+on/sUy6EdhGogGoqo81xCYBNTvi8OSl9bppg713OC1qTs64DvLdeV+vGkQgtHrHO19Ll4laFdQEwHhm/7SmkbAhJpQBs1BSUWAV0HudEJAPaYQcCjOdkUZDOufu0V8Vf6tnHaUQaDJaWn+XDfvrmtAlO/pebgkuQj/zrp4ANZ+Yxr9KdXWXULDfnqx7Aw9iX7RE+DH25+0NZvGzvNX7ZG0JtEcjn12BwDfOPKJXFORsg/HJIqA1CX0cSr/5tFCxLbH3YXupfWstntDRnXTgNiz0gRN1s1yJnbAt+Ix+WM6wlyMfWkM=; 4:tt5Mx94j+X5b9uah3TyKpT1xtWxf6zU3I/LXMiXYL7lLlxWD+tNqoJL1rMiZHr4i9OryHart8K3VYMfoeC1TLDZ6+8QoOQrsllLIqPhLOj0CbRNnuhYyTOFc0iDBi3Qub3shYFBGWMwl9jmImKc30o9uFZFg9QaQ/RzqwoTopcdxdQHmKplI+tgoPA5A5tVedK0t4M+L8EmezsZ5GleId9EqSE8tkOpQ1gzrtgVRsuOrTuio7sMx+CWXRnOLlE9sxl1PAw+dAAjsb9fEFNtPP2rDI+g8MRgRpcPEzEffFapu9TJOKGVzBTD2BxXxvxgS X-Microsoft-Antispam-PRVS: <CY1PR07MB25222C3E7FF7067067408874E3980@CY1PR07MB2522.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(5213294742642); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(3231254)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:CY1PR07MB2522; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2522; X-Forefront-PRVS: 066898046A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39860400002)(39380400002)(366004)(13464003)(199004)(189003)(16586007)(446003)(11346002)(53546011)(386003)(6246003)(956004)(186003)(9686003)(47776003)(33896004)(66066001)(16526019)(33716001)(316002)(6496006)(55016002)(52116002)(93886005)(7736002)(4326008)(55236004)(8676002)(305945005)(26005)(53936002)(42882007)(476003)(44832011)(81166006)(25786009)(97736004)(81156014)(486006)(478600001)(72206003)(3846002)(33656002)(229853002)(105586002)(23726003)(6916009)(106356001)(76176011)(68736007)(50466002)(6116002)(2906002)(1076002)(6666003)(5660300001)(8936002)(58126008)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2522; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2522; 23:YIxG7yzmUMxt4bqOdNHwjudpkhVVC2gaBpK8X+/h5?= =?us-ascii?Q?XCLxn7qPLwBRTznN/jswvdGZPZsPl7TpcSUFpLZinWErd/AC9MvT/FleIrla?= =?us-ascii?Q?zCkuqZkDE60Jx/z9rPRrnrQFsg6LiNRVNJqY99IWNbyHRxfJZnSeXzGceZNL?= =?us-ascii?Q?8lqt7TVSxhkY34zLMv02ENPcKwWbgzsPXi6ARTDfJxrdYvEfib38spBbmPTp?= =?us-ascii?Q?YHsoJXGLSC8Xi8TIUw3Sk1Xlh0RgFwVHOaTRsjjYMPy5VaQPAh4Om6k17MlA?= =?us-ascii?Q?7BvqboEqUc5ORWHGeByrUSKiAsmos59aE9a1NyrECsEnIJLmH8S5oVL7kdBp?= =?us-ascii?Q?d5+fWy5217FxDV3fNt8pLHrMnBJ0QUpTQl3DgB2wmOuHmrU6bmwaIk0m1LkD?= =?us-ascii?Q?XzmC+8zmie8kaWaF0mIGUBPWu8oJ0ThXNBJPwIC4n+Xh1/5t64EOdDAHAFDJ?= =?us-ascii?Q?UTfhKHPKj0n4duxYUWPFpfOMZeFExvEvGLGFTNamiFfX0ijIEgZ9CxLzSDaw?= =?us-ascii?Q?p2quX9UillSdsNSxCIp53uJKaih5KBGVAmjURgVyS+Red/FH+3w9749nLfaa?= =?us-ascii?Q?Z1FnifIZRQxCjD9yB6qmWSHAvyraFwbgO0sAf7ZfeIbExtQ0eLsnGpooE2Oy?= =?us-ascii?Q?xsUvrboNnQrk9WBfv2XFRYrkz2BzIpn8HQ8LWqCy04iNeCr1FQsQLcKvVPKH?= =?us-ascii?Q?eIzIx4BBJs0VtonLXCLTdVrN648xAgBU9ns9uxxIX1QPBU1YoeNcZbNqyoav?= =?us-ascii?Q?wjCppABGyp1DbwpPGYe2zfreFq6Wd5NMi4NtU+Wf7eTAY8A3Jel13UWsOQfg?= =?us-ascii?Q?rpPEq/YSMfHV+NWeCx4W57vvRxIaGNxQ+gKlDz/yxYBFNmqhgtCVbU/3llHi?= =?us-ascii?Q?fMJ/SsZ2TK7VuCSKddP8+FXaWhVV/ZJnJe5K1nsHImv7tICxbJEuBuO+UE9i?= =?us-ascii?Q?mFvCo1h+xrpkzMXK0xV+VojwSqrnlkZYDc1uRpDLDi+136BGp+QPbABDZeg7?= =?us-ascii?Q?E5hd4YpB3UFIYh3n7nkqe2VOmmo3WwkMMBu5gNjucRS5xm2gPoHXLwy8+vth?= =?us-ascii?Q?maXGiZseMqUHKL+CWf26bMTlGaHtJ0VrbQEXeqYIBq6t5bpxIRboP2BHr9oA?= =?us-ascii?Q?8zYCLsVb8eJfY0rFraWld53guBYZVI3yNel2oC1cqvHldO1I8XVNrKZ6Ak4A?= =?us-ascii?Q?bbhLJI2tNQmNQNo1yP++mEtm8Q19hGhRWlIXAGF21IjoAB0Ff0aXwwD7gyJT?= =?us-ascii?Q?HYrqTWBpkVqbPQxgDWlj9AR/B4dISQSToguHGp7vyssgFDZGiwCxL7Fwr5rt?= =?us-ascii?Q?0W5Bnf7YJtETFYoRx4nWkUbZPmi0VObc9P6LjvH07IPN4TnjABB6QOKHEQ3G?= =?us-ascii?Q?n2Z9xo5yE5n1eF8k3uhdBcpYVX4a7ndEgvM2NNaWq4J9vQv?= X-Microsoft-Antispam-Message-Info: T8SN4we6G9wKUNJtjJyobowy7nyXnWS5eYYIHEX8Efvnz9UsgbPKgLX/+F1Q7U3lFUzUZAQn/Kn/NuBVhdADWapha6HweDHgKAnXb2rUtggl2xCcwdAOwsi2ayZKtbxwOL/nXBwFkr/4e+yE24fREfivnIUkW+bQeZwDBs39SaDdeaFxDFN2KpSqOLkWVpty X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 6:BKB7QfWJ4mKSojy4HYLKVAayl6eu9TTq7jRyAnmRxgop+NSAAz+VfJNr89yofSF/zrbAypOMZOAH3UdZJpqD4BevIJJuci12DKa+MK7/PygB+AYHJJuMQVwlOIIHCr+XKmfyjECVGE0M7Kdb+6Zu+h42TFzBnX2tmy3pidRlOGgMwFAp3k6LkFdCyJvuoHbZt6RrPyYZIyztCuZTVceSIaaiIelJ3wZGGQ57PuwOO98n+drHamSdeCz1Yiz3nwKK8TX49Ra1BtuN9zIkdmMpceyZMBsze89Ttv7TsmyezkO0L3KTsnlhQRs6gZe1/qSHqupeeiYaL0JJd7irGr/LlSLgaXVBK+HdqNpfY27leJ94HfNkllkFH9bN1Wxo8bldocjTmp1cOj0hluWK5SPnJlYftrEPTWsI/OXBBSO/xlUCFVlTqTJ7USl2FwliIjk1qDCBdDHJGB45Bmrl7m7uBw==; 5:1Tyt5iy6+ZTuN/8dsPHeQNk0eksZYhf5cm6D2RDH9SRWQmqtI1MOkqUJLZyBZV78kkx77pmUk5ErhinkmXrBELIepJhEdjNl0coTukAuCgRG6NbXTrXkqAP5RiZZgU1FzeQRvIJGqN4Oox29v2CZN7rHUQGiJrl5jPs4bf/+eHg=; 24:k3UCMLNcWRFg7L0OWajKQ7dtfr1pLlt2fxaAqkZoUa1PeybCapm4bgQa+26sjNjKfdVY/AoV+1AVQLM3s0ZDWisim2XrcQNMNNg3GeQIPv0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 7:I4+T1TXK/aBLyVoY4JS2XeyCAf2I9eEv3bD4XJGRGm3JoLP31V2RYQ0ebTzpB676KeLaIUUIrxj7dNVdJPUMb0Aizz6PvCEuZdmZaH4a4hEVa99v8bQMXu90qhWDePyei2cY8F/6dAwhtcOzdMiC8yotXnUMnHKTvB1JlmZaW8F0HaAeFmeHkOJRvUa1FvEiciGEMetifxgTV3aPc/Fsmbv44L1EFpuigeV4A6Z0SMYGq8/tSCocvQtlYzQ7jcpl X-MS-Office365-Filtering-Correlation-Id: efb89181-abdc-4bf6-2e54-08d5b66d52e4 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2018 11:58:18.6325 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efb89181-abdc-4bf6-2e54-08d5b66d52e4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2522 Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 10 May 2018 11:58:23 -0000 -----Original Message----- > Date: Thu, 10 May 2018 19:44:34 +0800 > From: Andy Green <andy@warmcat.com> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > CC: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > Thunderbird/52.7.0 > > > > On 05/10/2018 05:11 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Thu, 10 May 2018 14:46:42 +0800 > > > From: Andy Green <andy@warmcat.com> > > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > CC: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs > > > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > > > Thunderbird/52.7.0 > > > > > > > > > > > > On 05/10/2018 02:17 PM, Jerin Jacob wrote: > > > > -----Original Message----- > > > > > Date: Thu, 10 May 2018 10:46:18 +0800 > > > > > From: Andy Green <andy@warmcat.com> > > > > > To: dev@dpdk.org > > > > > Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs > > > > > User-Agent: StGit/unknown-version > > > > > > > > > ./devtools/check-git-log.sh > > > > > > Ugh... > > > > > > Wrong headline format: > > > drivers/net/nfp: fix buffer overflow in fw_name > > > > > > ... snip something "wrong" about every patch title... > > > > > > It's just doing this > > > > > > # check headline format (spacing, no punctuation, no code) > > > bad=$(echo "$headlines" | grep --color=always \ > > > -e ' ' \ > > > -e '^ ' \ > > > -e ' $' \ > > > -e '\.$' \ > > > -e '[,;!?&|]' \ > > > -e ':.*_' \ > > > -e '^[^:]\+$' \ > > > -e ':[^ ]' \ > > > -e ' :' \ > > > | sed 's,^,\t,') > > > [ -z "$bad" ] || printf "Wrong headline format:\n$bad\n" > > > > > > It probably seems to whoever wrote it that adds "quality", but actually > > > inflexible rules like this do nothing to help quality of the patch payload > > > and actively put off contribution. > > > > > > So on this first one it's hitting the rule ':.*_', ie, this project believes > > > there should never be a patch title mentioning anything with an underscore > > > after a colon. > > > > > > Can you help me understand in what way banning mentioning relevant strings > > > in the patch title is a good idea? It's actively reducing the value of the > > > patch title, isn't it? > > > > I think, the underscore check is to make sure that the subject should not have > > C symbols. > > Right, that seems to be the intention. > > But if the patch is entirely about doing something to a specific C symbol or > function, it's not a bad thing if it mentions that in the title is it? In > itself, most projects would consider it a good thing to concisely explain > what it's doing. Eg, "fix NULL pointer exception in my_function if > unconfigured" is illegal for this project. It's strange actually. I think, the rational is # In subject you have minimal information # In commit log, you can have DETAILED info That translated to following in your example: module: fix a NULL pointer exception fix a NULL pointer exception in my_function if unconfigured due to so and so reason > > I don't understand what negative outcome the check is saving us from. If > nothing, maybe it should be patched to not do that any more. > > > Change to following will work: > > > > net/nfp: fix buffer overflow > > Sure, I studied the script to find out what its problem was. I just don't > think its problem is reasonable. > > If nobody cares, sure I will go through removing useful information from my > patch titles to keep this script happy. IMO, Keep all useful information in description not in subject. > > -Andy > > > > > > > -Andy