From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 301301BAD5; Thu, 10 May 2018 15:31:18 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2018 06:31:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,385,1520924400"; d="scan'208";a="198263911" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by orsmga004.jf.intel.com with SMTP; 10 May 2018 06:31:15 -0700 Received: by (sSMTP sendmail emulation); Thu, 10 May 2018 14:31:11 +0100 Date: Thu, 10 May 2018 14:31:11 +0100 From: Bruce Richardson To: Reshma Pattan Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20180510133110.GA27828@bricha3-MOBL.ger.corp.intel.com> References: <1525865729-16086-3-git-send-email-reshma.pattan@intel.com> <1525953944-11339-1-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1525953944-11339-1-git-send-email-reshma.pattan@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost_scsi: replace strncpy with strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 13:31:18 -0000 On Thu, May 10, 2018 at 01:05:44PM +0100, Reshma Pattan wrote: > Use strlcpy instead of strncpy. > > Fixes: db75c7af19 ("examples/vhost_scsi: introduce a new sample app") > CC: stable@dpdk.org > > Signed-off-by: Reshma Pattan > --- > v2: replace magic numbers with sizeof() wherever possible. > --- > examples/vhost_scsi/scsi.c | 14 +++++++++----- > examples/vhost_scsi/scsi_spec.h | 2 +- > 2 files changed, 10 insertions(+), 6 deletions(-) > Looks better now, thanks. Acked-by: Bruce Richardson