From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9AE121BB8F for ; Fri, 11 May 2018 01:58:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 429EB21995; Thu, 10 May 2018 19:58:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 10 May 2018 19:58:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=7+4w3gqEIJ01/T F/2jTvWtabFya/cR0RgNJfB9r+WyE=; b=KTnIQJF3dgjFDWVNyC61yOnXdm7rfi H3BQSDBUAGLtdCcTX45tg+cadwb/MzUotIToZq4d1vBLbF9Y/9Qvgr6UChGFt+L5 Nv4TWl6Dk0l52CG7A+J76ZRWBnsZJUTBQCg/TIzbKl8/BkUhieTDbvn22s91Cvn5 aXRsDcCK8sqIo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=7+4w3gqEIJ01/TF/2jTvWtabFya/cR0RgNJfB9r+WyE=; b=bAnysK3m TCUoJJiUSsPsyDRvaQFjkUG98l3ErqQdOzZsDz1gXPiH4plpBaQxAMjRkTW0HZD0 WxT97ac0d4ILrN9zvjRjTD+k27kteALJimNsp5sw/x5jCz3oz/Sk+J+Jgo5cqx3k Q6LrqF1NwBPjBunfnFUyyXtUdlblloCtxE5MR9QVO0z/YkatC6ZV2CO4JklRj8MV lc+Ckg7p/FNxD+ayYLI9KsAWZ6ZOBTvbw/0MvYm+Q7Tmwm7RO/JA/Ku2eN+g0yUJ cVGdW0XC1gBHA14CJIh0CV+cfTRwuGjSAs6aAkNGLj2Kf5RPYjCnAS8WWjAM4rFE nYWkBss+w6zk/Q== X-ME-Sender: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 581E7E4393; Thu, 10 May 2018 19:58:44 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: matan@mellanox.com, arybchenko@solarflare.com, stephen@networkplumber.org, ferruh.yigit@intel.com Date: Fri, 11 May 2018 01:58:26 +0200 Message-Id: <20180510235836.1099-2-thomas@monjalon.net> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180510235836.1099-1-thomas@monjalon.net> References: <20180509094337.26112-1-thomas@monjalon.net> <20180510235836.1099-1-thomas@monjalon.net> Subject: [dpdk-dev] [PATCH v3 01/11] ethdev: fix debug log of owner id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 23:58:45 -0000 The owner id is 64-bit. On 32-bit environment, it must be printed with PRIX64. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index ae239f97f..d0eba26ab 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -376,7 +376,7 @@ rte_eth_is_valid_owner_id(uint64_t owner_id) { if (owner_id == RTE_ETH_DEV_NO_OWNER || rte_eth_dev_shared_data->next_owner_id <= owner_id) { - RTE_PMD_DEBUG_TRACE("Invalid owner_id=%016lX.\n", owner_id); + RTE_PMD_DEBUG_TRACE("Invalid owner_id=%016"PRIX64".\n", owner_id); return 0; } return 1; @@ -426,7 +426,7 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id, port_owner = &rte_eth_devices[port_id].data->owner; if (port_owner->id != old_owner_id) { RTE_PMD_DEBUG_TRACE("Cannot set owner to port %d already owned" - " by %s_%016lX.\n", port_id, + " by %s_%016"PRIX64".\n", port_id, port_owner->name, port_owner->id); return -EPERM; } @@ -439,7 +439,7 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id, port_owner->id = new_owner->id; - RTE_PMD_DEBUG_TRACE("Port %d owner is %s_%016lX.\n", port_id, + RTE_PMD_DEBUG_TRACE("Port %d owner is %s_%016"PRIX64".\n", port_id, new_owner->name, new_owner->id); return 0; @@ -491,8 +491,8 @@ rte_eth_dev_owner_delete(const uint64_t owner_id) RTE_ETH_FOREACH_DEV_OWNED_BY(port_id, owner_id) memset(&rte_eth_devices[port_id].data->owner, 0, sizeof(struct rte_eth_dev_owner)); - RTE_PMD_DEBUG_TRACE("All port owners owned by %016X identifier" - " have removed.\n", owner_id); + RTE_PMD_DEBUG_TRACE("All port owners owned by %016"PRIX64 + " identifier have removed.\n", owner_id); } rte_spinlock_unlock(&rte_eth_dev_shared_data->ownership_lock); -- 2.16.2