From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f68.google.com (mail-pl0-f68.google.com [209.85.160.68]) by dpdk.org (Postfix) with ESMTP id BF1E81C914 for ; Fri, 11 May 2018 20:11:00 +0200 (CEST) Received: by mail-pl0-f68.google.com with SMTP id a39-v6so3704709pla.10 for ; Fri, 11 May 2018 11:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YXKcIKRzGsceLl3W6Wy8qrm/ZoCiiloI5mHpWagTTHU=; b=GO8yRe+DAGw9YQLY7Ykg6npqg8597SHsuIsGjGDPoqiEmIYzQhhAHXo/YoJk4sFU+M FDNSKkgvQSNdkMlPdzjFiczraihjcB0tb/EriVIENZb17Sg5OpvytpLgklqQrfuJPp+M eRuIOC8GtvDS9FdIRCb7I5qSheLaTfywvgJTMXuKYUaYD1FQvdBd0CJAxRNHPfxVOZHq Xid5ywDZLkK5YQ71gFjL57C+TH9N6OJyTvSevn59Q/4PiBI0UzXo2OOzYIDNyOqgLtaB y/mHGhJpsUIGVBQHlgumgGVyhfIYUK8h2+BJdTLP1EdYop2opW+ZfpoWX2L0T3T+UZyU F3Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YXKcIKRzGsceLl3W6Wy8qrm/ZoCiiloI5mHpWagTTHU=; b=qe5JKfs7iNLBm3BRzuu+71/zpr0Kjo4xOCJ7rXOo9KAaankk+ZDMbb6TIz6PztuO6F ly2ZK3SnJphkTRq875bmAzo9UzcQsr4WLV/GZ6xev0/3O6G5ZWdllXzmPSz00COAxTVz 7vKf3hONuoFjoxSIkTX7NaUXBBzIRmj2Mt4J1AqgwzC/C47ahTEz3k/VDareErCDq/T4 qcVYyVDOFObsZV8xMxUtWTLGQDgE14JCpSw4YSEkk9tGbOHPW8xAuTlCJLLiIwdaT01d fkpYp+s5tkcGAh3LHBC6MCXu3XCUjbHoucRble7L38orzk6NRiUBTNNjTE9gDxi1MFmO 0xOg== X-Gm-Message-State: ALKqPwfxMlfwnm8Ax6Y3afKJN3NyO1IcLBNFA9Q9Z5DnBIQw0kTZNNxR 8Ok7Mssh2ne1OQiBXhvIaqYGXg== X-Google-Smtp-Source: AB8JxZrTKF+DZdcaOnxQXbRjtRKu+QKxW0/nITi8Xj0DTvfsb/DPR3lERpC1zI3T/809Sy/z8p8tVQ== X-Received: by 2002:a17:902:5481:: with SMTP id e1-v6mr6358441pli.137.1526062259806; Fri, 11 May 2018 11:10:59 -0700 (PDT) Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id r20-v6sm8198693pff.152.2018.05.11.11.10.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 11:10:59 -0700 (PDT) Date: Fri, 11 May 2018 11:10:57 -0700 From: Stephen Hemminger To: "De Lara Guarch, Pablo" Cc: Andy Green , "dev@dpdk.org" , "Patil, Harish" , "Mody, Rasesh" , "stable@dpdk.org" Message-ID: <20180511111057.64b617f3@xeon-e3> In-Reply-To: References: <152600339444.53624.14086407337377549776.stgit@localhost.localdomain> <152600348247.53624.13691884496521997911.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 18:11:01 -0000 On Fri, 11 May 2018 16:32:24 +0000 "De Lara Guarch, Pablo" wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green > > Sent: Friday, May 11, 2018 2:51 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison > >=20 > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: > > In function =E2=80=98elink_check_kr2_wa=E2=80=99: > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28: > > error: bitwise comparison always evaluates to false [-Werror=3Dtautolog= ical- > > compare] > > ((next_page & 0xe0) =3D=3D 0x2)))); > > --- > > drivers/net/bnx2x/elink.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > >=20 > > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index > > 99684a5f9..2aef2b6da 100644 > > --- a/drivers/net/bnx2x/elink.c > > +++ b/drivers/net/bnx2x/elink.c > > @@ -12919,9 +12919,7 @@ static void elink_check_kr2_wa(struct elink_par= ams > > *params, > > * but only KX is advertised, declare this link partner as non-KR2 > > * device. > > */ > > - not_kr2_device =3D (((base_page & 0x8000) =3D=3D 0) || > > - (((base_page & 0x8000) && > > - ((next_page & 0xe0) =3D=3D 0x2)))); > > + not_kr2_device =3D !(base_page & 0x8000); > >=20 > > /* In case KR2 is already disabled, check if we need to re-enable it = */ > > if (!(vars->link_attr_sync & LINK_ATTR_SYNC_KR2_ENABLE)) { =20 >=20 > Looks like a good fix, but I wonder what's the actual intention of that c= onditional. > CC'ing the maintainers and Stephen Hemminger (the author of this code) to= figure it out. >=20 > Apart from that, missing signed-off-by, fixes line and Cc stable: >=20 > Fixes: b5bf7719221d ("bnx2x: driver support routines") > Cc: stable@dpdk.org >=20 Actually, I didn't write this. It came from contractors. Based of FreeBSD driver so look there.