From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C38BC1C17C; Mon, 14 May 2018 05:20:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2018 20:20:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,398,1520924400"; d="scan'208";a="228245648" Received: from dpdk9.bj.intel.com ([172.16.182.183]) by fmsmga006.fm.intel.com with ESMTP; 13 May 2018 20:20:49 -0700 From: zhiyong.yang@intel.com To: dev@dpdk.org Cc: ferruh.yigit@intel.com, stable@dpdk.org, Zhiyong Yang Date: Mon, 14 May 2018 11:20:48 +0800 Message-Id: <20180514032048.34896-1-zhiyong.yang@intel.com> X-Mailer: git-send-email 2.14.3 Subject: [dpdk-dev] [PATCH] app/testpmd: fix print unused parameter name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 03:20:54 -0000 The second parameter "name" in the function rte_eth_dev_detach has been already redefined as "char *name __rte_unused", "port_id" is printed instead of "name" in testpmd. Fixes: b65ecf199324 ("devargs: rename legacy API") Cc: stable@dpdk.org Signed-off-by: Zhiyong Yang --- app/test-pmd/testpmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 664c43554..02a28199b 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1985,7 +1985,7 @@ detach_port(portid_t port_id) port_flow_flush(port_id); if (rte_eth_dev_detach(port_id, name)) { - TESTPMD_LOG(ERR, "Failed to detach port '%s'\n", name); + TESTPMD_LOG(ERR, "Failed to detach port %u\n", port_id); return; } @@ -1993,8 +1993,8 @@ detach_port(portid_t port_id) update_fwd_ports(RTE_MAX_ETHPORTS); - printf("Port '%s' is detached. Now total ports is %d\n", - name, nb_ports); + printf("Port %u is detached. Now total ports is %d\n", + port_id, nb_ports); printf("Done\n"); return; } -- 2.14.3