From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 4F79F1B81F for ; Tue, 15 May 2018 11:00:26 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id q3-v6so15122635wrj.6 for ; Tue, 15 May 2018 02:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=4/2HLs5WbRSLFUPaC9PJU/p0ZtjUIsSI9Rhn9VObNiE=; b=I0psliPkT39fF736XrcqanGuruZ8gnqDUQNa0Spu2HvVWOKlzNR7TbcfqZkwE+QyCG eqlprMwcZjjz0pNjEL8c5P6lUtwJ8SNystG091ntzZWWH0k4NGcoIRsc03Pcaza7ouGu CGJvruCXpai5m/5stPpYIvAyv4IxSgR37UjbF3IAp88jUXbvyiLhMLf8z/YAjHd62Bu6 hu1MxcOM326QvHit6w20mfCGY84yxFULh/DeVikeiOOVkzu8T5LhlAWTRp+9Xpt4O7gQ Ko3oy0QNQCDVOlqUSpOPsHtvExhjnie3kAK2DRd1pDirVP8POGjtLR1bR3KxPgGfADUI VlVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=4/2HLs5WbRSLFUPaC9PJU/p0ZtjUIsSI9Rhn9VObNiE=; b=LEBB+y/JsBN3wWyVXNC0Gzy9zkYDrTueJCMy2DMoHx4JPSYxDBKy3r5cypous6PPNe 6KRbLcyfxrwAkrFfPMM2SBimgjhamiw70OM5WA3ITWesS6m3M1AbIVLTP9LtvpUDnMeJ pqHTzRM9NE6fsr/gum+gXBW9sQFVOh+e/fr8l331ebnvso+CUYK2rcKkDQI9rgJg4V+T XF8elV2SJwMjvnZO/MKbASfeWupSk0GqqLiKbJbXkfWtouuz97sJox792RxurgSE4eoX H3cxhmgfCXFq7fYeQGuwlIDi+izQc+3EnRHnhac99uvNKPrB7pJiwPgEbV4yawLmgBJl ugRg== X-Gm-Message-State: ALKqPwdy5rj4Dj8iPfxd8ISaUerEJcWxf8rFbJoXdShT5ujSMQ+W94kc MD2XdZQJF9jVFfhjYB+CfuMq X-Google-Smtp-Source: AB8JxZqYg+0RvZfF4qGukylyezrEsYbDmvV+jJWys4YEz+k4r/fMDy+238d/VPjXy6nvr+CW76LbxQ== X-Received: by 2002:adf:c4c4:: with SMTP id o4-v6mr9720637wrf.173.1526374826034; Tue, 15 May 2018 02:00:26 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o53-v6sm21064572wrc.96.2018.05.15.02.00.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 May 2018 02:00:24 -0700 (PDT) Date: Tue, 15 May 2018 11:00:10 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: Yongseok Koh , Adrien Mazarguil , "dev@dpdk.org" Message-ID: <20180515090010.dztr6xljcntqznpr@laranjeiro-vm.dev.6wind.com> References: <20180502231654.7596-1-yskoh@mellanox.com> <20180509110906.19462-1-yskoh@mellanox.com> <20180509110906.19462-5-yskoh@mellanox.com> <274843e9-ed82-9576-baf8-a704babf64c5@intel.com> <2DDD3185-6284-4BA3-A187-AED4C96407EB@mellanox.com> <2F032BAA-5743-4DA6-96B6-BBDFDCE0CF69@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx4: add new Memory Region support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 09:00:26 -0000 On Thu, May 10, 2018 at 08:29:03PM +0100, Ferruh Yigit wrote: > On 5/10/2018 7:01 AM, Yongseok Koh wrote: > > > >> On May 9, 2018, at 8:00 PM, Yongseok Koh wrote: > >> > >> > >>> On May 9, 2018, at 4:12 PM, Ferruh Yigit wrote: > >>> > >>> On 5/9/2018 12:09 PM, Yongseok Koh wrote: > >>> <...> > >>> > >>>> +/** > >>>> + * Insert an entry to B-tree lookup table. > >>>> + * > >>>> + * @param bt > >>>> + * Pointer to B-tree structure. > >>>> + * @param entry > >>>> + * Pointer to new entry to insert. > >>>> + * > >>>> + * @return > >>>> + * 0 on success, -1 on failure. > >>>> + */ > >>>> +static int > >>>> +mr_btree_insert(struct mlx4_mr_btree *bt, struct mlx4_mr_cache *entry) > >>>> +{ > >>>> + struct mlx4_mr_cache *lkp_tbl; > >>>> + uint16_t idx = 0; > >>>> + size_t shift; > >>>> + > >>>> + assert(bt != NULL); > >>>> + assert(bt->len <= bt->size); > >>>> + assert(bt->len > 0); > >>>> + lkp_tbl = *bt->table; > >>>> + /* Find out the slot for insertion. */ > >>>> + if (mr_btree_lookup(bt, &idx, entry->start) != UINT32_MAX) { > >>>> + DEBUG("abort insertion to B-tree(%p):" > >>>> + " already exist at idx=%u [0x%lx, 0x%lx) lkey=0x%x", > >>>> + (void *)bt, idx, entry->start, entry->end, entry->lkey); > >>> > >>> This and various other logs causing 32bits build error because of %lx usage. Can > >>> you please check them? > >>> > >>> I am feeling sad to complain a patch like this just because of log format issue, > >>> we should find a solution to this issue as community, either checkpatch checks > >>> or automated 32bit builds, I don't know. > >> > >> Bummer. I have to change my bad habit of using %lx. And we will add 32-bit build > >> check to our internal system to filter this kind of mistakes beforehand. > >> > >> Will work with Shahaf to fix it and rebase next-net-mlx. > > > > Ferruh, I've sent out a patch to Shahaf to change printing format specifiers and > > Shahaf will squash it into the previous patches. > > > > However, it seems we had stopped supporting 32-bit compilation since Nelio's > > commit [1] > > > > Not sure I'm doing right but I'm compiling it for T=i686-native-linuxapp-gcc and > > still having a few more errors even except for my code. And even if I fix all of > > the errors, linkage fails as explained in the commit message of [1]. > > > > Are you sure you encountered this 32b compilation issue for the first time? On mlx5 32 bits has been disabled as Mellanox OFED does not support 32bits compilation whereas RDMA-Core supports it. I've just taken a look on Mellanox Website, Mellanox OFED 4.3-3.0.2.1 is still not available for 32bits. We cannot assume the support exists. > I do just compilation on mlx drivers. > And building only mlx4 for 32bits, mlx5 doesn't support 32bits as you point out > below patch. mlx4 32bit compiles fine with me as same config you have used. > > Also features documentation [2] verifies this, mlx4 supports 32bits but mlx5 not. > > [2] > https://dpdk.org/browse/next/dpdk-next-net/tree/doc/guides/nics/features/mlx4.ini?h=v18.02#n32 > https://dpdk.org/browse/next/dpdk-next-net/tree/doc/guides/nics/features/mlx5.ini?h=v18.02#n42 > > > > > > > [1] http://dpdk.org/browse/dpdk/commit/?id=ebbb81eb27daca0a89ee8f228fcf141d9eb6ef1c > > > > > > Thanks, > > Yongseok > > > > > -- Nélio Laranjeiro 6WIND