From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Doherty, Declan" <declan.doherty@intel.com>,
"andy@warmcat.com" <andy@warmcat.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] app/crypto-perf: fix memcpy source range
Date: Wed, 16 May 2018 17:29:16 +0530 [thread overview]
Message-ID: <20180516115914.GA25489@jerin> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CD0C3F1@IRSMSX108.ger.corp.intel.com>
> > ---
> > test/test/test_cryptodev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index
> > 680082f2b..169ecdef3 100644
> > --- a/test/test/test_cryptodev.c
> > +++ b/test/test/test_cryptodev.c
> > @@ -6616,7 +6616,7 @@ test_multi_session_random_usage(void)
> > ts_params->session_mpool);
> >
> > rte_memcpy(&ut_paramz[i].ut_params, &testsuite_params,
> > - sizeof(struct crypto_unittest_params));
> > + sizeof(struct crypto_testsuite_params));
>
> Actually, the source address is wrong.
Makes sense.
> The fix should be:
>
> - rte_memcpy(&ut_paramz[i].ut_params, &testsuite_params,
> + rte_memcpy(&ut_paramz[i].ut_params, &unittest_params,
>
> Thanks for reporting this issue.
Will send the v2.
> Pablo
next prev parent reply other threads:[~2018-05-16 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 6:39 [dpdk-dev] [PATCH 1/2] app/crypto-perf: use strcpy for allocated string Jerin Jacob
2018-05-16 6:39 ` [dpdk-dev] [PATCH 2/2] app/crypto-perf: fix memcpy source range Jerin Jacob
2018-05-16 11:40 ` De Lara Guarch, Pablo
2018-05-16 11:59 ` Jerin Jacob [this message]
2018-05-16 9:50 ` [dpdk-dev] [PATCH 1/2] app/crypto-perf: use strcpy for allocated string De Lara Guarch, Pablo
2018-05-16 12:28 ` [dpdk-dev] [PATCH v2 " Jerin Jacob
2018-05-16 12:28 ` [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: fix memcpy source Jerin Jacob
2018-05-16 12:44 ` Andy Green
2018-05-16 12:50 ` De Lara Guarch, Pablo
2018-05-17 16:31 ` De Lara Guarch, Pablo
2018-05-17 16:31 ` [dpdk-dev] [PATCH v2 1/2] app/crypto-perf: use strcpy for allocated string De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516115914.GA25489@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=andy@warmcat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).