From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id BD2FCD818 for ; Wed, 16 May 2018 16:55:56 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id o78-v6so2605086wmg.0 for ; Wed, 16 May 2018 07:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zGv3voO8Cwsm0AcNgY7y70Gp6FEvSJdma3yHElDiPWk=; b=dl0wRoKQFC7Zdt/BRloHR0NMwNzn4mYcN9OKwP6hcMJxKfeW7nhW2KGjTSyw6lNbvl mRKoxoqNldLnqgBIu16eatLC9NwW8jv3mE4WQ9k3nZf+SrJTjeo/NNqGQmUJLLQOcLCD 1jQLwYAKjJHAX8W83nHpYHwl1I7hXZdY0SJyJ5FSR/WnOHZCGAmcw5RpiOSRHEn8W0We 173fehhnXlmhmJ9RmoNg0OrpD02aiqyb1U9FXfoaWhUyVeRQ4NBVVWUIUuCP9hmMXg9E wWboFTrw2+FGzdswKNkvuRvav5wqgX2B/88s6bryq4elZC6u8to/rcaavRxeqtJUXdfU S+Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zGv3voO8Cwsm0AcNgY7y70Gp6FEvSJdma3yHElDiPWk=; b=UcJ5YcsMmI0R+Xdd6H13wEy2bW4j74sPSxb/aDcKHcIITS8DjWMODcQkRlgTgZEWfr 2JxvWYnAOxWZ+sF0CRSjzZdSb9OyaoHC6ICln6E09yndGa9ec5DbFFkOPMgqeb1TDE2q 4rQXz8Qpa6icZNUJzOClbVTJ+9LGeiF0gOrOrK37UqeW1F321oUYmnRSg0Cuh8n9UUV6 fHbpsseK3+BFBoq9Ao53MIF8wUuQISqKnJVQ3UsF9fRaR8JEd1bTnFbwiP1tjxPmcfrA j6eCNwywaFRxwTa9EVe6b+zd+HF0fkEn1YsWHXpE9cCuIH7TYIt4OsEYIEU3Mw/WIsQg A/8g== X-Gm-Message-State: ALKqPweXrcA5rbiV5EDKYtykDulArVPF1Vzt7+atQslB4119SriUdUWy 31bpxr0RiPSyhgkj4j9jIQsqzw== X-Google-Smtp-Source: AB8JxZr1kvK0gjvAS5DikLdXk4DyQxWLzjc0uWfZiWavztW+w3d3D4e4JZigbJusDa9ctFmrr2uC1w== X-Received: by 2002:a1c:e156:: with SMTP id y83-v6mr946026wmg.92.1526482556279; Wed, 16 May 2018 07:55:56 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x128-v6sm3108681wmg.2.2018.05.16.07.55.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 May 2018 07:55:55 -0700 (PDT) Date: Wed, 16 May 2018 16:55:34 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Wisam Jaddo Cc: jingjing.wu@intel.com, wenzhuo.lu@intel.com, thomas@monjalon.net, rasland@mellanox.com, dev@dpdk.org, shahafs@mellanox.com Message-ID: <20180516145534.3ynumxtgbw4iywff@bidouze.vm.6wind.com> References: <1525869279-10035-1-git-send-email-wisamm@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1525869279-10035-1-git-send-email-wisamm@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 0/2] app/testpmd: introduce new commands in forward topology X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 14:55:56 -0000 Hi, On Wed, May 09, 2018 at 03:34:37PM +0300, Wisam Jaddo wrote: > 1- Add new forward topology (custom): This toplogy will > allow to create any topoloy you may need. > 2- Add new command to set the custom toplogy. > 3- Add new command to set the topoly on the fly. I have had the same kind of issues when developping a PMD for a prototype NIC that had some queues behaving weirdly, or when using testpmd for regression testing with a incompatible topology that was impossible to change. I think this use-case is important for testpmd and this should be useful for many people. I think however that your approach is not flexible enough. One should not only be able to edit ports pairing, but also select specific (Rx) queue. Additionally, it should be possible to change the lcore forwarding a specific pair. Testpmd uses the concept of streams internally. I think the only way to have enough flexibility here is to expose this concept as a set of commands to define custom streams, and then to bind those streams to sets of lcores. You have found after testing that TX queues cannot be shared. This tool is also used for pure IO performance regression testing. Adding the support for shared TX queues would impact this use-case and I think this is not acceptable. At the very least, the default configuration should not be impacted (and I think compile-time options are now frowned upon). This is the reason it should be necessary to be able to define the set of lcores doing the forwarding: The lcore defines the TX queue used by a stream, this way the current testpmd arch is respected. Regards, -- Gaëtan Rivet 6WIND