From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 0A2FD37A6 for <dev@dpdk.org>; Thu, 17 May 2018 10:29:59 +0200 (CEST) Received: from core.dev.6wind.com (unknown [10.0.0.1]) by proxy.6wind.com (Postfix) with ESMTPS id 87870178D68; Thu, 17 May 2018 10:26:49 +0200 (CEST) Received: from [10.16.0.195] (helo=6wind.com) by core.dev.6wind.com with smtp (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>) id 1fJEID-0002Zj-Ph; Thu, 17 May 2018 10:29:46 +0200 Received: by 6wind.com (sSMTP sendmail emulation); Thu, 17 May 2018 10:29:45 +0200 Date: Thu, 17 May 2018 10:29:45 +0200 From: Olivier Matz <olivier.matz@6wind.com> To: Andy Green <andy@warmcat.com> Cc: dev@dpdk.org Message-ID: <20180517082945.pqu4xbq3o6ercv3c@glumotte.dev.6wind.com> References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152627459771.53156.7163539471805969182.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152627459771.53156.7163539471805969182.stgit@localhost.localdomain> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 06/23] rte_ring_generic.h: stack declarations before code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 17 May 2018 08:30:00 -0000 On Mon, May 14, 2018 at 01:09:57PM +0800, Andy Green wrote: > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > In function '__rte_ring_move_prod_head': > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > const uint32_t cons_tail = r->cons.tail; > ^~~~~ > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > In function '__rte_ring_move_cons_head': > /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:147:3: > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > const uint32_t prod_tail = r->prod.tail; > > Signed-off-by: Andy Green <andy@warmcat.com> > Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation") Acked-by: Olivier Matz <olivier.matz@6wind.com>