From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 889944C92 for ; Thu, 17 May 2018 12:47:41 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 03:47:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,410,1520924400"; d="scan'208";a="229381859" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by fmsmga006.fm.intel.com with SMTP; 17 May 2018 03:47:39 -0700 Received: by (sSMTP sendmail emulation); Thu, 17 May 2018 11:47:38 +0100 Date: Thu, 17 May 2018 11:47:37 +0100 From: Bruce Richardson To: Andy Green Cc: dev@dpdk.org Message-ID: <20180517104737.GA22048@bricha3-MOBL.ger.corp.intel.com> References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152627459268.53156.2149755990250830416.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152627459268.53156.2149755990250830416.stgit@localhost.localdomain> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4 05/23] /lib/librte_eal: stage cast from uint64 to long X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 10:47:42 -0000 On Mon, May 14, 2018 at 01:09:52PM +0800, Andy Green wrote: > /projects/lagopus/src/dpdk/build/include/rte_random.h: > In function 'rte_srand': > /projects/lagopus/src/dpdk/build/include/rte_random.h:34:10: > warning: conversion to 'long int' from 'long unsigned int' > may change the sign of the result [-Wsign-conversion] > srand48((long unsigned int)seedval); > > /projects/lagopus/src/dpdk/build/include/rte_random.h:51:8: > warning: conversion to 'uint64_t' {aka 'long unsigned int'} > from 'long int' may change the sign of the result > [-Wsign-conversion] > val = lrand48(); > ^~~~~~~ > /projects/lagopus/src/dpdk/build/include/rte_random.h:53:6: > warning: conversion to 'long unsigned int' from 'long int' > may change the sign of the result [-Wsign-conversion] > val += lrand48(); > > Signed-off-by: Andy Green > --- > lib/librte_eal/common/include/rte_random.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_random.h b/lib/librte_eal/common/include/rte_random.h > index 63bb28088..e30777b83 100644 > --- a/lib/librte_eal/common/include/rte_random.h > +++ b/lib/librte_eal/common/include/rte_random.h > @@ -31,7 +31,7 @@ extern "C" { > static inline void > rte_srand(uint64_t seedval) > { > - srand48((long unsigned int)seedval); > + srand48((long)(unsigned long)seedval); Is double-cast necessary here? Can we not just cast straight to long? > } > > /** > @@ -48,9 +48,9 @@ static inline uint64_t > rte_rand(void) > { > uint64_t val; > - val = lrand48(); > + val = (uint64_t)lrand48(); > val <<= 32; > - val += lrand48(); > + val += (uint64_t)lrand48(); > return val; > } > > Apart from the one minor comment above LGTM Acked-by: Bruce Richardson