From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9D4C56CD7 for ; Thu, 17 May 2018 14:56:30 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 05:56:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,410,1520924400"; d="scan'208";a="47292237" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by fmsmga002.fm.intel.com with SMTP; 17 May 2018 05:56:27 -0700 Received: by (sSMTP sendmail emulation); Thu, 17 May 2018 13:56:26 +0100 Date: Thu, 17 May 2018 13:56:25 +0100 From: Bruce Richardson To: Andy Green Cc: dev@dpdk.org Message-ID: <20180517125625.GA32@bricha3-MOBL.ger.corp.intel.com> References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152627457252.53156.7037125685610031955.stgit@localhost.localdomain> <20180517103658.GA16984@bricha3-MOBL.ger.corp.intel.com> <78e21755-2ef2-8a72-18cd-40e23f0d342e@warmcat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78e21755-2ef2-8a72-18cd-40e23f0d342e@warmcat.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4 01/23] lib/librte_eal: import libbsd strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 12:56:31 -0000 On Thu, May 17, 2018 at 08:35:21PM +0800, Andy Green wrote: > > > On 05/17/2018 06:36 PM, Bruce Richardson wrote: > > On Mon, May 14, 2018 at 01:09:32PM +0800, Andy Green wrote: > > > Signed-off-by: Andy Green > > > --- > > > lib/librte_eal/common/eal_common_string_fns.c | 34 ++++++++++++++++++++++++ > > > lib/librte_eal/common/include/rte_string_fns.h | 7 +---- > > > 2 files changed, 36 insertions(+), 5 deletions(-) > > > > > > > While I'm aware this was suggested by other reviewers, I really don't feel > > that it is necessary to actually import the code. If libbsd is present on > > the system, we will use it directly. If libbsd is not present, the snprintf > > provides an acceptable fallback for strlcpy IMHO. Having the full function > > without good justification seems excessive. > > Well, as you can probably guess, I don't really mind either way. > > This also implies another patch to export rte_strlcpy since it's no longer > an inline in the headers this way. > > I removed these patches and rebuilt dpdk and then lagopus without it with > the idea of pasting the compile error. But I can't reproduce the original > problem... since then I rebased on current master dpdk, got updated to gcc > 8.1 and added more patches on lagopus. > > So just drop this patch if you don't want the bsd lstrcpy. > Yes, let's drop it from the set for now anyway, if it's not solving any specific error. We can relook at it in 18.08 anyway. /Bruce