From: Stephen Hemminger <stephen@networkplumber.org>
To: yaochuhong <ych@panath.cn>
Cc: shijith.thotton@cavium.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var
Date: Sun, 20 May 2018 23:55:40 -0700 [thread overview]
Message-ID: <20180520235540.597588e8@xeon-e3> (raw)
In-Reply-To: <1526865655-59863-1-git-send-email-ych@panath.cn>
On Mon, 21 May 2018 09:20:53 +0800
yaochuhong <ych@panath.cn> wrote:
> Signed-off-by: yaochuhong <ych@panath.cn>
> ---
> drivers/net/liquidio/lio_ethdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c
>
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> old mode 100644
> new mode 100755
> index 0e0b5d8..bd47911
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -1405,6 +1405,12 @@ struct rte_lio_xstats_name_off {
> /* Configure RSS if device configured with multiple RX queues. */
> lio_dev_mq_rx_configure(eth_dev);
>
> + /* Before update the link info, set link_status64 to 0,
> + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained,
> + * and lio_dev->intf_open will be set to 0.
> + */
> + lio_dev->linfo.link.link_status64 = 0;
> +
> /* start polling for lsc */
> ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT,
> lio_sync_link_state_check,
Your mail system or editor is converting tabs to spaces.
Please run checkpatch on your submissions.
### [dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var
ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#88: FILE: drivers/net/liquidio/lio_ethdev.c
ERROR:TRAILING_WHITESPACE: trailing whitespace
#97: FILE: drivers/net/liquidio/lio_ethdev.c:1409:
+ * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, $
WARNING:LONG_LINE_COMMENT: line over 80 characters
#97: FILE: drivers/net/liquidio/lio_ethdev.c:1409:
+ * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained,
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#100: FILE: drivers/net/liquidio/lio_ethdev.c:1412:
+ lio_dev->linfo.link.link_status64 = 0;$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#101: FILE: drivers/net/liquidio/lio_ethdev.c:1413:
+ $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#101: FILE: drivers/net/liquidio/lio_ethdev.c:1413:
+ $
total: 3 errors, 3 warnings, 0 checks, 12 lines checked
prev parent reply other threads:[~2018-05-21 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 1:20 yaochuhong
2018-05-21 1:20 ` [dpdk-dev] [PATCH 2/3] fix Coding Style yaochuhong
2018-05-21 1:20 ` [dpdk-dev] [PATCH 3/3] add signoff yaochuhong
2018-05-21 10:07 ` Ferruh Yigit
2018-05-21 10:11 ` Yao chuhong
2018-05-21 6:55 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180520235540.597588e8@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=shijith.thotton@cavium.com \
--cc=ych@panath.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).