From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 082E39605 for ; Mon, 21 May 2018 08:55:43 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id w129-v6so6616122pfd.3 for ; Sun, 20 May 2018 23:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w69jrIuNEoXSMp8IyQ2cR40dcNvUPEUajJpeAEEreKo=; b=hCIvPS6IivNwN+bxV4MFECZKouGMLFzAcUs800U3epyZ/pvUsyp26cDnzTl+LpjiPX TuYAnt7Rb9WUHIanOgowzqHbMMAUIGYwAQ4/TgKkBSuj6eIvbOHt/pKG+95YAQP88pKK Sdr6B69cz5ubzlVGTxiHuqgxPuaMs5YphWkkS2m/ifJN1f0qNwauar6/m+MOOAMIzdMx 9d+S062fB0fxiLtWPFdHjpeLEcJ6bGTi6zPINaxE0JqpB3Ugm5Pv6rm8bhyVB0EK99gB mdKTkb1kwSiXpNlIVr4VG6py5v0vQ7EJI98t1RBFcri3id3mKB7rAlHoWgdD6WdiwU99 HzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w69jrIuNEoXSMp8IyQ2cR40dcNvUPEUajJpeAEEreKo=; b=kzZ5ADUcC0/2PCteXjvN+V6gXVVmN+mTE256pd6KlKqeeWKjPwW7qjPPk8MK4Op/Et 8Pb1DQQSPKMBFC6AK/SdvKzNwH+LVpDlmd9MkMn4aNe0JLOk92wR/8xwpOdgZS85WGN/ zdeEZ3D9YadnJ6uGWGKb+smkuQxJF0MpQ/Wc3kQatU6TGVDrctgONohuwTtqqEs9nGgW S7KZwNPHpgABo+uQSBKahpjFB+sz6g8w54GSzqDcNlvi/5+EGroopUgvvefLrUraljgk MBxXp1LWm9tWniKPbmGvEOXNihbQxR5Bvw9lmYfMlyVqqtupQ3UcC65MS8o8XFBrlyOh W6kA== X-Gm-Message-State: ALKqPwfpYFjSSiOSoX9BYXqn57BBiYWaWFbCxDz0E7MbK0CnMKTCuo+D ldDWkIuL17pGD5fqMpUchg/I2Q== X-Google-Smtp-Source: AB8JxZppotXWnC3OFFP2RuhfQoOAQo94GKP6wS9EvMkrPAzbx++oHLJkXOjm2J+5gdob/imIupst8A== X-Received: by 2002:a62:f17:: with SMTP id x23-v6mr19015225pfi.3.1526885742157; Sun, 20 May 2018 23:55:42 -0700 (PDT) Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id z7-v6sm17370015pgp.74.2018.05.20.23.55.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 May 2018 23:55:42 -0700 (PDT) Date: Sun, 20 May 2018 23:55:40 -0700 From: Stephen Hemminger To: yaochuhong Cc: shijith.thotton@cavium.com, dev@dpdk.org Message-ID: <20180520235540.597588e8@xeon-e3> In-Reply-To: <1526865655-59863-1-git-send-email-ych@panath.cn> References: <1526865655-59863-1-git-send-email-ych@panath.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 06:55:43 -0000 On Mon, 21 May 2018 09:20:53 +0800 yaochuhong wrote: > Signed-off-by: yaochuhong > --- > drivers/net/liquidio/lio_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > old mode 100644 > new mode 100755 > index 0e0b5d8..bd47911 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -1405,6 +1405,12 @@ struct rte_lio_xstats_name_off { > /* Configure RSS if device configured with multiple RX queues. */ > lio_dev_mq_rx_configure(eth_dev); > > + /* Before update the link info, set link_status64 to 0, > + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, > + * and lio_dev->intf_open will be set to 0. > + */ > + lio_dev->linfo.link.link_status64 = 0; > + > /* start polling for lsc */ > ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT, > lio_sync_link_state_check, Your mail system or editor is converting tabs to spaces. Please run checkpatch on your submissions. ### [dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #88: FILE: drivers/net/liquidio/lio_ethdev.c ERROR:TRAILING_WHITESPACE: trailing whitespace #97: FILE: drivers/net/liquidio/lio_ethdev.c:1409: + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, $ WARNING:LONG_LINE_COMMENT: line over 80 characters #97: FILE: drivers/net/liquidio/lio_ethdev.c:1409: + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, WARNING:LEADING_SPACE: please, no spaces at the start of a line #100: FILE: drivers/net/liquidio/lio_ethdev.c:1412: + lio_dev->linfo.link.link_status64 = 0;$ ERROR:TRAILING_WHITESPACE: trailing whitespace #101: FILE: drivers/net/liquidio/lio_ethdev.c:1413: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #101: FILE: drivers/net/liquidio/lio_ethdev.c:1413: + $ total: 3 errors, 3 warnings, 0 checks, 12 lines checked