From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id BC2C51DB8 for ; Mon, 21 May 2018 14:07:57 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2018 05:07:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,426,1520924400"; d="scan'208";a="42936207" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.55]) by orsmga008.jf.intel.com with SMTP; 21 May 2018 05:07:53 -0700 Received: by (sSMTP sendmail emulation); Mon, 21 May 2018 13:07:52 +0100 Date: Mon, 21 May 2018 13:07:52 +0100 From: Bruce Richardson To: Andy Green Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180521120751.GA22944@bricha3-MOBL.ger.corp.intel.com> References: <152686805827.58694.11447559809199835902.stgit@localhost.localdomain> <152690080971.12755.9675572999031608037.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152690080971.12755.9675572999031608037.stgit@localhost.localdomain> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal: change type of tmp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 12:07:58 -0000 On Mon, May 21, 2018 at 07:06:49PM +0800, Andy Green wrote: > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 793:2: note: in expansion of macro 'MOVEUNALIGNED_LEFT47' > MOVEUNALIGNED_LEFT47(dst, src, n, srcofs); > ^~~~~~~~~~~~~~~~~~~~ > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 649:51: warning: conversion from 'size_t' {aka 'long > unsigned int'} to 'int' may change value [-Wconversion] > case 0x0B: MOVEUNALIGNED_LEFT47_IMM(dst, src, > n, 0x0B); break; \ > ^ > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 616:15: note: in definition of macro 'MOVEUNALIGNED_LEFT47_IMM' > tmp = len; \ > ^~~ > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 793:2: note: in expansion of macro 'MOVEUNALIGNED_LEFT47' > MOVEUNALIGNED_LEFT47(dst, src, n, srcofs); > ^~~~~~~~~~~~~~~~~~~~ > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 618:13: warning: conversion to 'size_t' {aka 'long > unsigned int'} from 'int' may change the sign of the > result [-Wsign-conversion] > tmp -= len; \ > ^~ > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 649:16: note: in expansion of macro 'MOVEUNALIGNED_LEFT47_IMM' > case 0x0B: MOVEUNALIGNED_LEFT47_IMM(dst, src, > n, 0x0B); break; \ > ^~~~~~~~~~~~~~~~~~~~~~~~ > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 793:2: note: in expansion of macro 'MOVEUNALIGNED_LEFT47' > MOVEUNALIGNED_LEFT47(dst, src, n, srcofs); > ^~~~~~~~~~~~~~~~~~~~ > > /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: > 618:13: warning: conversion to 'size_t' {aka 'long > unsigned int'} from 'int' may change the sign of the > result [-Wsign-conversion] > tmp -= len; > ^~ > > We can eliminate the problems by setting the type of tmp to > size_t in the first place. > > After a suggestion by Bruce Richardson > > Signed-off-by: Andy Green > Fixes: d35cc1fe6a ("eal/x86: revert select optimized memcpy at run-time") > --- Thanks, this looks a better fix than loads of type-casting. Acked-by: Bruce Richardson