* [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API @ 2018-05-22 11:36 Maxime Coquelin 2018-05-22 11:41 ` Ferruh Yigit 2018-05-22 11:53 ` Tiwei Bie 0 siblings, 2 replies; 8+ messages in thread From: Maxime Coquelin @ 2018-05-22 11:36 UTC (permalink / raw) To: dev, tiwei.bie, ferruh.yigit; +Cc: Maxime Coquelin Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> --- drivers/net/vhost/rte_eth_vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index f473bbbb3..aadb2327c 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) struct pmd_internal *internal = dev->data->dev_private; const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; - internal->vlan_strip = rxmode->hw_vlan_strip; + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); - if (rxmode->hw_vlan_filter) + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) VHOST_LOG(WARNING, "vhost(%s): vlan filtering not available\n", internal->dev_name); -- 2.14.3 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API 2018-05-22 11:36 [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API Maxime Coquelin @ 2018-05-22 11:41 ` Ferruh Yigit 2018-05-22 11:49 ` Ferruh Yigit 2018-05-22 11:53 ` Tiwei Bie 1 sibling, 1 reply; 8+ messages in thread From: Ferruh Yigit @ 2018-05-22 11:41 UTC (permalink / raw) To: Maxime Coquelin, dev, tiwei.bie On 5/22/2018 12:36 PM, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API 2018-05-22 11:41 ` Ferruh Yigit @ 2018-05-22 11:49 ` Ferruh Yigit 2018-05-22 12:34 ` Ferruh Yigit 0 siblings, 1 reply; 8+ messages in thread From: Ferruh Yigit @ 2018-05-22 11:49 UTC (permalink / raw) To: Maxime Coquelin, dev, tiwei.bie On 5/22/2018 12:41 PM, Ferruh Yigit wrote: > On 5/22/2018 12:36 PM, Maxime Coquelin wrote: >> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API 2018-05-22 11:49 ` Ferruh Yigit @ 2018-05-22 12:34 ` Ferruh Yigit 0 siblings, 0 replies; 8+ messages in thread From: Ferruh Yigit @ 2018-05-22 12:34 UTC (permalink / raw) To: Maxime Coquelin, dev, tiwei.bie On 5/22/2018 12:49 PM, Ferruh Yigit wrote: > On 5/22/2018 12:41 PM, Ferruh Yigit wrote: >> On 5/22/2018 12:36 PM, Maxime Coquelin wrote: >>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> >> >> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Applied to dpdk-next-net/master, thanks. Dropped back from tree in favor of v2 of patch ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API 2018-05-22 11:36 [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API Maxime Coquelin 2018-05-22 11:41 ` Ferruh Yigit @ 2018-05-22 11:53 ` Tiwei Bie 2018-05-22 12:09 ` Tiwei Bie 1 sibling, 1 reply; 8+ messages in thread From: Tiwei Bie @ 2018-05-22 11:53 UTC (permalink / raw) To: Maxime Coquelin; +Cc: dev, ferruh.yigit On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- > drivers/net/vhost/rte_eth_vhost.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index f473bbbb3..aadb2327c 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) > struct pmd_internal *internal = dev->data->dev_private; > const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; > > - internal->vlan_strip = rxmode->hw_vlan_strip; > + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); > > - if (rxmode->hw_vlan_filter) > + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) > VHOST_LOG(WARNING, > "vhost(%s): vlan filtering not available\n", > internal->dev_name); To better align with the new offload API, I think we also need to announce those features in dev_infos_get. Best regards, Tiwei Bie ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API 2018-05-22 11:53 ` Tiwei Bie @ 2018-05-22 12:09 ` Tiwei Bie 2018-05-22 12:12 ` Maxime Coquelin 0 siblings, 1 reply; 8+ messages in thread From: Tiwei Bie @ 2018-05-22 12:09 UTC (permalink / raw) To: Maxime Coquelin; +Cc: dev, ferruh.yigit On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote: > On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > --- > > drivers/net/vhost/rte_eth_vhost.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > > index f473bbbb3..aadb2327c 100644 > > --- a/drivers/net/vhost/rte_eth_vhost.c > > +++ b/drivers/net/vhost/rte_eth_vhost.c > > @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) > > struct pmd_internal *internal = dev->data->dev_private; > > const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; > > > > - internal->vlan_strip = rxmode->hw_vlan_strip; > > + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); > > > > - if (rxmode->hw_vlan_filter) > > + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) > > VHOST_LOG(WARNING, > > "vhost(%s): vlan filtering not available\n", > > internal->dev_name); > > To better align with the new offload API, I think we > also need to announce those features in dev_infos_get. I mean offloads (I'm too used to say features recently...). Besides, maybe we can also take this chance to announce the DEV_TX_OFFLOAD_MULTI_SEGS offload. How do you think? Best regards, Tiwei Bie ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API 2018-05-22 12:09 ` Tiwei Bie @ 2018-05-22 12:12 ` Maxime Coquelin 2018-05-22 12:16 ` Tiwei Bie 0 siblings, 1 reply; 8+ messages in thread From: Maxime Coquelin @ 2018-05-22 12:12 UTC (permalink / raw) To: Tiwei Bie; +Cc: dev, ferruh.yigit On 05/22/2018 02:09 PM, Tiwei Bie wrote: > On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote: >> On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: >>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> >>> --- >>> drivers/net/vhost/rte_eth_vhost.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c >>> index f473bbbb3..aadb2327c 100644 >>> --- a/drivers/net/vhost/rte_eth_vhost.c >>> +++ b/drivers/net/vhost/rte_eth_vhost.c >>> @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) >>> struct pmd_internal *internal = dev->data->dev_private; >>> const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; >>> >>> - internal->vlan_strip = rxmode->hw_vlan_strip; >>> + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); >>> >>> - if (rxmode->hw_vlan_filter) >>> + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) >>> VHOST_LOG(WARNING, >>> "vhost(%s): vlan filtering not available\n", >>> internal->dev_name); >> >> To better align with the new offload API, I think we >> also need to announce those features in dev_infos_get. I'm looking at it, and agree we have to announce support for these offload features. > I mean offloads (I'm too used to say features recently...). > Besides, maybe we can also take this chance to announce the > DEV_TX_OFFLOAD_MULTI_SEGS offload. How do you think? Yes, and also DEV_TX_OFFLOAD_VLANiINSERT. Right? > Best regards, > Tiwei Bie > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API 2018-05-22 12:12 ` Maxime Coquelin @ 2018-05-22 12:16 ` Tiwei Bie 0 siblings, 0 replies; 8+ messages in thread From: Tiwei Bie @ 2018-05-22 12:16 UTC (permalink / raw) To: Maxime Coquelin; +Cc: dev, ferruh.yigit On Tue, May 22, 2018 at 02:12:36PM +0200, Maxime Coquelin wrote: > On 05/22/2018 02:09 PM, Tiwei Bie wrote: > > On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote: > > > On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: > > > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > > > --- > > > > drivers/net/vhost/rte_eth_vhost.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > > > > index f473bbbb3..aadb2327c 100644 > > > > --- a/drivers/net/vhost/rte_eth_vhost.c > > > > +++ b/drivers/net/vhost/rte_eth_vhost.c > > > > @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) > > > > struct pmd_internal *internal = dev->data->dev_private; > > > > const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; > > > > - internal->vlan_strip = rxmode->hw_vlan_strip; > > > > + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); > > > > - if (rxmode->hw_vlan_filter) > > > > + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) > > > > VHOST_LOG(WARNING, > > > > "vhost(%s): vlan filtering not available\n", > > > > internal->dev_name); > > > > > > To better align with the new offload API, I think we > > > also need to announce those features in dev_infos_get. > > I'm looking at it, and agree we have to announce support for these > offload features. > > > I mean offloads (I'm too used to say features recently...). > > Besides, maybe we can also take this chance to announce the > > DEV_TX_OFFLOAD_MULTI_SEGS offload. How do you think? > > Yes, and also DEV_TX_OFFLOAD_VLANiINSERT. Right? Yeah! Best regards, Tiwei Bie ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-05-22 12:34 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-05-22 11:36 [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API Maxime Coquelin 2018-05-22 11:41 ` Ferruh Yigit 2018-05-22 11:49 ` Ferruh Yigit 2018-05-22 12:34 ` Ferruh Yigit 2018-05-22 11:53 ` Tiwei Bie 2018-05-22 12:09 ` Tiwei Bie 2018-05-22 12:12 ` Maxime Coquelin 2018-05-22 12:16 ` Tiwei Bie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).