From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tiwei.bie@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5982C1F1C for <dev@dpdk.org>; Tue, 22 May 2018 14:15:52 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 05:15:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,430,1520924400"; d="scan'208";a="42973476" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.203]) by orsmga007.jf.intel.com with ESMTP; 22 May 2018 05:15:50 -0700 Date: Tue, 22 May 2018 20:16:11 +0800 From: Tiwei Bie <tiwei.bie@intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20180522121611.GA26608@debian> References: <20180522113639.32233-1-maxime.coquelin@redhat.com> <20180522115357.GA24273@debian> <20180522120937.GA26211@debian> <313c5cfe-f3d1-5003-48fa-271b6b29ec15@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <313c5cfe-f3d1-5003-48fa-271b6b29ec15@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH] net/vhost: convert to new Rx offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 22 May 2018 12:15:52 -0000 On Tue, May 22, 2018 at 02:12:36PM +0200, Maxime Coquelin wrote: > On 05/22/2018 02:09 PM, Tiwei Bie wrote: > > On Tue, May 22, 2018 at 07:53:57PM +0800, Tiwei Bie wrote: > > > On Tue, May 22, 2018 at 01:36:39PM +0200, Maxime Coquelin wrote: > > > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > > > --- > > > > drivers/net/vhost/rte_eth_vhost.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > > > > index f473bbbb3..aadb2327c 100644 > > > > --- a/drivers/net/vhost/rte_eth_vhost.c > > > > +++ b/drivers/net/vhost/rte_eth_vhost.c > > > > @@ -491,9 +491,9 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused) > > > > struct pmd_internal *internal = dev->data->dev_private; > > > > const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; > > > > - internal->vlan_strip = rxmode->hw_vlan_strip; > > > > + internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP); > > > > - if (rxmode->hw_vlan_filter) > > > > + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) > > > > VHOST_LOG(WARNING, > > > > "vhost(%s): vlan filtering not available\n", > > > > internal->dev_name); > > > > > > To better align with the new offload API, I think we > > > also need to announce those features in dev_infos_get. > > I'm looking at it, and agree we have to announce support for these > offload features. > > > I mean offloads (I'm too used to say features recently...). > > Besides, maybe we can also take this chance to announce the > > DEV_TX_OFFLOAD_MULTI_SEGS offload. How do you think? > > Yes, and also DEV_TX_OFFLOAD_VLANiINSERT. Right? Yeah! Best regards, Tiwei Bie