* [dpdk-dev] [PATCH v3] net/vhost: convert to new Rx/Tx offload API
@ 2018-05-22 12:50 Maxime Coquelin
2018-05-22 12:54 ` Tiwei Bie
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2018-05-22 12:50 UTC (permalink / raw)
To: dev, tiwei.bie, ferruh.yigit; +Cc: Maxime Coquelin
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
Changes since v2:
- Remove check for unsupported offload feature (Tiwei)
drivers/net/vhost/rte_eth_vhost.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index f473bbbb3..ba9d768a0 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -491,12 +491,7 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
struct pmd_internal *internal = dev->data->dev_private;
const struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
- internal->vlan_strip = rxmode->hw_vlan_strip;
-
- if (rxmode->hw_vlan_filter)
- VHOST_LOG(WARNING,
- "vhost(%s): vlan filtering not available\n",
- internal->dev_name);
+ internal->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP);
return 0;
}
@@ -1072,6 +1067,10 @@ eth_dev_info(struct rte_eth_dev *dev,
dev_info->max_rx_queues = internal->max_queues;
dev_info->max_tx_queues = internal->max_queues;
dev_info->min_rx_bufsize = 0;
+
+ dev_info->tx_offload_capa = DEV_TX_OFFLOAD_MULTI_SEGS |
+ DEV_TX_OFFLOAD_VLAN_INSERT;
+ dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP;
}
static int
--
2.14.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v3] net/vhost: convert to new Rx/Tx offload API
2018-05-22 12:50 [dpdk-dev] [PATCH v3] net/vhost: convert to new Rx/Tx offload API Maxime Coquelin
@ 2018-05-22 12:54 ` Tiwei Bie
2018-05-22 13:19 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Tiwei Bie @ 2018-05-22 12:54 UTC (permalink / raw)
To: Maxime Coquelin; +Cc: dev, ferruh.yigit
On Tue, May 22, 2018 at 02:50:19PM +0200, Maxime Coquelin wrote:
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks for the work!
Best regards,
Tiwei Bie
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v3] net/vhost: convert to new Rx/Tx offload API
2018-05-22 12:54 ` Tiwei Bie
@ 2018-05-22 13:19 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-05-22 13:19 UTC (permalink / raw)
To: Tiwei Bie, Maxime Coquelin; +Cc: dev
On 5/22/2018 1:54 PM, Tiwei Bie wrote:
> On Tue, May 22, 2018 at 02:50:19PM +0200, Maxime Coquelin wrote:
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-22 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 12:50 [dpdk-dev] [PATCH v3] net/vhost: convert to new Rx/Tx offload API Maxime Coquelin
2018-05-22 12:54 ` Tiwei Bie
2018-05-22 13:19 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).