From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com
 [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 5355928F3
 for <dev@dpdk.org>; Thu, 24 May 2018 23:09:00 +0200 (CEST)
Received: by mail-pl0-f66.google.com with SMTP id ay10-v6so1796597plb.1
 for <dev@dpdk.org>; Thu, 24 May 2018 14:09:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=5WxTK57RfvKAGGaYuu30Ucbu9zfSKoS00e0ezG1iQJE=;
 b=07ix71cirBTujdCztl52X+2NQ+jT18mPjPk99VKH8EVToZczd/5QPJP3zA+b92vPnY
 SiHcsYMew5yZlrMpNk7PbvBkcrrKc6OB3NCNJ1b8UckmKMHUb0U3DOmxGlBVrkOR7oYI
 5Wqs329wziU+MUObrv3bn+iqgnhgxhy7ZCh89PLEElcb2xzeBt1/2irFUlnScLdujS/F
 G5SbvPl3gyoQPpGJ6r+PfoquzRXnskLDsg8n99AA3CUCIFjmBkwFjZfU/QThJlYi5Hf7
 W6uiBr7LlAkD8BkOXQxQUO+85pN4qrAtrdKD+pAxYqHPyz4Ui0EmIE1NNSlsTZxTiuiO
 E8RQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=5WxTK57RfvKAGGaYuu30Ucbu9zfSKoS00e0ezG1iQJE=;
 b=h37HcPs9O5B1YZumr+1LLVh6QieDzdbCqQ5FSv9UizpQQogK1Ot0Mbai4bYyMmeG2E
 iHaJeoL3q5Je3ziy9xg1p+Gw1TFZWletwFUOkz5VBaZMR0dackMczn4GYmeOvxjiNToC
 /ovTiOCUlnee/UIJI67MhLPUAkrojIyAyWCTRb1IzJDzb7qlrANhe/Vw+K5kyUFNi8PE
 PYKMVcRMsyNuK+uLZfB8Abal27L/1zdHs1CCwMCsYOZHKsQ8jB63vxZcBEh5+SIa02/v
 BAgMpmjM9wigWP7VEJvkmaBaRWEEs4c5+4xBfkj2slGS5EqZBbETqd55ewPU48NpgM4X
 3tfg==
X-Gm-Message-State: ALKqPwfnnqifKdL2cJ/5xM9WbCGJ45KZvG1x4mjlDNzqP6fYI/6FBREe
 YP/gm1/CB9b8g+fsfZIImknqHw==
X-Google-Smtp-Source: AB8JxZr/amRO+E0IwH8Rw6EVetJdg3G9RUFmUtVkCGRWmyLhmg7j1CjOyYZOx+t+3f5/sYS+NTVPiw==
X-Received: by 2002:a17:902:3303:: with SMTP id
 a3-v6mr8969207plc.209.1527196139415; 
 Thu, 24 May 2018 14:08:59 -0700 (PDT)
Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107])
 by smtp.gmail.com with ESMTPSA id u9-v6sm42401951pfi.60.2018.05.24.14.08.59
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 24 May 2018 14:08:59 -0700 (PDT)
Date: Thu, 24 May 2018 14:08:56 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>, Baruch Siach
 <baruch@tkos.co.il>, "Mcnamara, John" <john.mcnamara@intel.com>, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20180524140856.6cb6c36f@xeon-e3>
In-Reply-To: <7564883.QMXTE167Kr@xps>
References: <2dfce93f986deb95eb5ac4773e020005d45f0c48.1481629710.git.baruch@tkos.co.il>
 <B27915DBBA3421428155699D51E4CFE2026891C2@IRSMSX103.ger.corp.intel.com>
 <20161219171434.GA188176@bricha3-MOBL3.ger.corp.intel.com>
 <7564883.QMXTE167Kr@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] gitignore: ignore top level build/ directory
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2018 21:09:00 -0000

On Tue, 22 May 2018 23:45:31 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 19/12/2016 18:14, Bruce Richardson:
> > On Mon, Dec 19, 2016 at 04:50:57PM +0000, Mcnamara, John wrote:  
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson  
> > > > On Mon, Dec 19, 2016 at 03:05:20PM +0100, Thomas Monjalon wrote:  
> > > > > 2016-12-13 12:02, Ferruh Yigit:  
> > > > > > On 12/13/2016 11:48 AM, Baruch Siach wrote:  
> > > > > > > RTE_OUTPUT defaults to build/.
> > > > > > >
> > > > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il>  
> > > > > >
> > > > > > There is a similar patch:
> > > > > > http://dpdk.org/dev/patchwork/patch/11637/
> > > > > >
> > > > > > If you want you can review/comment that one too.  
> > > > >
> > > > > Yes, sorry I've never commented above patch.
> > > > >
> > > > > I do not like filling .gitignore because I prefer seeing what is built
> > > > > or copied or whatever with "git status".
> > > > > What is really the benefit of .gitignore?  
> > > > 
> > > > I take the opposite view. I only like to see files that I actually care
> > > > about in the git status. Any build artifacts should be ignored by git as
> > > > they are not files that it ever should track. That way doing a build does
> > > > not change the status of the repo as git sees it.  
> > > 
> > > As a workaround I have the following in my .gitconfig:
> > > 
> > >     [core]
> > >     excludesfile = ~/.gitignore
> > > 
> > > Then I put the ignore rules in ~/.gitignore.
> > > 
> > > John
> > >   
> > Yes, I have something similar done, so this is not a problem for me
> > personally. I just find it strange that we don't make more use of
> > gitignore in DPDK. The file's name itself seems to imply that it should
> > be used to list out files that git should not track, and build output is
> > definitely one of those.  
> 
> I don't understand why we should hide the default build directory and not
> the other ones with different names.
> It would be perceived as inconsistent and confusing.

Almost all users will use the standard build/ directory.
The idea of gitignore is to allow git status to work correctly.
Looking at systemd, which also uses meson, the .gitignore file is:

*.a
*.cache
*.gch
*.log
*.o
*.plist
*.py[co]
*.stamp
*.swp
*.trs
*~
.config.args
.deps/
/*.gcda
/*.gcno
/*.tar.bz2
/*.tar.gz
/*.tar.xz
/GPATH
/GRTAGS
/GSYMS
/GTAGS
/TAGS
/ID
/build*
/coverage/
/image.raw
/image.raw.cache-pre-dev
/image.raw.cache-pre-inst
/install-tree
/mkosi.builddir/
/mkosi.output/
/tags
__pycache__/