From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id A1CE8DE0 for ; Mon, 28 May 2018 19:09:38 +0200 (CEST) Received: from cpe-2606-a000-111b-40b7-215-ff-fecc-4872.dyn6.twc.com ([2606:a000:111b:40b7:215:ff:fecc:4872] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1fNLe6-0001Py-3e; Mon, 28 May 2018 13:09:34 -0400 Date: Mon, 28 May 2018 13:08:49 -0400 From: Neil Horman To: Thomas Monjalon Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com, Ferruh Yigit , Stephen Hemminger Message-ID: <20180528170849.GA28057@neilslaptop.think-freely.org> References: <20180115190545.25687-1-nhorman@tuxdriver.com> <1725451.L7JxISGBU9@xps> <20180527210039.GA22397@neilslaptop.think-freely.org> <1614896.1p8jHt5N2x@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614896.1p8jHt5N2x@xps> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2018 17:09:38 -0000 On Mon, May 28, 2018 at 12:01:15AM +0200, Thomas Monjalon wrote: > 27/05/2018 23:00, Neil Horman: > > On Sun, May 27, 2018 at 09:34:13PM +0200, Thomas Monjalon wrote: > > > Hi Neil, > > > > > > Sorry, this patch has been forgotten during the whole release cycle. > > > > > Its ok, though that is frustrating, as we now need to re-familiarize ourselves > > with how this patch works. > > I understand and apologize. > No worries. > > > I see an issue about the dependency on filterdiff. > > > Is there a way to avoid it? > > > > > I suppose, but to do so would require some awk magic. Is there any advantage to > > having an awk dependency rather than a filterdiff dependency? filterdiff is a > > pretty universal tool. > > filterdiff is not installed on my machine. > I guess it is the same for a lot of people. > My guess is that awk is only installed on your machine because you needed it for another script (possibly this one). Neither is commonly installed by default, but both are readily available. > I will check how we can replace it. > No need, I know how I can use awk to replace it, the only question is, do we need to do it? I suppose there is an implicit advantage in just using ask, as we already require it. All thats needed is an awk program like the following: awk 'BEGIN {startprint=0;} /.*diff.*map.*/ {startprint=1;} \ /.*diff.*[^map].*/ {startprint=0 /.*/ {if (startprint) {print $0}}' its basically a state machine that prints every line in a file after hitting the regex diff.*map (i.e. a map file), and stops when it hits the next diff block that isn't for a map file. The above isn't exactly right, but its close. > [...] > > Fine, at this point, I don't know when I'll get to this though, its pretty busy > > here at the moment. > > This delay is my fault, and I want to help. > If I find a good solution, do you accept I send a version 7 of this patch? Sure, if you have the time to take care of it, that would be great, thanks. And thank you for asking. If I find time, I'll take a stab at it as well, but I think given Red Hats schedule, it will be a few weeks before I'm able. Best Neil > > >